Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <e74982c0-4942-1c46-1c53-6dd6e7677373@kernel.org>
Date:   Wed, 13 Sep 2023 07:29:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH 1/2] tty/serial: Sort drivers in makefile
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20230912103558.20123-1-ilpo.jarvinen@linux.intel.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20230912103558.20123-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12. 09. 23, 12:35, Ilpo Järvinen wrote:
> Sort drivers in alphabetic order in Makefile to make it easier to find
> the correct line. In case the CONFIG and filenames disagree, sort using
> the filename (but ignoring "serial" prefixes).

Overall looks good.

I just want to make sure you considered the below, as you don't say 
explicitly in the commit log.

The order in the makefile defines the link order. So built-in drivers 
are loaded in that order. So are you sure your patch doesn't change 
order of some drivers which need to be in a specific order?

thanks,
-- 
js
suse labs