Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <40ba8890-32d1-e440-29fd-b8f8db69acc5@intel.com>
Date:   Tue, 12 Sep 2023 15:06:37 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH 2/5] selftests/resctrl: Remove duplicate feature check
 from CMT test
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     <linux-kernel@vger.kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        <stable@vger.kernel.org>
References: <20230911111930.16088-1-ilpo.jarvinen@linux.intel.com>
 <20230911111930.16088-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230911111930.16088-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUhaZEdaUi94dnNOWWlCUkF6UTBqbnJsMmFPUWRlNnJPT3FRYkg3eHZpZWow?=
 =?utf-8?B?TkF3TEhwZDhRYi9CVXRaWGF5Q2hUeWZGZkJnQTlSSFJSMjVNMnNIbjFwanhP?=
 =?utf-8?B?VERqM3V6akJiZllGc1RsVjBRNXdZcjZWd2pxR0FjejEvamtYam1mWTUrSkZm?=
 =?utf-8?B?dUZvS2YyZ0dwcy9rcUZLTU52QUNxT0pibGJQUzNvWm9lUHhBOFNubldWNTlQ?=
 =?utf-8?B?V3VWMjdpWUc4NG0zS2Z5Sjg2Y0JkWEx5cmN1SkNyQjc0blhyNXNYRHNORnQw?=
 =?utf-8?B?Mk5RbTczeXF2RU9zS2VlbXRJeVhVZWQ3SXpDYjhmY3l0L1JHNzBRYWg2Wklx?=
 =?utf-8?B?ZEUvaVlKbStvdWRwY0QvQmdUMzVsRXZmVE5zVGRVeGZjREdtYVIvN0V2RkZ3?=
 =?utf-8?B?cjd2SnpKNExnUytYNnM4YWJPVFVzOG1RYXdVUTVKYkc5S3RJcUh6Zjh6ZTZu?=
 =?utf-8?B?TzV5REljU0t4cGh3L29rMldLZ2IvVkZvbGR6NGJRTGJiMFNtb0pwVHgvUm5X?=
 =?utf-8?B?OE5DbGwvM2FodWdKcS93NnB5VEZ3a0w2b3pXRmkvZGl1Sk53bUhlRkFvM0NC?=
 =?utf-8?B?SG4xS0k1QktpTGIrK3JWVTNGc2JNNG9iWTlUdWVNNUd1emV1cGhwd0VxcldQ?=
 =?utf-8?B?MUtoYVk2eFBFS3lUc01oZm1Ya3ZFaGlGZlRKT2ZiN2xFUGpmWEpXVFVrdVFS?=
 =?utf-8?B?VXJ0aEhkZ0JVN1RybjNNZTRxSDBjdDg0NDZEL3BuNzhVMVlJc21iU0JadnNI?=
 =?utf-8?B?d2taQjY5QnNqeDd1RHlsMzBvQ2VzZnhMY1JIU2R6bjZJMzU3Tnlicm5pZmYr?=
 =?utf-8?B?bXBHY0Z5RTZEbC9pdEJvMHBKdy9QOGZCYUtkU0QxQkRJUSt5MXF5Z2tydlpv?=
 =?utf-8?B?ajNrdUluZWtBcmRKNG4wZWIwKzkwNUEwZWVmMUdnTkN2OEFKdXpqOTUwcW5J?=
 =?utf-8?B?Vm1wS3hjWFZmYk9Oei9CKzNraUlocG00WklCRUJneW9QZk5FTE5hR1UrcUN5?=
 =?utf-8?B?RjA3OXhiSmsveTlDOHRhWnRUaDcydWpzVGt2dm83U0ZoMExtSi9ieEpOTXlz?=
 =?utf-8?B?Mndjb2NmVk9UMzRSNFFNb3ZFbHZZOHYzK3ZzS1A1Z0VvcHd4WGRvTDVvUUow?=
 =?utf-8?B?eEYzT1p3ZXZOYXRjQzk1c25EZHU4dkFhbHNPNTNBZVZYamNTTGd5dyt2UmU4?=
 =?utf-8?B?OUZZYU1XcFF1ekQ3OVhvSUEra1huUm1EWnRQWC9OU1UzeFFNREllbFBYNjhM?=
 =?utf-8?B?UkxGeG1RWmYxci92MGhLc2RFbm5GQkhha1RiaklqSllsSzAzbTdKZ0tqcW1H?=
 =?utf-8?B?Ykp3Y2Y2TjArYmFuMHh2clcwTjNoN3d0NWlRUzFlWVdNc2t3VWN5dStXaklJ?=
 =?utf-8?B?clkzZnpUR3JsVE9ST3NqdWQzMXBpRStFcXlTYlVLYlVlM3M2TGd2Vm5qanRL?=
 =?utf-8?B?SVFaV2pTWVQvUEM3b1Y4dDlVcEJ6ZVdGVm1QazhtWmtPZzFDQllvYzBSNENP?=
 =?utf-8?B?Yi9rOUt6bVMwR0JnT3ppSFB5RVg1bXNRUFhSMkhndDNiN2k5OVI2UjF5V2dh?=
 =?utf-8?B?Z0t5YnE3NzFxSmN0Vms2ZzZBWGE2c1ptZDRIMWtQWU9udzErMEtaTVJxUG9u?=
 =?utf-8?B?aGtVTUJZUWFtbTdpVEgzdHpkRmtOa3V5Q0tGWXFpZmtTU3c0ZGhlWE9MckVt?=
 =?utf-8?B?OTQ4ZXdCdlM0ZGtSRmlSR1U2eXg4UUFVWjFhTFY4MWZObDRhWjROeXJxVkRH?=
 =?utf-8?B?NmJXWlM4My9uUjF4dVkzOWU2SnA4bU1PM3RuMjFDdjZoMWNwZmJlREF5aXFX?=
 =?utf-8?B?WEw5c2Z0anZNZjZoTUFRcWV5em1tMWoyTnRGTmJtSXh2bWJoV1JSOG5jVG9T?=
 =?utf-8?B?MTlSWXJmb1Vha29HOEJlc3RLeERnOGtTOWJRM2ltM1V5RktZa0d1ZW9lb0Qy?=
 =?utf-8?B?a29rejhoOU9IM0Frc0lqOEltcnZ4NkVYbnZqTCthcDdWVGZEMVduTXZIWG9r?=
 =?utf-8?B?MDMrUkVvYUdsTEEwcFJUMi9PZkpGWDJCNkk3YS8wN1U5TTFuRGFhMGExc2Zl?=
 =?utf-8?B?Zkt0WTJ5MVlrOHRSVFYvbzVjdWFnZFpxNzBvekVUcFQ1YytDUElBc0hybld5?=
 =?utf-8?B?Y1lQb3F6MXBFSWRUS2Y3WWZUVDVPcVJKQ2JDeEJ4K2M1Z2Q5TlJUOTZ3eHpp?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 20718062-304c-48ae-622c-08dbb3dc89c5
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 22:06:38.9664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M3ISm2AwWVPewRYqXQ9RpDy8b5kpTUJ5ZTm8zJkzN4DrV0AvJcRMMkqlPkuPwn5iOwzpPkBtPcym/eA20eC9pAHiGL4dQLWY4+2axWZxWPo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6516
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 15:07:12 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

Hi Ilpo,

On 9/11/2023 4:19 AM, Ilpo Järvinen wrote:
> The test runner run_cmt_test() in resctrl_tests.c checks for CMT
> feature and does not run cmt_resctrl_val() if CMT is not supported.
> Then cmt_resctrl_val() also check is CMT is supported.
> 
> Remove the duplicated feature check for CMT from cmt_resctrl_val().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org>

This does not look like stable material to me. 

Reinette