Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 13 Sep 2023 09:43:34 +0200
Message-ID: <87y1ha4ixl.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc:     tiwai@suse.com, perex@perex.cz, arnd@arndb.de,
        masahiroy@kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ALSA: hda: intel-sdw-acpi: Use u8 type for link index
In-Reply-To: <20230912162617.29178-1-peter.ujfalusi@linux.intel.com>
References: <20230912162617.29178-1-peter.ujfalusi@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-7
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 12 Sep 2023 18:26:17 +0200,
Peter Ujfalusi wrote:
> 
> Use consistently u8 for sdw link index. The id is limited to 4, u8 is
> adequate in size to store it.
> 
> This change will also fixes the following compiler warning/error (W=1):
> 
> sound/hda/intel-sdw-acpi.c: In function ?sdw_intel_acpi_scan?:
> sound/hda/intel-sdw-acpi.c:34:35: error: ?-subproperties? directive output may be truncated writing 14 bytes into a region of size between 7 and 17 [-Werror=format-truncation=]
>    34 |                  "mipi-sdw-link-%d-subproperties", i);
>       |                                   ^~~~~~~~~~~~~~
> In function ?is_link_enabled?,
>     inlined from ?sdw_intel_scan_controller? at sound/hda/intel-sdw-acpi.c:106:8,
>     inlined from ?sdw_intel_acpi_scan? at sound/hda/intel-sdw-acpi.c:180:9:
> sound/hda/intel-sdw-acpi.c:33:9: note: ?snprintf? output between 30 and 40 bytes into a destination of size 32
>    33 |         snprintf(name, sizeof(name),
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    34 |                  "mipi-sdw-link-%d-subproperties", i);
>       |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> The warnings got brought to light by a recent patch upstream:
> commit 6d4ab2e97dcf ("extrawarn: enable format and stringop overflow warnings in W=1")
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Thanks, applied now.


Takashi