Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Chunhai Guo <guochunhai@vivo.com>
To:     viro@zeniv.linux.org.uk, brauner@kernel.org
Cc:     chao@kernel.org, jaegeuk@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chunhai Guo <guochunhai@vivo.com>
Subject: [PATCH] fs-writeback: writeback_sb_inodes: Do not increase 'total_wrote' when nothing is written
Date:   Tue, 12 Sep 2023 08:20:43 -0600
Message-Id: <20230912142043.283495-1-guochunhai@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GMnLJqIRqiJm0/bvZkhWH4qoy6bSfrbNcNzhrUna67qTKXbhH+NvGuXukDl9?=
 =?us-ascii?Q?gRlcH5glOey/OYOUKzmFAkpWtApTEk3WroE4AvyIam0/O61OF1SyrGFq8XwU?=
 =?us-ascii?Q?Fvnu+2Fd2iJJwmnuCZZfLKaaj1o6w0M/Vop/vutVVtiDVQE4PgO3gqwWAYWq?=
 =?us-ascii?Q?mvg2Z9hHuf1T5yPjvcpgfqjaJaYXzOGmHF0B1gCIO+UphM5z792AcHWVB5qj?=
 =?us-ascii?Q?qA17yOa/vr1+OzHlRR8LMLo+Pl2NQg4BfG+sryAMW6aIbY8ezLSmghTuDvyr?=
 =?us-ascii?Q?vPfUqWvoyFe8yRnBtY0OQVw5yN/goxnz8mMtfiUyZ0SVZeJJ3DS8/djIM1sq?=
 =?us-ascii?Q?RrwEUb/4MFjPZ/5NFTT1apU8dzAXCzKNc3ukeHtfmnrSWhGb2u7Z/cGFwkWq?=
 =?us-ascii?Q?W9BeHXnVfpL0lpMwkBGHv6og250INGKjcs6oQjSe3l5N8qja0bB0hDzFeikF?=
 =?us-ascii?Q?yB9+EFtcp31ywJfMxkWqiiQLKb+EvNzwlvVbiJqMrAFmcmx7YHpxhYMWy7qv?=
 =?us-ascii?Q?y9MBgtCq3jfUZSGCyGJsrfuJIvJpmpJmU0d0ZiEtFjROjToqYAlLmF/RfLkG?=
 =?us-ascii?Q?Y6auLCkuOIUIx7f8T+BYuBKv4Wd/WhaJQjEwaBtf1mDHyA5s9QMudz7IX/yG?=
 =?us-ascii?Q?X1A9+7s9CXB+kxb4jJk6/OHkWIi8/rg0O6NCRlvAWLUi5IZxYqL7xf7RpdYu?=
 =?us-ascii?Q?Amy/A2tpq/q7E7c7mqF/8C4ShwSlvwQrDUCVdum/ALUFIj5/nfrcU42umQM/?=
 =?us-ascii?Q?tj5rgfau81y0PJoeepyFbeZLb5pnmtqmmYI8Ksgsdi1XfpyT1/sFot4KikTp?=
 =?us-ascii?Q?I9mWLNlbDiWZ/DGfaEPLXKz/gzjfgGz7eT0DVVMAEjMBJEQFLv4BHx3dN62/?=
 =?us-ascii?Q?oHlvKnWUkJOp0hHKtM8oOL2YQmpjnW6i0bbM8OX2hP0QP4C7Sj703RRfw4Be?=
 =?us-ascii?Q?QEGi00n2FL+ltyXAy7ezqOsQ2hhgYnOHIsRKNTy8MbnXYTW7jVc761cCF+Ya?=
 =?us-ascii?Q?igY/mv3BJEsvjB/bFX9o+0GGeCpXX1lsE3sRsp/2a7DBuit3x9SpOnQ3B7Nt?=
 =?us-ascii?Q?dTReE/s5+c4Fg0JeVK1S0e4cGPC79zo2xqvFbaJGt1lVJopGWQLXb//jzGMX?=
 =?us-ascii?Q?XluY+kxk1VN9txHw3fev19g5jV/OqKVeY25gMpt9eauPa51T1w3GTeCzRD1H?=
 =?us-ascii?Q?nLBGrotG3bNaTBEr1KLRFvuuHPuyZwAHplIjd3w8MnyXOIr5N2TAKJYGWfWl?=
 =?us-ascii?Q?KEZx+OkFXTOETD+d24QdUAinkjXaFcqysnGAemywM5n/DgHejSNUEQCWezwy?=
 =?us-ascii?Q?pJJi4+nLvnz48c0mMr4W5hcN16TmfAB5nbN8LW0AVuAqqx7OOZ2a9jSgLlHF?=
 =?us-ascii?Q?fWiYIIBvrZ5uMuOwV9+pfiJCZld6eoy6Gpb+pRZ6MaxRzmd3otQXMP8hAutU?=
 =?us-ascii?Q?Qd1MyxERBSsiiMd2IOPWJohMWabPgz0XORHcfXPFo9dQ1J5bYtnB1QXsnidx?=
 =?us-ascii?Q?blZtyVFbezbgzRroao5z8MMGeVgFjwhmJI5nioCS5TN9yokzS8yxh5ADTz4N?=
 =?us-ascii?Q?O4bRmOY1xOmVNhSW4cK3jGMTKmmYXzEu7n9rkDyj?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ae9490e-d969-4148-2201-08dbb39a6e78
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3338.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 14:13:26.7325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kpNJa8+EaNrHuxaHKBEkN4Fr5PcHIasQYfkrh1BonpjOqMB/J+Cty7iwT6Bl5Cro4GfP6ZL7rMjK9H3yiCyiqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6108
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Sep 2023 07:13:55 -0700 (PDT)

I am encountering a deadlock issue as shown below. There is a commit
344150999b7f ("f2fs: fix to avoid potential deadlock") can fix this issue.
However, from log analysis, it appears that this is more likely a fake
progress issue similar to commit 68f4c6eba70d ("fs-writeback:
writeback_sb_inodes: Recalculate 'wrote' according skipped pages"). In each
writeback iteration, nothing is written, while writeback_sb_inodes()
increases 'total_wrote' each time, causing an infinite loop. This patch
fixes this issue by not increasing 'total_wrote' when nothing is written.

    wb_writeback        fsync (inode-Y)
blk_start_plug(&plug)
for (;;) {
  iter i-1: some reqs with page-X added into plug->mq_list // f2fs node page-X with PG_writeback
                        filemap_fdatawrite
                          __filemap_fdatawrite_range // write inode-Y with sync_mode WB_SYNC_ALL
                           do_writepages
                            f2fs_write_data_pages
                             __f2fs_write_data_pages // wb_sync_req[DATA]++ for WB_SYNC_ALL
                              f2fs_write_cache_pages
                               f2fs_write_single_data_page
                                f2fs_do_write_data_page
                                 f2fs_outplace_write_data
                                  f2fs_update_data_blkaddr
                                   f2fs_wait_on_page_writeback
                                     wait_on_page_writeback // wait for f2fs node page-X
  iter i:
    progress = __writeback_inodes_wb(wb, work)
    . writeback_sb_inodes
    .   __writeback_single_inode // write inode-Y with sync_mode WB_SYNC_NONE
    .   . do_writepages
    .   .   f2fs_write_data_pages
    .   .   .  __f2fs_write_data_pages // skip writepages due to (wb_sync_req[DATA]>0)
    .   .   .   wbc->pages_skipped += get_dirty_pages(inode) // wbc->pages_skipped = 1
    .   if (!(inode->i_state & I_DIRTY_ALL)) // i_state = I_SYNC | I_SYNC_QUEUED
    .    total_wrote++;  // total_wrote = 1
    .   requeue_inode // requeue inode-Y to wb->b_dirty queue due to non-zero pages_skipped
    if (progress) // progress = 1
      continue;
  iter i+1:
      queue_io
      // similar process with iter i, infinite for-loop !
}
blk_finish_plug(&plug)   // flush plug won't be called

Signed-off-by: Chunhai Guo <guochunhai@vivo.com>
---
 fs/fs-writeback.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 969ce991b0b0..54cdee906be9 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1820,6 +1820,7 @@ static long writeback_sb_inodes(struct super_block *sb,
 		struct inode *inode = wb_inode(wb->b_io.prev);
 		struct bdi_writeback *tmp_wb;
 		long wrote;
+		bool is_dirty_before;
 
 		if (inode->i_sb != sb) {
 			if (work->sb) {
@@ -1881,6 +1882,7 @@ static long writeback_sb_inodes(struct super_block *sb,
 			continue;
 		}
 		inode->i_state |= I_SYNC;
+		is_dirty_before = inode->i_state & I_DIRTY_ALL;
 		wbc_attach_and_unlock_inode(&wbc, inode);
 
 		write_chunk = writeback_chunk_size(wb, work);
@@ -1918,7 +1920,7 @@ static long writeback_sb_inodes(struct super_block *sb,
 		 */
 		tmp_wb = inode_to_wb_and_lock_list(inode);
 		spin_lock(&inode->i_lock);
-		if (!(inode->i_state & I_DIRTY_ALL))
+		if (!(inode->i_state & I_DIRTY_ALL) && is_dirty_before)
 			total_wrote++;
 		requeue_inode(inode, tmp_wb, &wbc);
 		inode_sync_complete(inode);
-- 
2.25.1