Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3098333rdb; Wed, 13 Sep 2023 01:45:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmVkC1ZpVoF47SgDJ098ej66XYk7o+YReCfBdywMNGHVB5DRVF5ikoGj/iJw+tm7lBr1Vu X-Received: by 2002:a05:6870:7089:b0:1b0:649f:e68a with SMTP id v9-20020a056870708900b001b0649fe68amr2028568oae.25.1694594720367; Wed, 13 Sep 2023 01:45:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694594720; cv=none; d=google.com; s=arc-20160816; b=0spmWJHh644Fi6R6KJiBZdhJ7GwUbhE7ZW0i28GDp/S+G3FgL//5ArXV9CcbqrraTf 8iDuAV/SWM62bSFIGdtasuh3W1tz4To8Lj2dzIhqjgC2MPmNcYAIuJGR6waLoDr76Kbh Nd/ALA/VPjdN7rZFs1EhJKTdp3TyF0GkiJ0UNJDC5JW/vr0TA8YBOA1/Yoyzm8CpwxHQ y0bnj0EaytZuDZv4S2cUf5njuQisRrsRcVCI2A45hqadSQxwnnQw2023+ci0b3DX3vfJ jHuqwqYVF0cIIR3YC+iE+VFTN6+O54bgZnEHnwjT2K5L/6QjIqX9zMQ2vxEmB2M4axfB nbqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=80dUG2PVN340smS+9vhjRWYkINCS4FRCkkflnDFjzjg=; fh=ZMLfvnyv/dnQVaNgCcqX07smkGeg8qtLfkNfkoUvV04=; b=ZkGLL6JQULNal179xC1tcF0l5RvDqvFByPYiOJWdkNgsuU3fLmzF2otREhhmA3PlHc C5vwyqPiU5CLLxbuBLXi3MEFdYDQlts+hj5m4RAMWNRoVK3igUI344Af6cOdxmZyDDCG RZ2vM+5PCGfV++ZoG2FxIQSHZiKemhlLU5kv19kSCwsFdplS9fzqlMgcdLyR8tc380jX S9bHyxXQyLctH1LG1t2WPwq2G5Rka/8rChuOadZQ+ZuGKzF4qCSy2vgZ+kfWqOXzmOuY ods4wjq/h5WuW0m58CePxKbJD/FpiPjP3ACsZo9Tcp8lJ4VQfrgb0fPAbkOoVgliOZCl CHBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id t184-20020a6381c1000000b0057760853711si6141117pgd.273.2023.09.13.01.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 01:45:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id AE8D4809840C; Wed, 13 Sep 2023 01:43:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238933AbjIMInL (ORCPT + 99 others); Wed, 13 Sep 2023 04:43:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235789AbjIMInK (ORCPT ); Wed, 13 Sep 2023 04:43:10 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5C2FFC3; Wed, 13 Sep 2023 01:43:06 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18C65C15; Wed, 13 Sep 2023 01:43:43 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 853863F67D; Wed, 13 Sep 2023 01:43:04 -0700 (PDT) Date: Wed, 13 Sep 2023 09:43:01 +0100 From: Sudeep Holla To: Oza Pawandeep Cc: catalin.marinas@arm.com, will@kernel.org, rafael@kernel.org, Sudeep Holla , lenb@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v5] cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer Message-ID: <20230913083908.dfanwizomj5i536k@bogus> References: <20230912172933.3561144-1-quic_poza@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230912172933.3561144-1-quic_poza@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 01:43:12 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email On Tue, Sep 12, 2023 at 10:29:33AM -0700, Oza Pawandeep wrote: > Arm? Functional Fixed Hardware Specification defines LPI states, > which provide an architectural context loss flags field that can > be used to describe the context that might be lost when an LPI > state is entered. > > - Core context Lost > - General purpose registers. > - Floating point and SIMD registers. > - System registers, include the System register based > - generic timer for the core. > - Debug register in the core power domain. > - PMU registers in the core power domain. > - Trace register in the core power domain. > - Trace context loss > - GICR > - GICD > > Qualcomm's custom CPUs preserves the architectural state, > including keeping the power domain for local timers active. > when core is power gated, the local timers are sufficient to > wake the core up without needing broadcast timer. > > The patch fixes the evaluation of cpuidle arch_flags, and moves only to > broadcast timer if core context lost is defined in ACPI LPI. > > Reviewed-by: Sudeep Holla IIRC, Rafael had acked this, perhaps missing the tag ? Also just add a note to Will/Catalin that Rafael has acked and prefer to take it via arm64 tree. -- Regards, Sudeep