Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3117554rdb; Wed, 13 Sep 2023 02:33:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4WtNXbLRBjmKJegV0bJOWl1s9qEuKWsvoH6Ba4seYWXLj9R9QzuWW/GMGoT7Bz9oBn8vz X-Received: by 2002:a05:6870:c18b:b0:1c4:ee87:d3f6 with SMTP id h11-20020a056870c18b00b001c4ee87d3f6mr2271720oad.50.1694597585290; Wed, 13 Sep 2023 02:33:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694597585; cv=none; d=google.com; s=arc-20160816; b=cbKJric5tAkmIOTAEBSgyhFB+ql1qOm/zq8S+ozrEpqStCAMsyyVicAXid56ojMURi zYpjnXuVzQIsAutz0coU7IPll2BhG7W8QIkR0wsRMbxE3NDVCvXcXutSOdrU8BGJ1rWJ meaLEkK3iklI0vn1P5SJQKJf/mTWov/G94eDlFhpBHYrJJoVsOAOmrWND6p8Lb3L5vIb oNesKi7XP+T9D+kWJxyxa1uPoya+kQ+zsyyoYxcieI4afjzyYtcBsp77z0b6blCmWrxQ aknmPJxgSeoGeENetaONTjRIZuKw8vTTVcUHdoAWm7Ek3OMm540zPn9adecPEU44+u5S 3XDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZXKE731pats/6Y+nrmbdMH4jI8u1hfdG/xfxtgHV+So=; fh=HP0u6UTDta/+GqBM4mahf5Lc0EVr0KtIYijFiIYMcHg=; b=bb91PxCgB8it+NvUdhZaU2Nj58XVp/tD2nnsuPSCC2aj3ZD26OH75Q+PLhhtkcfW4g he9KSO7NIzSWR2puuU+xqT+nALcR0j9XvOw5ktxBdURs7eJdR1n9ApmmOk4CVhVvtpIG 4i6eCkDUtag92t5dDvDb22ihUpK4ioy/5IEvnniqceRRXznAaSKSR5RuFDFahpzqBjcK JWR8hqVYac6qSj3LLolKzrDH7wSxon0uiRLnCWO1fJZ4PTCSaWjEXc0Yobu+oykkHsK2 QRzGGkDbw/ASc8N8IKdmEukIrvL8nkSNt0oyj2IskzyTsltQiwTQK2uSkMIrdxSUUtuT o/+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=hUgoZjLw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id e18-20020a637452000000b0056da0ae25cfsi9210534pgn.196.2023.09.13.02.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 02:33:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=hUgoZjLw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id D132D801C481; Tue, 12 Sep 2023 18:37:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237099AbjIMBhM (ORCPT + 99 others); Tue, 12 Sep 2023 21:37:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230113AbjIMBhL (ORCPT ); Tue, 12 Sep 2023 21:37:11 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CCF9115; Tue, 12 Sep 2023 18:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ZXKE731pats/6Y+nrmbdMH4jI8u1hfdG/xfxtgHV+So=; b=hUgoZjLw/pI//SRToOLypnDSV3 d04glWJH2cdk2oijd0fyYnENFCs0ZLC5GWQOnpFDXM85382StD06T6Nzm9S2wdFxB7jifWsNZiJWm obkUhV3CFqrf7WvpbxqRQTyXlnsc6xllAzEs1Mc93r6Ea9tP1FU8IHiaEDMpBBkteeRY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qgEoM-006Gsi-CU; Wed, 13 Sep 2023 03:36:58 +0200 Date: Wed, 13 Sep 2023 03:36:58 +0200 From: Andrew Lunn To: Parthiban Veerasooran Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, corbet@lwn.net, steen.hegelund@microchip.com, rdunlap@infradead.org, horms@kernel.org, casper.casan@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, horatiu.vultur@microchip.com, Woojung.Huh@microchip.com, Nicolas.Ferre@microchip.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com Subject: Re: [RFC PATCH net-next 1/6] net: ethernet: implement OPEN Alliance control transaction interface Message-ID: <2464017f-c023-45f7-8eee-6541593e6a6c@lunn.ch> References: <20230908142919.14849-1-Parthiban.Veerasooran@microchip.com> <20230908142919.14849-2-Parthiban.Veerasooran@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908142919.14849-2-Parthiban.Veerasooran@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Sep 2023 18:37:14 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email > +int oa_tc6_perform_ctrl(struct oa_tc6 *tc6, u32 addr, u32 val[], u8 len, > + bool wnr, bool ctrl_prot) Please add some kerneldoc headers for the API method exposed here. These are what the MAC driver should be using, so they should be reasonably well documented. Thanks Andrew