Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <e88fe274-cd53-40d4-9a8e-7c6a4e1d8c44@vivo.com>
Date:   Wed, 13 Sep 2023 09:18:55 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v2 1/5] mm, oom: Introduce bpf_oom_evaluate_task
To:     Chuyi Zhou <zhouchuyi@bytedance.com>, hannes@cmpxchg.org,
        mhocko@kernel.org, roman.gushchin@linux.dev, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, muchun.song@linux.dev
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        wuyun.abel@bytedance.com, robin.lu@bytedance.com,
        Michal Hocko <mhocko@suse.com>
References: <20230810081319.65668-1-zhouchuyi@bytedance.com>
 <20230810081319.65668-2-zhouchuyi@bytedance.com>
From:   Bixuan Cui <cuibixuan@vivo.com>
In-Reply-To: <20230810081319.65668-2-zhouchuyi@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG1OWC9pSzFXcGpOa1lYQjh1QWJxb0RReTgzQnhhRGNsZ1ZNRElkTUI3bys3?=
 =?utf-8?B?dVhLTkcrZ01YU2xOeG12OGovMzV4UG91eXJBam1qWFAwcC8yQndJUEtSbWVm?=
 =?utf-8?B?eHQ4YjFoMXFudWZOaXplMmk5OEpmNkFHVjN0QjNWb0RKMjJ1OEJKSng4eFY0?=
 =?utf-8?B?UXl5RVR4VGM4SytBZFVnSEI0T3V6azQwNGE0N3RnTzhTWXI0K0gvbTdaalZ2?=
 =?utf-8?B?U3V4eklFY25xMUp2d3BYOTB5VHBmNjk0U2VJbTlPMHFZcUtRK1JrOUJraWl3?=
 =?utf-8?B?dmxXUUlqTGhDWlJWQUh1YjJiOTMzaHZycmFKUEFlYzVFTkNYdG9WTUhEVW5G?=
 =?utf-8?B?bkk2SEU1V0E2KzloWkZzUzNueVBjU1lDS2s0ZHcrK1hRZW10b1IwclZBa2hP?=
 =?utf-8?B?eEZVcGhTaWkwTkF5V2RPL1hpQ3VpMUtnaWErOVA5NTZSOUNsL1VCb010bWlU?=
 =?utf-8?B?UEVxZGdabHBYM2FsWDZ2UEhLbUhyc2VhR21ESXlEK3lvVXUzSHpkSWN5Sklt?=
 =?utf-8?B?dFRkblh5MFdVbENNWnJ2UERpQ2VjN3VlMHY1SEdLMHFiaDZ2V0k4QTlRU3BJ?=
 =?utf-8?B?UktVeU9CQkNHQ0RZSURkYThQSTZiYjVlek9jMEhYWEcxQVN6cU02SzhLaHly?=
 =?utf-8?B?SWZadjIyT0lGQkpoOU5QNnRONVZjb2VwVTdYL055TGR1K3N3cDEvOTNvQy9s?=
 =?utf-8?B?Wkp4MEtlWEJYYStNUGV4L2NjQmNkcS9CSXFPcUJjUkJxcWg4SXN2dWdSbHpL?=
 =?utf-8?B?REJEdWozOUpzRmxGTVIwSjRpY0ZGNkdSTTFyZDZ0d1dUR2ljMzVEaDd3OEg0?=
 =?utf-8?B?aHZqc2JJTkdmYUlmTlpJR2ZDblhwSkwyK0N4L0VPbHdaMUpYRmpnV2V3SXBm?=
 =?utf-8?B?MlhreU9VeXN0SDNDZWtXa05XNFdYUHFVU1ROZGVvcHhFaHBnRnUrbDYvS01P?=
 =?utf-8?B?bzBtOUpyZjA4THB2VFBra3IwTmp5eWNoSnFaQVFCbTd4bERLRVduaElQMmpK?=
 =?utf-8?B?NGs1alRIcGVxazVWdHhRZDBlV0dqK0xtY3JDMXk1NmRnZHlOZXpBUXhEYS9D?=
 =?utf-8?B?Y1AwNGFqZUxDZ0lFd3dBa2ljM3h3NTVEaC85QVBUeFIwd1pqSlFEam5qS0R6?=
 =?utf-8?B?T2Nlc2l3ak1rWWZBSkVqZGhSZXFKSmZnQ1FJTU82c1pJUi9TVW43RVFXdkM3?=
 =?utf-8?B?cUx1ZExHVGJtNE9oNDkzdXlkU1RCUHRYOWVGV0pzU0hXalJMeElTY0lCdk9N?=
 =?utf-8?B?N21xcmZyMHlHUUt5dnlFTUU5NThwTmlxcTNGNytnbnhXM2ZNUksyalhuNlZN?=
 =?utf-8?B?a3lNdExzdGk2Rkp5TUlRelhPRGJnQ3B2cU95clVPVWlOQTNXSkEzanFkb2ZU?=
 =?utf-8?B?QUVoRWpBbVpIYW8vNGtXZWZRTThxN3dqNnBMSmJ2UVdFQmVzcUJGVkhmWkNu?=
 =?utf-8?B?bldET3BwckdaWFlWdDlONkZzdDdIUEoybnd3OGJzc2RCTDM3SjYyZmVpQm1n?=
 =?utf-8?B?czBKYnJwRmoxSGQwNDV6Slhlak8xZERMeEtNUmN6RVIwTm05TnJzUmVTMjNu?=
 =?utf-8?B?V0F0dngxOVZ4ZzVWNURTSTZZbjNyRWl4ampaZ01NanRsRFhnZzZQeVR5cXdy?=
 =?utf-8?B?NTBQMnF5YnM1bGFFUTE2cWhNN2NmUjhacDNVVW1WZ0pjSit3OTZqRjdIYTM5?=
 =?utf-8?B?VlVrNzIvZXlNSnpDZlRFZjhWdE1vMVVaVGFMS21NUXo0OTlLeTdibHRnWjBO?=
 =?utf-8?B?NXRiM2x4aEt1NXlVOVZudmtjSFVvV0ZWRFdCS2tCemFsRzNPSmlXdHVQdnJG?=
 =?utf-8?B?RFVZcy9zcmxsV0hVWmJ6Vyt2aUVPc2F0dVB6dnIzK29weGlzVmVPbWZpclcx?=
 =?utf-8?B?Z3dsWmlKanJkZGdBZE8wUHNpQnF0ck5LUS82STZ2TnJVZUNmS1VGQVh2eG9z?=
 =?utf-8?B?Z2JsWkpHdnhUMTVIZDhTMHBIVFdTWTBXc2tZUU9PWkNwSVV2SFlrOE53cGJs?=
 =?utf-8?B?SWJGQm9vUytHUjk1cWpFV0tGRVVNWEgwa0lLYlV2RzQrQXpHVDI4cTlxQk0r?=
 =?utf-8?B?T0hIRy8vT1BIVXpNVFNLQ1duUk1OZkszOGc1K0orcmRFRU5OT3U2WWQ1VG5I?=
 =?utf-8?Q?Dqq9JWXtOm2fCzyOdSM4MWtfW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2a8ac6c-afbc-4917-c946-08dbb3f76b27
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4045.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 01:19:04.2050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BLq+ifzBwvBGromgJuW4JOJMz/ksa1RV9qAotaGtlENXxqDk0DwV/+mVS3pIDdXXKNcnofAVXYsjb7IHhXnzfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5772
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Sep 2023 18:19:18 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email


在 2023/8/10 16:13, Chuyi Zhou 写道:
> +#include <linux/bpf.h> #include <linux/oom.h> #include <linux/mm.h> 
> #include <linux/err.h> @@ -305,6 +306,27 @@ static enum oom_constraint 
> constrained_alloc(struct oom_control *oc) return CONSTRAINT_NONE; } 
> +enum { + NO_BPF_POLICY, + BPF_EVAL_ABORT, + BPF_EVAL_NEXT, + 
> BPF_EVAL_SELECT, +}; +

I saw that tools/testing/selftests/bpf/progs/oom_policy.c is also using 
NO_BPF_POLICY etc. I think
+enum {
+	NO_BPF_POLICY,
+	BPF_EVAL_ABORT,
+	BPF_EVAL_NEXT,
+	BPF_EVAL_SELECT,
+};
+
definitions can be placed in include/linux/oom.h

Thanks
Bixuan Cui