Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3152936rdb; Wed, 13 Sep 2023 03:57:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOXeppqnmj8AAs8lDhg+lN2i1XgAHBV03c1VogiZ3lOeCUTApzmT8q3lhsPeACJXns88Uo X-Received: by 2002:a17:90a:a795:b0:26f:ac36:623a with SMTP id f21-20020a17090aa79500b0026fac36623amr7249360pjq.3.1694602642257; Wed, 13 Sep 2023 03:57:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694602642; cv=none; d=google.com; s=arc-20160816; b=lFuQLNqhxBT6TBx06hbSSk9VpaNrdOEyscJNHx6n5UqseRvAR0VrvkmZAgljq9j/+n n6IxfroBKlLAMqac38AoQN5Cmok922A031Z1ZkFjf8m9SzggO51rCbgjqxyMNdt+GST0 y6ZEO5gItZ63+CLjZum800xzLz6ZkfFZ6roermktdFAlOzzM4wtCEKOWIOiqX4VM9nEZ YHe7xAiKK657cwpiJ8waUYSPB7MCGsLAZWELaZ79xNTmSBGAteP4DBF33WsL5njRnOqm OeFhgucOT6PKw1bEQmDTO/MZcUexGh398Ni7QebUMT5SBffuFDuTwv5dLJz+FFWjLFL3 txPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=5EvO6BvW4vFJSulaWYmxv0I61u0FCBSMFFe8opEqnM4=; fh=JfAApAzKb23jpl4b3p6jje4rQoAbyQMzTteo/1sEDwY=; b=yhTKewmYnSV54PLi1sEur2cckEV1wf45tQhQi1OD3Usb5Z6ceimvCBr8ilO3qV0JGR ci0o/W3oelnE5kzvcAJM1KRwNxL92kRlnmL8ZN3WO21r+2Atiz18iLPebIC2eJQ99+s5 1AhZ95DHb+Inw+HibkdPX9qFwpsexbMjdirG8y4ASBbHTxArp7U/pK0RSzTO08iaGM1F a7AjKEfqpJhEgr9RI/hdSU6lx+x2SXsNimH4HFQd+jX+kn+ok8l9BzhWMbpmtn13nWUF GwOMI164zM8yc68VMBJ2V0uc+EOQG9EVWUlfG9q5V+J6FdNZSu4Mf54MYlVRtDGWSYCe ZV4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id s10-20020a17090ad48a00b00273fce213f3si1267799pju.132.2023.09.13.03.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 03:57:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 6581580B9930; Wed, 13 Sep 2023 03:52:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239781AbjIMKwz (ORCPT + 99 others); Wed, 13 Sep 2023 06:52:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239771AbjIMKwy (ORCPT ); Wed, 13 Sep 2023 06:52:54 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D861F19AD; Wed, 13 Sep 2023 03:52:49 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D25C51FB; Wed, 13 Sep 2023 03:53:26 -0700 (PDT) Received: from bogus (unknown [10.57.93.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A941C3F5A1; Wed, 13 Sep 2023 03:52:47 -0700 (PDT) Date: Wed, 13 Sep 2023 11:51:48 +0100 From: Sudeep Holla To: Will Deacon Cc: Oza Pawandeep , catalin.marinas@arm.com, Sudeep Holla , rafael@kernel.org, lenb@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v5] cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer Message-ID: <20230913105148.xntz3qeascibvuxx@bogus> References: <20230912172933.3561144-1-quic_poza@quicinc.com> <20230913083908.dfanwizomj5i536k@bogus> <20230913102721.GB12021@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230913102721.GB12021@willie-the-truck> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Sep 2023 03:52:57 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email On Wed, Sep 13, 2023 at 11:27:21AM +0100, Will Deacon wrote: > On Wed, Sep 13, 2023 at 09:43:01AM +0100, Sudeep Holla wrote: > > On Tue, Sep 12, 2023 at 10:29:33AM -0700, Oza Pawandeep wrote: > > > Arm� Functional Fixed Hardware Specification defines LPI states, > > > which provide an architectural context loss flags field that can > > > be used to describe the context that might be lost when an LPI > > > state is entered. > > > > > > - Core context Lost > > > - General purpose registers. > > > - Floating point and SIMD registers. > > > - System registers, include the System register based > > > - generic timer for the core. > > > - Debug register in the core power domain. > > > - PMU registers in the core power domain. > > > - Trace register in the core power domain. > > > - Trace context loss > > > - GICR > > > - GICD > > > > > > Qualcomm's custom CPUs preserves the architectural state, > > > including keeping the power domain for local timers active. > > > when core is power gated, the local timers are sufficient to > > > wake the core up without needing broadcast timer. > > > > > > The patch fixes the evaluation of cpuidle arch_flags, and moves only to > > > broadcast timer if core context lost is defined in ACPI LPI. > > > > > > Reviewed-by: Sudeep Holla > > > > IIRC, Rafael had acked this, perhaps missing the tag ? > > Also just add a note to Will/Catalin that Rafael has acked and prefer to > > take it via arm64 tree. > > Is this a fix? If so, please can I have a "Fixes:" tag (and does it need to > go into stable?) > Well, most platform today have CPUIDLE_CORE_CTXT set so the existing code works as expected. It is this Qcom platform that doesn't set it and need different behaviour. So based on their requirement for running stable tree, the fixes tag can be added. In short yes it can be seen as a fix if this new requirement is considered. Sorry the main reason for trying to avoid is there are multiple patches adding the initial support and there has been some code restructuring around this. So it may need proper backporting based on the version. I just want to avoid if there is no real requirement for that. -- Regards, Sudeep