Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Wed, 13 Sep 2023 12:21:46 +0200
Message-ID: <87cyym4blx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc:     tiwai@suse.com, perex@perex.cz, arnd@arndb.de,
        masahiroy@kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, maciej.szmigiero@oracle.com
Subject: Re: [PATCH] ALSA: usb-audio: mixer: Remove temporary string use in parse_clock_source_unit
In-Reply-To: <20230913093933.24564-1-peter.ujfalusi@linux.intel.com>
References: <20230913093933.24564-1-peter.ujfalusi@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-7
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 13 Sep 2023 11:39:33 +0200,
Peter Ujfalusi wrote:
> 
> The kctl->id.name can be directly passed to snd_usb_copy_string_desc() and
> if the string has been fetched the suffix can be appended with the
> append_ctl_name() call.
> The temporary name string becomes redundant and can be removed.
> 
> This change will also fixes the following compiler warning/error (W=1):
> 
> sound/usb/mixer.c: In function ?parse_audio_unit?:
> sound/usb/mixer.c:1972:29: error: ? Validity? directive output may be truncated writing 9 bytes into a region of size between 1 and 44 [-Werror=format-truncation=]
>  1972 |                          "%s Validity", name);
>       |                             ^~~~~~~~~
> In function ?parse_clock_source_unit?,
>     inlined from ?parse_audio_unit? at sound/usb/mixer.c:2892:10:
> sound/usb/mixer.c:1971:17: note: ?snprintf? output between 10 and 53 bytes into a destination of size 44
>  1971 |                 snprintf(kctl->id.name, sizeof(kctl->id.name),
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1972 |                          "%s Validity", name);
>       |                          ~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> The warnings got brought to light by a recent patch upstream:
> commit 6d4ab2e97dcf ("extrawarn: enable format and stringop overflow warnings in W=1")
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Thanks, applied now.


Takashi