Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Wed, 13 Sep 2023 07:59:04 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Reinette Chatre <reinette.chatre@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH RESEND v3 1/2] selftests/resctrl: Fix schemata write
 error check
Message-ID: <jyxp5mspjn7xbmclj5sumbsuwd424fqmdvntiiuq24tiz5yqb4@qunho7whbamf>
References: <cover.1693575451.git.maciej.wieczor-retman@intel.com>
 <960b5302cee8e5bb0e83dcf20cd2ef4d353b7b0b.1693575451.git.maciej.wieczor-retman@intel.com>
 <99eabc5c-f5e3-27dd-0a29-ad0cdb7b4239@intel.com>
 <sr6ana6d7ebtuxbhjuo6kcnhnn2zzvg3ivve6mndqeb3nxrzo7@mrfmtzlxlwdh>
 <a7f0dfb9-c841-b240-fca9-b908517a44d0@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a7f0dfb9-c841-b240-fca9-b908517a44d0@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnZNK1RSTXp4RGVLNldlSnltQ25kYnpESmk0VzFwQm4wYUF3aEdtS3I2RDJi?=
 =?utf-8?B?QmpVcTFIRytKd3hHM2x6YXhJV0YvRU1PdHRobGtQdlZNcVdUakw4RnAzT3Uv?=
 =?utf-8?B?anRoRmVvNzlDNlVTSVg2WVZiVXRLeWRsd0x2VVphTUl5WEVOUG9tT1Z6SUNp?=
 =?utf-8?B?R2s0N3Z1ZHZlRStaaHl5aUs0Y0t6ZGg5TmFCUHpTYStlUzFEVDFxaUxmWGh1?=
 =?utf-8?B?NnB3a1IxNFZrUVZJVVR2Vktma2EyS21DSlhQL1Q1eGlRVkorRXRIWjlpM1Jm?=
 =?utf-8?B?Z1FocFMyNnRFNHBFK3FRa2VOai94ZWtlVkJPS0VJbmh6eTBHaDZqR05WUFI0?=
 =?utf-8?B?bUpSQXdFRXo1ODJVbTVBNGVRR0t2d2crWkZIQWQxRlVzbnBGOHpnNnZOSytG?=
 =?utf-8?B?akVmZDdhZjJ3cG04bWlFVnFTZDJJQnh1NEJjS2tUZnRaQ21JaUlScmwvcXNN?=
 =?utf-8?B?b2hBU05zWVdWOUROZFo5c1RpL1BDSWxvOTZFSksvbzRsMjVSb1JXRmcvV1Bq?=
 =?utf-8?B?U3BTR3A3UGZ0OFlkamd4VFZQcDRNa3V3aGY1bUhweVpwK25kajRCaGkrcExK?=
 =?utf-8?B?bkppN0ZZWXIxQXRhb1NhMHBHQ1Rrbm1lMDM3YVR1TktVaXQ3TjdzckY2N2FM?=
 =?utf-8?B?Z01LN1M2Rm9BdW80Qno2YmRUZWcyb2hCSHpkcGg4SEdVQnhGVlduQm4xUDlX?=
 =?utf-8?B?c2ViWTdYNHZUeVlVQncrV1VLWjlxajJ3UVpzM0FZWGQ2V25wMlFEcno5TkZo?=
 =?utf-8?B?ZUFvbkFHTE51OGVzci9jVEM5YTBDZk54TTFHS3dOQTM1SXBEek9RNG5UNi9F?=
 =?utf-8?B?dWNyZ3M4ZngzNm9FQktjbmMzcHQ1ZTdjUnFRRmR2UTc2eTlrSmNZYnFlZko5?=
 =?utf-8?B?TWF2cVNVZDBNOEFoN2d6Q1RLcGswdExUSUdsK1dZZmRucDY0dDRxV1R2Wjh3?=
 =?utf-8?B?UlVycURYRDA2M1dDOGxOU3RNNmFnNFg3VS9scm90NElpR2dVcXhJejEzZFNo?=
 =?utf-8?B?Q1lCR2t4SFBiVDJUNEtocWdvMVVMTTZGMFdkYlpGelB1MjFqZUdDT3oxZXpx?=
 =?utf-8?B?OWVGMGZ0ekZXZlZER3hBM293M05LM2JMN3FWU052RE5xY2xDcDUwK2lvQk9L?=
 =?utf-8?B?aG1kaUlwMCtTZmhUWkNTUVcvQWw3QjI3SGMwNldOVmo1RmpoeG1vSlhpSmh6?=
 =?utf-8?B?V29rOVNHV2tZcEVuVEhZdGdXckNxYXNobXJZN2NSZmZSeE96MzdEKzlvOFZy?=
 =?utf-8?B?MXBodmZnNzFDQUh3SkdWR0lYa3N0dDlEY0RKT3lSODdwdDBwelZNSjNQVm0v?=
 =?utf-8?B?RTcxWlJOZDVaaHVrOW1DbktzVmFWbmE1amVhWHNIU3k5UHdhNTEyQ2FFbE9v?=
 =?utf-8?B?QS9EWS9FM1ZYR0hIUWg2Y0JQcGVNZjRWcnE1M0tZbi9OOCtZT0M5YWpYc2JC?=
 =?utf-8?B?RGM4U1pNZW45M3UrQmZSZCtOeG1UVnA1bnNCbTRBZ1RjWWVqemlIMlEwOVla?=
 =?utf-8?B?a1BFSHlOTHVlTXpmZmpaWWpmdFYrQzVxV2p0UlFpc01uL3MzQjhvMVl3czJu?=
 =?utf-8?B?QVA5b1I4bGNubkR1aTJ1TTByMnFONzI4TVJOVC9VL0IzQzdDWjRVVHQxa0tD?=
 =?utf-8?B?dG1vb3NvTm53Y3NsdWh4L0YrMnlwSTFNcENEYmlFUnAvOHFuNGZLQ3hOTTI3?=
 =?utf-8?B?clpPMkdiZHNMd0FWM3R4eXlqVUFRK2xZa2MyRFlmTUZrQkE3bmQvSkgwc2J1?=
 =?utf-8?B?eFdxeFVOR0tyTVNJS0NWaHZ3OWxTdFp4UmlINldMSGl5VmhjVzlYaXR0RCtl?=
 =?utf-8?B?bU9uVFNkZHZMV0xqcFlyQk84ekhIdXFEZ1RQV1h5WnBEWnpuMmd0RGR3T216?=
 =?utf-8?B?OE9XMGg0elZVS0hKZkZHUjN6WnhOdThPaXZzemZCY2w3dHpDYkM0dmlDUjNz?=
 =?utf-8?B?bVFCZnlGZ0MxcnBDN015R2x3aFN2ZnlIajZkWFpidyt5VDluWEJ6aW9melN6?=
 =?utf-8?B?Wm56c3M2TUduamxRVzR3YUhPS3lyMVgwOVAxeGJLNEdmQkFHbGRTclRGcTZS?=
 =?utf-8?B?VGk4N1F5Nno0K0JabkhlWGYyWStzVHZhbGFDcTJsODdKNEh5U2ZORlNEWnIw?=
 =?utf-8?B?WndRVzR0OXg5QVZlU29jbUQwcmlRbnhSVW13dDVtMG5DYVJ0THp4cUdYcWVG?=
 =?utf-8?Q?tazPb6vs7Oa6Zws2HAmCjj4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a0fddcea-dc62-423e-bd17-08dbb41e8cd3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 05:59:10.9558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o/vTWtak+E+xvo8MUEHggATR4PFfOgcQ2xIlnBheo5j07zYla2d5itRIFUaIBqddD/vzQNL3pMeOkyINYtqLVrSXHrrE8Tmjl0Wo6mjCgvs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5491
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 22:59:24 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

On 2023-09-12 at 09:00:28 -0700, Reinette Chatre wrote:
>Hi Maciej,
>
>On 9/11/2023 11:32 PM, Maciej Wieczór-Retman wrote:
>> On 2023-09-11 at 09:59:06 -0700, Reinette Chatre wrote:
>>> Hi Maciej,
>>> When I build the tests with this applied I encounter the following:
>>>
>>> resctrlfs.c: In function ‘write_schemata’:
>>> resctrlfs.c:475:14: warning: implicit declaration of function ‘open’; did you mean ‘popen’? [-Wimplicit-function-declaration]
>>>  475 |         fd = open(controlgroup, O_WRONLY);
>>>      |              ^~~~
>>>      |              popen
>>> resctrlfs.c:475:33: error: ‘O_WRONLY’ undeclared (first use in this function)
>>>  475 |         fd = open(controlgroup, O_WRONLY);
>>>      |                                 ^~~~~~~~
>>> resctrlfs.c:475:33: note: each undeclared identifier is reported only once for each function it appears in
>> 
>> Hmm, that's odd. How do you build the tests?
>
>I applied this series on top of kselftest repo's "next" branch.
>
>I use a separate build directory and first ran "make headers". After that,
>$ make O=<build dir> -C tools/testing/selftests/resctrl

I do the same, just without the build directory, but that shouldn't
matter here I guess.

>> I use "make -C tools/testing/selftests/resctrl" while in the root kernel
>> source directory. I tried to get the same error you experienced by
>> compiling some dummy test program with "open" and "O_WRONLY". From the
>> experiment I found that the "resctrl.h" header provides the declarations
>> that are causing your errors.
>
>From what I can tell resctrl.h does not include fcntl.h that provides
>what is needed.

I found out you can run "gcc -M <file>" and it will recursively tell you
what headers are including other headers.

Using this I found that "resctrl.h" includes <sys/mount.h> which in turn
includes <fcntl.h> out of /usr/include/sys directory. Is that also the
case on your system?

-- 
Kind regards
Maciej Wieczór-Retman