Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Feedback-ID: i36794607:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-745-g95dd7bea33-fm-20230905.001-g95dd7bea
Mime-Version: 1.0
Message-Id: <51a9af18-a5e4-4cb1-9f95-491bf73d35f1@app.fastmail.com>
In-Reply-To: <20230913112032.90618-6-abbotti@mev.co.uk>
References: <20230913112032.90618-1-abbotti@mev.co.uk>
 <20230913112032.90618-6-abbotti@mev.co.uk>
Date:   Wed, 13 Sep 2023 14:03:55 +0200
From:   "Arnd Bergmann" <arnd@kernel.org>
To:     "Ian Abbott" <abbotti@mev.co.uk>, linux-kernel@vger.kernel.org
Cc:     "Niklas Schnelle" <schnelle@linux.ibm.com>
Subject: Re: [PATCH 05/13] comedi: 8255_pci: Conditionally remove devices that use port
 I/O
Content-Type: text/plain
Precedence: bulk

On Wed, Sep 13, 2023, at 13:20, Ian Abbott wrote:
> In a future patch, the port I/O functions (`inb()`, `outb()`, and
> friends will only be declared in the `HAS_IOPORT` configuration option
> is enabled.
>
> The 8255_pci module supports PCI digital I/O devices from various
> manufacturers that consist of one or more 8255 Programmable Peripheral
> Interface chips (or equivalent hardware) to provide their digital I/O
> ports.  Some of the devices use port I/O and some only use memory-mapped
> I/O.
>
> Conditionally compile in support for the devices that need port I/O if
> and only if the `CONFIG_HAS_PORTIO` macro is defined.  Change
> `pci_8255_auto_attach()` to return an error if the device actually
> requires port I/O (based on the PCI BAR resource flags) but the
> `HAS_IOPORT` configuration is not enabled.
>
> Cc: Arnd Bergmann <arnd@kernel.org>
> Cc: Niklas Schnelle <schnelle@linux.ibm.com>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
>  drivers/comedi/drivers/8255_pci.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/comedi/drivers/8255_pci.c 
> b/drivers/comedi/drivers/8255_pci.c
> index 0fec048e3a53..4c4c0ef1db05 100644
> --- a/drivers/comedi/drivers/8255_pci.c
> +++ b/drivers/comedi/drivers/8255_pci.c
> @@ -57,6 +57,7 @@
>  #include <linux/comedi/comedi_8255.h>
> 
>  enum pci_8255_boardid {
> +#ifdef CONFIG_HAS_PORTIO

I think this is a typo: HAS_IOPORT vs HAS_PORTIO?

     Arnd