Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3213115rdb; Wed, 13 Sep 2023 05:48:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElkgoYMpVaXmiGc5dKFH/Ta9IT0hABs3Htt46+I02QSaoqpoiv4nSj25FKLikQhbn0wzoh X-Received: by 2002:a17:90a:9c0f:b0:26b:374f:97c2 with SMTP id h15-20020a17090a9c0f00b0026b374f97c2mr3816750pjp.6.1694609326817; Wed, 13 Sep 2023 05:48:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694609326; cv=none; d=google.com; s=arc-20160816; b=BujsB/ivMX4r3yB3nxyAVm4b/G82rSoW9JxIfruxu/qaVZ1qZugk8NajQlc2EVOg11 +eiJxlLVIzTHSKBE1RAxPEr/UOU8mjijcG1jncmGoZvNxcI6foMid+1MoCzKsPul/vMp sILD8tg/9PixGG/rUmFLkvCHBa3jM+a/SnGLX+5AmQ3fOmtq8Ecb1KeTbU3/37McJZZn vaeARckw6hFCKpyst/nn77BBwcDhvTlUZj9WouY63BsuuQQIajHnfGXcxR5XxQ41E8hM 7KNuZFJjT5DuYMr3UgagDnRfTJ7IewjyUCm7osJH0c5AurQJtmiKllyo4/zObIlGmQb9 +QUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=47VC1yn9WJ7Nh+GGQ+9Mqxm5rnZYsKhcTYBLi0YS1I8=; fh=f4KQnOf4DL3FZ4rINpxCCB681RH9plJXTbAzdkN1cKE=; b=l9aCKGTJ2Y69ND24m3w9hHIOR0pN5NFYRFS/rwAF3MM79ZUsX6M5+n79E6KRoBbFGt 4/xtMrNzivVn4/6VoPohY5sS+kfAeqNtOqRl61Se5uAZ2SoeAX6FWIZGIfxEN83m7Gs2 SBiCjjvKsoC9uIDXBViDr9erFA2OgMIuYxuKX7Fr0eTWZmzb5N+7X7WNiI2YNqhpJuZR FE7tukObgxbEJNt3vzomTIh1AQqyRCFi3s2smhIOcV/E4teMysA3WiKNPXBEffpXK469 hyo04t9MJRRabkEDznDqdbLAuUIAheQj37Xm0swJml6FCAFLfLfInk+9bjqDrHh1jK+c +YRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Z3zpmKhL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id w91-20020a17090a6be400b00273fa934cc1si1486826pjj.167.2023.09.13.05.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 05:48:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Z3zpmKhL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 549AF8174A52; Wed, 13 Sep 2023 01:48:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237278AbjIMIsB (ORCPT + 99 others); Wed, 13 Sep 2023 04:48:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239059AbjIMIsA (ORCPT ); Wed, 13 Sep 2023 04:48:00 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F6FB198E; Wed, 13 Sep 2023 01:47:57 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38D6rjLM011651; Wed, 13 Sep 2023 08:47:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id; s=qcppdkim1; bh=47VC1yn9WJ7Nh+GGQ+9Mqxm5rnZYsKhcTYBLi0YS1I8=; b=Z3zpmKhLMWC9C5Syb+n2oZRW6FS/IAvqqPkvkLXYFy8ZEdfG8xzBgoLynxp5wxhfzs9f NGjjwUZGZbTKDpNKbwFh3wJPpOHGLHINHGl+bs0Q4EQEgIa0mB+YsPLrR6cv794NbnQF w8KVg8NDRK4hZBDiSHh9o7UUW8GkJ8AniT33CftmA/YYKHIYUuLmXSdk1nCPR2tRInBC PQuoPzjVnp9gAmWFZx5jEPjE7zGhFMvTiIQ6C9vVINpeNuv6zrzfE+P9Qet7OPSNoZ0H 5q176MEwms24fm7f5EbrC8sqsJ5NukdhCdb4HoI3K2vh2f0jtJDRZL2WoTwaX8DEUNe9 6A== Received: from aptaippmta01.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com [103.229.16.4]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t2ygr96ax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 08:47:47 +0000 Received: from pps.filterd (APTAIPPMTA01.qualcomm.com [127.0.0.1]) by APTAIPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 38D8lic0016827; Wed, 13 Sep 2023 08:47:45 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APTAIPPMTA01.qualcomm.com (PPS) with ESMTP id 3t0hskj2ae-1; Wed, 13 Sep 2023 08:47:44 +0000 Received: from APTAIPPMTA01.qualcomm.com (APTAIPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 38D8liU6016821; Wed, 13 Sep 2023 08:47:44 GMT Received: from cbsp-sh-gv.qualcomm.com (CBSP-SH-gv.ap.qualcomm.com [10.231.249.68]) by APTAIPPMTA01.qualcomm.com (PPS) with ESMTP id 38D8lixH016819; Wed, 13 Sep 2023 08:47:44 +0000 Received: by cbsp-sh-gv.qualcomm.com (Postfix, from userid 4098150) id 827114DB3; Wed, 13 Sep 2023 16:47:43 +0800 (CST) From: Qiang Yu To: mani@kernel.org, quic_jhugo@quicinc.com Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_mrana@quicinc.com, Qiang Yu Subject: [PATCH v2 0/2] Add lock to avoid race when ringing channel DB Date: Wed, 13 Sep 2023 16:47:39 +0800 Message-Id: <1694594861-12691-1-git-send-email-quic_qianyu@quicinc.com> X-Mailer: git-send-email 2.7.4 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: adE5b9uR7A5r6W-Tp5JB9j3TYXZOd4f2 X-Proofpoint-ORIG-GUID: adE5b9uR7A5r6W-Tp5JB9j3TYXZOd4f2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-13_02,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 impostorscore=0 bulkscore=0 phishscore=0 mlxscore=0 adultscore=0 mlxlogscore=536 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309130070 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 01:48:13 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email 1. We need a write lock in mhi_gen_tre otherwise there is race of the WP used for ringing channel DB between mhi_queue and M0 transition. 2. We can not invoke local_bh_enable() when irqs are disabled, so move read_lock_irqsave() under the mhi_gen_tre() since we add write_lock_bh() in mhi_gen_tre(). v1 -> v2: Added write_unlock_bh(&mhi_chan->lock) in mhi_gen_tre() before return because of error process. Bhaumik Bhatt (1): bus: mhi: host: Add spinlock to protect WP access when queueing TREs Hemant Kumar (1): bus: mhi: host: Take irqsave lock after TRE is generated drivers/bus/mhi/host/main.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) -- 2.7.4