Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20220615090517.3961621-1-windhl@126.com>
In-Reply-To: <20220615090517.3961621-1-windhl@126.com>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 13 Sep 2023 08:01:15 -0500
Message-ID: <CAL_Jsq+609wEjMLsiLAMjSfAcMc-ashF9+f0rhbZRhM2FVPhmA@mail.gmail.com>
Subject: Re: [PATCH] arch: arm: mach-versatile: Add missing of_node_put in integrator.c
To:     heliang <windhl@126.com>
Cc:     linus.walleij@linaro.org, linux@armlinux.org.uk,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 15, 2022 at 4:06=E2=80=AFAM heliang <windhl@126.com> wrote:
>
> In cm_init(), of_find_matching_node() will return a node pointer with
> refcount incremented. We should use of_node_put() when the pointer is
> not used anymore.
>
> Signed-off-by: heliang <windhl@126.com>
> ---
>  arch/arm/mach-versatile/integrator.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-versatile/integrator.c b/arch/arm/mach-versati=
le/integrator.c
> index fdf9c4db08a7..fba19357171a 100644
> --- a/arch/arm/mach-versatile/integrator.c
> +++ b/arch/arm/mach-versatile/integrator.c
> @@ -76,6 +76,7 @@ void cm_init(void)
>                 return;
>         }
>         cm_base =3D of_iomap(cm, 0);
> +       of_node_put(cm);

Not really sure this is right. It is in the sense that the DT node is
never accessed again. However, the device itself is still accessed and
I tend to think a ref to the DT node should be held for that lifetime
which in this case is forever. Really, none of this matters because
nodes are never removed and these fixes are kind of pointless.

Note that cm_get() and cm_control() are never used and can be removed.
That would be the more useful clean-up.

Rob