Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 12 Sep 2023 09:25:45 +0800
From:   Oliver Sang <oliver.sang@intel.com>
To:     Chuck Lever III <chuck.lever@oracle.com>
CC:     "oe-lkp@lists.linux.dev" <oe-lkp@lists.linux.dev>,
        kernel test robot <lkp@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        linux-mm <linux-mm@kvack.org>,
        "ying.huang@intel.com" <ying.huang@intel.com>,
        "feng.tang@intel.com" <feng.tang@intel.com>,
        "fengwei.yin@intel.com" <fengwei.yin@intel.com>,
        <oliver.sang@intel.com>
Subject: Re: [linus:master] [shmem]  a2e459555c:  aim9.disk_src.ops_per_sec
 -19.0% regression
Message-ID: <ZP++GV9WURg1GhoY@xsang-OptiPlex-9020>
References: <202309081306.3ecb3734-oliver.sang@intel.com>
 <C85F44FD-BC7D-421B-9585-C5FDFAEA9400@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <C85F44FD-BC7D-421B-9585-C5FDFAEA9400@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XoJp87eGUF5AVDMNfL3HVLgCEj0/Xcg2YiGGHZvORe3EJ9BpdTQ7U395DMHR?=
 =?us-ascii?Q?K1Wfv3U0ONSlnaGDizS7V0imryd2ov3tFH6JoNNs+bSy/KMBl/tvHFO3DXuo?=
 =?us-ascii?Q?sUmW7ONYdBqO+gcyBE7KwhonIE3vjk5Rf3T9XNsAqzX5PJV0aV6htcs9XVc6?=
 =?us-ascii?Q?Vb/pn8X5nwUiqUJ5arIoEibyVRuoCoK7WsvTx5F4jqW1PJhirF9o/vsH5u+F?=
 =?us-ascii?Q?sGZsBL6YEImm22QOY40vPu2kdN5YhFqTAHSZtpT2rw3BbUA3rCBKgqcG5cCj?=
 =?us-ascii?Q?rXxMvEv9IgUJJbw4bJLF5gOSYV8QCYLThhdL3fFQdLFO5hYxadK+R/DvCJHc?=
 =?us-ascii?Q?1J4yhFiy2xINXpxo6vLc2oE7JyyZUC0SXAVs4vFIJOVWhMnjNKLmQepHF26e?=
 =?us-ascii?Q?eToFQS38qapowyQ7Y2fWfmvGzBvgM994abhDbInhpdp2LrsJcv4QrgADzwYC?=
 =?us-ascii?Q?3bPvo7fRKULDnA13syo/54BZmiAQbT/vMkrsYfm6UUlIeqlecYLT51Y6vyTz?=
 =?us-ascii?Q?N+TyS4F+pvG1s2moy/Kv0WIM5wokQDvTJqOQtTQ8LZdlYUJY07qna56VlFZe?=
 =?us-ascii?Q?JsUtAbs+SQBknhcEIMY5qQmtz/+Dnwz98A/9XwvpjdguIHKq9jgo1rwwXMDX?=
 =?us-ascii?Q?GjfObBdDWsQ8Rm1cE+wuOrOwQDuAlIQIhtj1S1fqg+FI5nrQXqxs5k2rT7IU?=
 =?us-ascii?Q?TydBGL8yNcHdt6XbByo1bqCauoUUZJ1g6FgtBO6P4NxfqGMuEaOoMEQK2Uqu?=
 =?us-ascii?Q?tXDK9EmcL+CJQJb+ZFLZ5GyK9ci/n9cwbFm3yUyVhSKAAftKZaYMuoGjwSQa?=
 =?us-ascii?Q?Oo6JMxBWD+rLB0yiqCWRYhHUwB4YcPKoMacfMlm44VrN9rLdzjmbfaKJgn2V?=
 =?us-ascii?Q?IllrnSw0mTZfotpRPjBzJvJ8LRo0AtA1ZwP2cLW3pKZ+wKqzXxf123FMe0Vo?=
 =?us-ascii?Q?oj83qbtczkmgPQ7UyP/oofTLdy7zfTzAqLyWgxjeEk4dm60SnJAJd5uv5XxJ?=
 =?us-ascii?Q?G1H+caYE0phv4p03PU5MiH+y1p2wkwvMIsFAjzfEgT+KU7I/mvvzV0gFzKHt?=
 =?us-ascii?Q?5N89UQLfxa+3j0KjtHbr/w5sYquSqlQXdLpTChsAIeaEzmUPcq+BSFeqeYDO?=
 =?us-ascii?Q?NP5nFTzsgQmvsysMe6C0hmqFHrQSw62BRc6Lw37TQBE7eZi29lzxJuzMVnM8?=
 =?us-ascii?Q?laKLqQ5TMpdXaNEt/bIWRxV0SwJe5tV4kfddId2lzfnLDMo/I+4jCfxTi2Ok?=
 =?us-ascii?Q?c2UfsD74uQiav3Z7e+ORE7m51aSsjTnjCIHVyOjex9HoZqV/k77uACh+e4y0?=
 =?us-ascii?Q?MrX0/b05m504C0djXmPFmdwB/FeJATbYUaJrwjtk8b10R3zlcb6Cz6KaOm34?=
 =?us-ascii?Q?m3FJJsn3t1tCKjUDs0lr0Gx5c6qtI+9uk9QxTrrOBgKW43af9w9Dokawscuu?=
 =?us-ascii?Q?KtPPeXOzwCXdK15csbZXTsnbgI1nJx9Qy3K/KIklT+GeaR/0j3Cx2wsZjO0B?=
 =?us-ascii?Q?Vu4cw0LJd1xcIg7rZjDtbwRr7VM3ASODfk75TNG39ECUCjphN9w+3mroRq/R?=
 =?us-ascii?Q?8A+DZd6GzTnFQmb9BfMAeynpDPbpxuYPRRiWj7Jpcs1+6D+HTr7Vamaugkit?=
 =?us-ascii?Q?sw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f3e9c78-e6ec-4d33-8ae0-08dbb32f3675
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6779.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 01:25:56.2726
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KlkQ1OEpexpAsmaNc2e+EZFnj9ZlbQAn2z0nzs/k5Yn0rzhvX29yjrBfhzSllWrx0lwZvDhrnRsRZ2+dsyQJxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6531
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:14:12 -0700 (PDT)

hi, Chuck Lever,

On Fri, Sep 08, 2023 at 02:43:22PM +0000, Chuck Lever III wrote:
> 
> 
> > On Sep 8, 2023, at 1:26 AM, kernel test robot <oliver.sang@intel.com> wrote:
> > 
> > 
> > 
> > Hello,
> > 
> > kernel test robot noticed a -19.0% regression of aim9.disk_src.ops_per_sec on:
> > 
> > 
> > commit: a2e459555c5f9da3e619b7e47a63f98574dc75f1 ("shmem: stable directory offsets")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > 
> > testcase: aim9
> > test machine: 48 threads 2 sockets Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz (Ivy Bridge-EP) with 112G memory
> > parameters:
> > 
> > testtime: 300s
> > test: disk_src
> > cpufreq_governor: performance
> > 
> > 
> > In addition to that, the commit also has significant impact on the following tests:
> > 
> > +------------------+-------------------------------------------------------------------------------------------------+
> > | testcase: change | aim9: aim9.disk_src.ops_per_sec -14.6% regression                                               |
> > | test machine     | 48 threads 2 sockets Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz (Ivy Bridge-EP) with 112G memory |
> > | test parameters  | cpufreq_governor=performance                                                                    |
> > |                  | test=all                                                                                        |
> > |                  | testtime=5s                                                                                     |
> > +------------------+-------------------------------------------------------------------------------------------------+
> > 
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <oliver.sang@intel.com>
> > | Closes: https://lore.kernel.org/oe-lkp/202309081306.3ecb3734-oliver.sang@intel.com
> 
> Hi, several weeks ago we requested that these tests be run
> again by the robot because they can't be run in environments
> I have available to me (the tests do not run on Fedora, and
> I don't have any big iron).
> 
> We wanted the tests rerun before the patch was committed.
> There was a deafening silence. So I assumed the work I did
> then to address the regression was successful, and the
> patches are now in upstream Linux.
> 
> This new report is disappointing.

I'm so sorry that I missed the test request for
https://lore.kernel.org/all/169030957098.157536.9938425508695693348.stgit@manet.1015granger.net/

just FYI, when this auto-bisect done,
head commit of linus/master: [65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4] was
tested, it already includes
2be4f05af71bb libfs: Remove parent dentry locking in offset_iterate_dir()

in our tests, the regression still exists.


> 
> But, I'm still in a position where I can't run this test,
> and the results don't really indicate where the problem
> is. So I can't possibly address this issue.
> 
> Any suggestions, advice, or help would be appreciated.

if you have further fix patch, could you let us know? I will test it.

> 
> --
> Chuck Lever
> 
>