Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <3ee11823-a441-b646-bdd7-aedd3a3a55e5@linaro.org>
Date:   Wed, 13 Sep 2023 09:03:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH V2 4/5] ASoC: codecs: Change the aw88261 variable name and
 i2c driver name
Content-Language: en-US
To:     wangweidong.a@awinic.com, lgirdwood@gmail.com, broonie@kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com,
        rf@opensource.cirrus.com, shumingf@realtek.com,
        ckeepax@opensource.cirrus.com, herve.codina@bootlin.com,
        13916275206@139.com, ryans.lee@analog.com,
        linus.walleij@linaro.org, sebastian.reichel@collabora.com,
        fido_max@inbox.ru, povik+lin@cutebit.org, arnd@arndb.de,
        harshit.m.mogalapalli@oracle.com, liweilei@awinic.com,
        yijiangtao@awinic.com, colin.i.king@gmail.com, trix@redhat.com,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230912065852.347000-1-wangweidong.a@awinic.com>
 <20230912065852.347000-5-wangweidong.a@awinic.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230912065852.347000-5-wangweidong.a@awinic.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/09/2023 08:58, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
> 
> Change "sound-channel" to "awinic,audio-channel"
> Change "aw88261_smartpa" to "aw88261"


> -	prof_name = aw88261_dev_get_prof_name(aw88261->aw_pa, count);
> -	if (!prof_name) {
> +	ret = aw88261_dev_get_prof_name(aw88261->aw_pa, count, &prof_name);
> +	if (ret) {
>  		strscpy(uinfo->value.enumerated.name, "null",
>  						strlen("null") + 1);
>  		return 0;
> @@ -1189,7 +1190,7 @@ static void aw88261_parse_channel_dt(struct aw88261 *aw88261)
>  	u32 channel_value = AW88261_DEV_DEFAULT_CH;
>  	u32 sync_enable = false;
>  
> -	of_property_read_u32(np, "sound-channel", &channel_value);
> +	of_property_read_u32(np, "awinic,audio-channel", &channel_value);
>  	of_property_read_u32(np, "sync-flag", &sync_enable);

What about this?

Best regards,
Krzysztof