Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
References: <20230911134633.619970489@linuxfoundation.org> <1ffe4f64-f238-859a-ab14-7559d03c4671@linaro.org>
 <CAEUSe7_XA16yZAHA+YTbJygwaUYkU5gs=FnV9BAmQRYzwgVjvQ@mail.gmail.com>
 <CA+G9fYsiWEKSV0EeU0cXsJZ3U75fbdGyCmDx07ksFMUW5jouyw@mail.gmail.com>
 <2023091233-boots-line-a3d4@gregkh> <CA+G9fYt2Jnxwvpzcd66HCqkPi6CNistHfmxQYAzX22OWHUoUSA@mail.gmail.com>
 <2023091213-awning-driveway-4671@gregkh>
In-Reply-To: <2023091213-awning-driveway-4671@gregkh>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Wed, 13 Sep 2023 19:25:33 +0530
Message-ID: <CA+G9fYtY7_-JgVizZuVJZ3RX0e3eZ3ri8AxDpkkPdP-uYfZ1ig@mail.gmail.com>
Subject: Re: [PATCH 6.1 000/600] 6.1.53-rc1 review
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     jack@suse.cz, stable@vger.kernel.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
        patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de,
        jonathanh@nvidia.com, f.fainelli@gmail.com,
        sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de,
        conor@kernel.org,
        =?UTF-8?B?RGFuaWVsIETDrWF6?= <daniel.diaz@linaro.org>,
        Tom Rix <trix@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Greg,

> > > > > For what it's worth, bisection points to 903b487b5ba6 ("udf: Handle
> > > > > error when adding extent to a file").
> > > >
> > > > I see the following commit is fixing the reported problem.
> > > >
> > > > commit 6d5ab7c2f7cf90877dab8f2bb06eb5ca8edc73ef
> > > > Author: Tom Rix <trix@redhat.com>
> > > > Date:   Fri Dec 30 12:53:41 2022 -0500
> > > >
> > > >     udf: initialize newblock to 0
> > > >
> > > >     The clang build reports this error
> > > >     fs/udf/inode.c:805:6: error: variable 'newblock' is used
> > > > uninitialized whenever 'if' condition is true
> > > > [-Werror,-Wsometimes-uninitialized]
> > > >             if (*err < 0)
> > > >                 ^~~~~~~~
> > > >     newblock is never set before error handling jump.
> > > >     Initialize newblock to 0 and remove redundant settings.
> > > >
> > > >     Fixes: d8b39db5fab8 ("udf: Handle error when adding extent to a file")
> > > >     Reported-by: Nathan Chancellor <nathan@kernel.org>
> > > >     Signed-off-by: Tom Rix <trix@redhat.com>
> > > >     Signed-off-by: Jan Kara <jack@suse.cz>
> > > >     Message-Id: <20221230175341.1629734-1-trix@redhat.com>
> > >
> > > Wait, where is this commit?  I don't see it in Linus's tree either, nor
> > > in linux-next.  Where did you find it?
> >
> > Can you find this commit id ?
> >
> > Commit id: 23970a1c9475b305770fd37bebfec7a10f263787
> > subject: ("udf: initialize newblock to 0")
>
> Yes, that is in 6.2.  Where did the id you used above come from?

While looking around for the fix commit i found this on Linux next,

$ git log --oneline next-20221226..next-20230106  -- fs/udf/inode.c
e86812bfac97e udf: Detect system inodes linked into directory hierarchy
453bc25de0a55 udf: Preserve link count of system files
6d5ab7c2f7cf9 udf: initialize newblock to 0

>
> confused,

Sorry for the confusion.

> greg k-h

- Naresh