Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3283659rdb; Wed, 13 Sep 2023 07:40:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4/ew2IrUJP4DqnTd970r9hZ1zXr/XsylPNOLe9c2L7YgpYdub1OFhgXyeCtdSnMdHFyZa X-Received: by 2002:a05:6a00:1389:b0:68b:dfef:de77 with SMTP id t9-20020a056a00138900b0068bdfefde77mr3469291pfg.25.1694616046059; Wed, 13 Sep 2023 07:40:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694616046; cv=none; d=google.com; s=arc-20160816; b=ZrDnDK5tkAwyog3uxfE5B6lI5mAn/8/OCXUxqJBe9q4weHdvp1ECBqgOYeMmApwbO2 /eqfhud1kew98tNNI52Z4uSkrv2bnOHKdktkSve9JwAOGp2gvyuSUUSEwdFl6AXZ9nfz SVjZNcuYM/gSPuNC6wQ7vepP3lF0tF082dsqeHynLyuka3HhdYAML0T7lRh+zRh4bo+i jR9E40reDgBaug7kGZuY67zdUg9cLGjEb3XiIMTTwIW4840o4rHAldVWDy0GhpghtYlx +G+A/xvZnXlLfLWAm/ep44uO7bWQRvzr1TilWqJYTwBnMeiUfEj0BwDVasR/psznc8A4 R/fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rvFldvig6Us95Z6buB40c4bst6L0xGkB6/ISfngAxSA=; fh=u7KVGt28ZEMy52MJoPOmBROco0R3kkiDTq/98pAqOVE=; b=VhsElPLdjfCfin2t+PqSNEa23TmUiuOKk9+J1R0wPyHyct50T3Zr5pxCFmL760iz6r T0hRYsRCyBboVlAAkHL/AjszZ7sc8ktLqoVJWYAEbnxpuijX4TSUqMDKnh8A/Mrpeqd7 rGCYcA+JQ3s1qrPwDuxJYnnoP8EH7Wf3+t5ierjb9eeIUp+YQWp9XqWduBHypKO6WJKV sbXLZUCa8Ys98JJ/7Hah643Q7BghPrh2J+6esNduXA3R8SqWJcU3p8Kha1Z5CQmIjVGn Ru38VAF70fh9p6OweYbPo9PvqKUh3IN+RXye3+gA42MViw6/MpDNN3Kc1OuJynsHF8TV NE7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h0mv2ujn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bv185-20020a632ec2000000b0056357813fc2si9772750pgb.183.2023.09.13.07.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 07:40:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h0mv2ujn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id AC598801E680; Wed, 13 Sep 2023 07:39:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240038AbjIMOjy (ORCPT + 99 others); Wed, 13 Sep 2023 10:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbjIMOjy (ORCPT ); Wed, 13 Sep 2023 10:39:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38CA490; Wed, 13 Sep 2023 07:39:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C64A7C433C8; Wed, 13 Sep 2023 14:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694615989; bh=RJoIfCcg3Gqvlc6Pv3L0lR4WCeRLMrROYaRGXX3uIAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h0mv2ujnNPBV1QjbllewX4FCxcYj7UIsM7RYsumCnJYKKZxxARRvsgTPkchtVUrOG Rml9dusWCC3tOaFcBAlQZ+HyhFi21PQ2icCnZXU3YytqIFh6XOGdkU+3kNu8TwDyhB WJRDtBek5vWld2P/ShKcBo1SVBdzlme7UdBJijsO2e7k/u1AEtQ98HIez9iAnnMUp4 WtYw87YW09XXT8g6GAGAFdOQxLYlJqVfeq92qL/KbAHqYFGZFctKtSpKUUK5BmqQUq W6tyh/Uvo62Cr0+7zVDD/qfL/7JXV4Zt19ttI2wt2FXW7Ioi+S8Uq74Ra8HfNT3oE4 dbw/bY7nHM5AQ== Date: Wed, 13 Sep 2023 15:39:41 +0100 From: Conor Dooley To: Rob Herring Cc: Herve Codina , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Message-ID: <20230913-faceless-sloppy-9c408191630a@spud> References: <20230912081527.208499-1-herve.codina@bootlin.com> <20230912101444.225809-1-herve.codina@bootlin.com> <20230912-overplay-donated-080eb97803d6@spud> <20230912185405.GA1165807-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f/ltRk1gE1+sCzTa" Content-Disposition: inline In-Reply-To: <20230912185405.GA1165807-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 07:39:55 -0700 (PDT) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email --f/ltRk1gE1+sCzTa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 12, 2023 at 01:54:05PM -0500, Rob Herring wrote: > > > + lantiq,data-rate-bps: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + enum: [2048000, 4096000, 8192000, 16384000] > >=20 > > -kBps is a standard suffix, would it be worth using that instead here? > > What you have would fit as even multiples. > > Otherwise Rob, should dt-schema grow -bps as a standard suffix? >=20 > Yeah, I think that makes sense. I've added it now. Cool, thanks! --f/ltRk1gE1+sCzTa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQHJrQAKCRB4tDGHoIJi 0iNbAQCQvNI/6rj3MUcE4cZYQRwXdY48ReUFl3upkSIAwL59UwEA5YVuiJyYj+pl y+M6tf6hogZBT32WxEtJnwijye97rQw= =lb0d -----END PGP SIGNATURE----- --f/ltRk1gE1+sCzTa--