Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <a1531a48-b59d-d5ff-130b-5cc6a571a9d1@intel.com>
Date:   Wed, 13 Sep 2023 12:07:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] tracing/user_events: fix long size check in the ABI
 selftest
Content-Language: en-US
To:     Shuah Khan <shuah@kernel.org>,
        "Steven Rostedt (Google)" <rostedt@goodmis.org>
CC:     Beau Belgrave <beaub@linux.microsoft.com>,
        Ira Weiny <ira.weiny@intel.com>,
        <linux-kselftest@vger.kernel.org>, <stable@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230911160935.10720-1-aleksander.lobakin@intel.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230911160935.10720-1-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekkzMzROYkYwVUtqdFRpNnZPWC9PMit6b2hJdWdKSElLQ241OGtYMnA4UnpZ?=
 =?utf-8?B?ZEVpNFlQUXVsQnRrQ2JPMTdUb0ZhcVdNODFwTUVkTU1MdXl6ZHpNWWluN1lW?=
 =?utf-8?B?U0VOd1JvSHhUVEQ4UC94cVM4Qldxdk1LYVkyZDNOZ3h1MnJjKzZ1UlA3bE9W?=
 =?utf-8?B?eDZoN3kvTnhmdUJQc2JFWHVaWXcwUTlGYWJ4WlIzQ3FlRWM4UjNsRWlHU3FO?=
 =?utf-8?B?WkJoYUc5WnQwYTJ0Vi9GcnlRRS9hNisvd05rU2l1VmlRdEVYRW83TVR4bEVE?=
 =?utf-8?B?SkJpY2ZUSDAwdFZvT1lMdUZIUHNYOXRIZDlFVDRiWUt4WkNhMFFWZHd0TVB2?=
 =?utf-8?B?blhVMkMvbFNSYTBOQzdPejFFRVBhL2ljSFVFVEpVWXp6SE9UYUxrUlZUR3Bh?=
 =?utf-8?B?VHBtelIwQUVWUFpadFdGQ3NleklOWStRVk5uMnhKdHVsTmZ2aWVVRTdBdERj?=
 =?utf-8?B?K3BZTUNYNTFBUTVuZ0JOblRZNHhhSnBIYXh1MDRtMlJTeDQyaXhWbGZtbEhy?=
 =?utf-8?B?V01CY1hIck96OGdHWXc3SE02TkJqSDRqK3F4U3BHczFBeFVwRERpV2hkSm50?=
 =?utf-8?B?Sjd5ZzNvS0pQU3M5YTllWURmb3FvN3l5ME9JeCtxNzRoeDFkU2NmQkYvbXpG?=
 =?utf-8?B?NmFlTzBjRzZUYUlVSGxpbjdqUGFBQWk3Y2RRV0gwaHhJSDVzYSs2M0hIVGZF?=
 =?utf-8?B?L0YyMGZIcXVPTXhWcnJQVGhGRzVUODBLQ1IrRkl1Q3ZmeGxRNWZJZzNLRENu?=
 =?utf-8?B?Nm1PbEpaSHlIWjcyU3RNTWVUMG5uNktpZzVpS1E3ZzlOZHFhRHlJOStWL2N0?=
 =?utf-8?B?bFBlNnEyUGVLUFhjN2NFMzN4aU4vblNMcGtudEN2TzVCZkFMbjhKMUU4ZlZm?=
 =?utf-8?B?MFhrQ2ttYjhBandLMTR0N0ZSM0o0OTEvdG1HN212NTFGZXg4VExiYm5LaXM1?=
 =?utf-8?B?UHE2UVJPWUVmbEo3ekhIempzT0dxN1V0Q05BZTNvcGx4TG9jdGFOODVkWVZx?=
 =?utf-8?B?SWVhSVBybVc1NFJzZG1oRjhWbG5LcDRLQmZvTUJpZCtkUFRLaExOeTV6Umcx?=
 =?utf-8?B?dHM2a3hZWGI4bkJrU1l3bFcrNDNrS0p4RXc2U3k3WlI4UFdzVHRDT1Y4NWdY?=
 =?utf-8?B?U0Vqb1NHM2I5clNTTzc0WDlNS044WFZ1bUwwUkp2TjYrQXlGSHJDK2VYcVNH?=
 =?utf-8?B?L2lHQjZURnZveDRKYTY0T3g2Qld0cFZWZFh6ejZzaHVqUHlpV1pYOEZyMmJB?=
 =?utf-8?B?MjgxblYrd0hOM1lIVWxrZDg1N1F4emgwU1F4L1ZXV0RrVTJ2SVFQa0tLUkFS?=
 =?utf-8?B?TUI3V2h1NnNTdnQrbXlhSEFJVHJPUStoZXVwdTRhbFY2bjZLWDlSUjZIaUlZ?=
 =?utf-8?B?bFJHc05Zd0RDdHcweE4yWGNMamlJalR2R1UyTnBTR3VkMkhvTkk1UHloMVZ6?=
 =?utf-8?B?ejhDWmQ5Nm00eEZQL3RNRDg4eW9sT0FwVFpBSzZkSzJQaDFVQ2JaQlZDV1hI?=
 =?utf-8?B?dE9DM1ZLQnZabVJzWWxUVWZTL0VLQlhORUJXL2xCenUyanFxMmxuN2ZtdjVo?=
 =?utf-8?B?MUpxTkRQZjJsNllCM1krV3JqaGhINGRMMnBRamRScWhoQTRGQlJEWFFpL3cy?=
 =?utf-8?B?cVFCMkNYaTExbjF6cDY2MFY4V0pST1RVRUprTXRqY1hkQUNsTzhwdUppUWFo?=
 =?utf-8?B?UjdZZ2JwUEpYTmJzdW5KUlJMcHloT2FwTW1oU2lVNWc1SEExTlRndlllejJU?=
 =?utf-8?B?VVJzRUo2RGVXemx3bFVsdmZTRzlqSk1yTmlBVk1YMWNkZ1gwamw0K2RKL0J4?=
 =?utf-8?B?dVJMSDJrWWZYZGkwTXdQaytkRTNvVU82ZlN1VGU2djVOeWRzWGRiU3dPWGxu?=
 =?utf-8?B?Rlo5cGJiQTlrY0lZYVR1K1NQcmZGZmJYUVYwQnp0cGNWT214QThyVndPVDFy?=
 =?utf-8?B?ajRzM3N0K1FFbkNGZlgyZ3BoNGxoR05lTmNXbFNQU1daZHZ0TnpzcjdqV0ow?=
 =?utf-8?B?SitPNjRCTnMrT2Vic1YzZHlVeklJRDFhUGV5aHlPTVB5ZitNd1FMN0R5Z3dQ?=
 =?utf-8?B?cUhQZTBkZEtHYXZTK25Rbk5kT241TzliRDNudG5UUTJSVDVzMG9PSGhTNUZ1?=
 =?utf-8?B?bGNLaUpEejRnZFk4ZFJ1ZkY2eGdabWxCalhxYStkclFCTk5xWXpCVnBpcDdP?=
 =?utf-8?B?bHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f88dcbd-ba77-43e8-5e32-08dbb4414511
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 10:07:43.1657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3mYS1T0erp/Fm3qBvwt9iKU5r7mJo3szk+HxfvzCJDSSniR6ga30PSNep8G64nuatIXDFGjU6eTuwCLgGxV17PNuIE88HO/DCDWzCLsb5tE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7624
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Sep 2023 03:07:59 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Mon, 11 Sep 2023 18:09:35 +0200

> The current check for 64-bit architecture is double-bugged.
> First of all, %BITS_PER_LONG is not available in the userspace,
> the underscored version from <asm/bitsperlong.h> must be used.
> The following check:
> 
>  #if BITS_PER_LONG == 0
>  #error
>  #endif
> 
> triggers the error in this source file -- the macro is undefined and
> thus is implicitly evaluated to 0.
> Next, %BITS_PER_LONG means "bits", not "bytes". In the Linux kernel,
> it can be 32 or 64, never 8. Given that the tests guarded by that check
> are meant to be run on a 64-bit system, the correct value would be 64.
> 
> Prefix the macro name and fix the value it's compared to.
> 
> Fixes: 60b1af8de8c1 ("tracing/user_events: Add ABI self-test")
> Cc: stable@vger.kernel.org # 6.4+
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Patchwork says "Accepted", but I don't see it anywhere on korg O_o

[...]

Thanks,
Olek