Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3307408rdb; Wed, 13 Sep 2023 08:16:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE45oFJlLN146HUdykDPTk/FfW/2V+ycJoyXnAMjtlfeh4s8oaeTnDZGQf4VwNUw/p5+/xF X-Received: by 2002:a05:6870:a2d1:b0:1d4:d016:22a3 with SMTP id w17-20020a056870a2d100b001d4d01622a3mr2942459oak.7.1694618199432; Wed, 13 Sep 2023 08:16:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694618199; cv=none; d=google.com; s=arc-20160816; b=N61LlRV+j8/IfVvXGueT7VDTAWcR/iWNRRVf2qIq1tPq+InyLgcgzg2uiuywnCWNtM T+IaiKgQcJiRRHjXA187D9YVjNxofG5lCFmbJirvrW0xyAT3C63JH5SLz5tQTGd20vBX JjTtorXV8AIcmYrDAOjfbcbcZm2DuXNrmP94Bqyhui0mZ8HH40lCdLzDxbVSCFrZFhOc 7nTH3Sjtif8afficVx02ykMfuptVfw5kHYnPSjWyAK9g+VweTEk6kur/jp37Q7ULz4tt vTlThQwQgwUoFuaCuFwbonOOxC9GvWULEauOaHN2u6NrinNDNjznnVMAmVfGWcPPClm5 s3Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=IfQQwZ9QXlwCfkvMrB5PtlK3NyN0a7PbMHdl8QtueJU=; fh=tjI2xkDCBoL7jIvXx2pJezTKczPEhrAeOrkCAW5XZDs=; b=JKu0BXxZ2WLDNjDPKD0st+0vFjkGF737a0p//6wiZBnexK1fmjZSulawHKF0TGObn4 sGf5HEG/Xo55uVs8sBK39MAxyMpNRwGIQ5q+LYuM5OD73vNrtaKXrST3WFa1eXfyVmym a2VI0XNqKzunSJCru3poh2//JZzONDO5282zBr3TTkXUXO+Tq4X4sw33P6rIGWt3VZxu 2eXVs4u3MTdOrDHG0HestKEgmj0ZBM3Veflm6HZow+/tKCSXELsEriiRiTYN4EePTuYC oX6854fLEs3hbHOavLQli3xmLDwqBXL4WrjI4u30Qbbvf7pQcRmRk08dMf+2b7nfIqiX XNsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d7v2m6g+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id 19-20020a631753000000b0056531bfc660si10464495pgx.143.2023.09.13.08.16.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 08:16:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d7v2m6g+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 70DE580A64E3; Wed, 13 Sep 2023 05:17:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240353AbjIMMRI (ORCPT + 99 others); Wed, 13 Sep 2023 08:17:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240320AbjIMMRG (ORCPT ); Wed, 13 Sep 2023 08:17:06 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1CF819A8 for ; Wed, 13 Sep 2023 05:17:02 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-d815a5eee40so469211276.2 for ; Wed, 13 Sep 2023 05:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694607422; x=1695212222; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IfQQwZ9QXlwCfkvMrB5PtlK3NyN0a7PbMHdl8QtueJU=; b=d7v2m6g+cvTuiLDMKjcfTIFxqPTQ9wQekPpoDGiu5pJGBOozU3d0Fe22cec3XDCAEz f+PI4Bo9QJWhyNVzTqA+LIGPBYM+qHT/xdf3zR0/fLWvP0LFH+8Ua4tHfZfrm9cY7AIx GDIYW4yUgCQVFPHh8Cc4OWvBTpgzK9mNNE73Ltj+FdOwpuka7/et7K4JyT+HXMssV3Ng GVFMAwaNoeX3ryB/xdNRC5noynlN2CC4Ia66NHi2TSrgMOEUbfBPqSUPZKoTUPDrZ2g6 IPVjaL+7wgUfIO+tUR6+Go7BzEe9CeO5DREmKC/w3nK8VJ6MirsDA9S9Zd9K1jvsSIAk zUAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694607422; x=1695212222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IfQQwZ9QXlwCfkvMrB5PtlK3NyN0a7PbMHdl8QtueJU=; b=D/7X7AwHVsHZREK0c4dey5FltgyBRyx2ab8wqp5Q/Y/BmWRpAEoarRrfeF1/M/Bbj4 FY8Epf0BHo1Kbb+OBr9KCC5wMHNFQks+N9h9ASwg+fMxSkAlJMxlPfnmOp27Wq/3eX9v cQ1b10FjEhPblddNbgOPiXmBf0KHewS8UyHWfyn2EC70vkabYOxspPblK57uHj/VbYEi 8DhDCeOSeYbZRC+yEV0vRbVHksq3C7AAAJJ/BWxQDVD6UnNT3dfzzfGptzyhD2XLY3oR pH1Wo55bPgMFcBrT9bQaOE1HOM23r0ESXi9Kk1TH7qA1t3JVO2dJ+5lPC7+BwqYcIN1i hZew== X-Gm-Message-State: AOJu0YxCgDTg6GVZqRpmuzziUPI+h3+V1qKDwiF1fv4ZVdx8O7ffTaRB 5Ihfa8uh3XTwntRaHGKMlseYtYHMYdasiXonmYcocw== X-Received: by 2002:a25:7451:0:b0:d7f:d510:bbf4 with SMTP id p78-20020a257451000000b00d7fd510bbf4mr2198433ybc.52.1694607422023; Wed, 13 Sep 2023 05:17:02 -0700 (PDT) MIME-Version: 1.0 References: <20220617123003.4048328-1-windhl@126.com> In-Reply-To: <20220617123003.4048328-1-windhl@126.com> From: Linus Walleij Date: Wed, 13 Sep 2023 14:16:51 +0200 Message-ID: Subject: Re: [PATCH] arm: mach-versatile: Fix refcount leak bug in tc2_pm To: Liang He Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 13 Sep 2023 05:17:10 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email On Fri, Jun 17, 2022 at 2:30=E2=80=AFPM Liang He wrote: > In tc2_pm_init(), of_find_compatible_node() will return a node pointer > with refcount incremented. We should use of_node_put() in fail path or > when it is not used anymore. > > Signed-off-by: Liang He Patch applied. Yours, Linus Walleij