Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3339070rdb; Wed, 13 Sep 2023 09:05:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHf5iwIOfqE010h2HgMNuQPykrZAqjfBv6iBNry7KyMcO4kXtwXYCzyYrEetMSqYIs1tozT X-Received: by 2002:a05:6a21:788b:b0:154:fb34:5f09 with SMTP id bf11-20020a056a21788b00b00154fb345f09mr3374939pzc.15.1694621118132; Wed, 13 Sep 2023 09:05:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694621118; cv=none; d=google.com; s=arc-20160816; b=mWp+jGM+vLNVwYMtxRfbwI97H+BbIUc4Unzlhf/YuXZaKW7z7+fK9k80mYDGBjzour 7TBoB1wvhItv7JJj6MXh1Un0TME/bbUOuL/jSxYzJRBzVRlZ13+4JslAbk9TqBqkd5a8 ajg5OkGFbpT2gJVzllbxSwR1nKYwsQ2Wn4O5JV4FUPEjWociKHDeNnZjKdttK7UjsgZx 9Iot5ZJ/ox0lZbviPR8UW8aF1uo2LIPcrN8C/VlsvyD6M4A/TWeo56Ygskb0cmXM/d0v QVOIvrFkNeCtn2E5zClP3PU6zz4ABjp76qtify6xhpU2dPNCRq6cV74+p+r4T2v5uWK1 9Z4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fiL8lHnS1pF+d9K7wzC8R+oSznDkNywF+yHkLggREm0=; fh=30+N3zdL5NoLMEOkS7YR7cRsHcwXGQLvdIWisPtAQjo=; b=eG/r69ryCkNnx1uUgyxoY5CwOJDL+x4PQo7CRzLGx39G8GUp7NNIXVmhF0fkFlmF8d Oi+4oZ67iLjRERAQ1bbQXlGfPFGOWTTKv/76+FN/zh4mDiWX+mkieV3IeOV110NiqFHB 6zmofI0THqAaCsiiobKL2NQgtzhfntN54o/3vi2LkkeobzPFfLOdY5GLBtm1IHHmVVKW Nyunyw3FsSsmzGmyVdinPV8NYT1eEdHhoSYH8KQ5RbrPJ/QwSRSGVZAsxfQT2Rlhlm8y gFs6FlfxgDDBSMMfgWKygF7Amt7dQHdU0f18KqJo5lQ+ia+w/pjeuWjB1oGkF2HwBesT rZRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=YKg5UPqu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id m9-20020a654389000000b0055be9543340si9998277pgp.872.2023.09.13.09.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 09:05:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=YKg5UPqu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E56AF80BEF1D; Wed, 13 Sep 2023 08:56:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbjIMP4y (ORCPT + 99 others); Wed, 13 Sep 2023 11:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbjIMP4x (ORCPT ); Wed, 13 Sep 2023 11:56:53 -0400 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73C7B19A0 for ; Wed, 13 Sep 2023 08:56:49 -0700 (PDT) Received: from pps.filterd (m0148460.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38DEkFlo019744 for ; Wed, 13 Sep 2023 08:56:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=fiL8lHnS1pF+d9K7wzC8R+oSznDkNywF+yHkLggREm0=; b=YKg5UPqunQQMCv73yKxpZNQeVcUqZHPmdnuqdToBWfCd4n3HelL+sA7K2uQw0/dq84tJ rMfoOisluP03/wEcnQBKoa9HauizE54+A51FIEtGStBUKKwaf60cCAZV2n42hv/7viqT 4SBy2SSsNf5dqJqi+oj/DAZDeakYd9s3iqlXBDnDkY392jBQ04Xj1xM7KOxkKDdAU8Ai q9xlFRSKMEtKAKU/7tgEGiwrb5EWHr8ymjUkJylpiDtuI/jr6Dvx7lLsPEXRWM+EmYrA RfC2/NMC+U8Nhh4u3vyevkVquyt3IJ6tBNCaaGs2ROGvsWAyHmZt7neZumbkGEOUFiEt BA== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3t2y8d9a5t-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 13 Sep 2023 08:56:48 -0700 Received: from twshared1579.04.ash8.facebook.com (2620:10d:c085:208::11) by mail.thefacebook.com (2620:10d:c085:11d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 13 Sep 2023 08:56:44 -0700 Received: by devvm715.rva0.facebook.com (Postfix, from userid 240176) id A8A382954BC63; Wed, 13 Sep 2023 08:56:40 -0700 (PDT) From: Michal Grzedzicki To: Michal Grzedzicki CC: , , , , , Jack Wang Subject: [PATCH 2/2] pm80xx: Avoid leaking tags when processing OPC_INB_SET_CONTROLLER_CONFIG command Date: Wed, 13 Sep 2023 08:56:11 -0700 Message-ID: <20230913155611.3183612-2-mge@meta.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230913155611.3183612-1-mge@meta.com> References: <20230913155611.3183612-1-mge@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: 89--Qm83UGY5nYeMNqWcB0J_T2DbMIRO X-Proofpoint-ORIG-GUID: 89--Qm83UGY5nYeMNqWcB0J_T2DbMIRO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-13_10,2023-09-13_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Sep 2023 08:56:56 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Tags allocated for OPC_INB_SET_CONTROLLER_CONFIG command need to be freed when we receive the response. Fixes: f5860992db55 ("[SCSI] pm80xx: Added SPCv/ve specific hardware func= tionalities and relevant changes in common files") Fixes: a6cb3d012b98 ("[SCSI] pm80xx: thermal, sas controller config and e= rror handling update") Signed-off-by: Michal Grzedzicki Acked-by: Jack Wang --- drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80x= x_hwi.c index 1b2c40b1381c..3afd9443c425 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -3671,10 +3671,12 @@ static int mpi_set_controller_config_resp(struct = pm8001_hba_info *pm8001_ha, (struct set_ctrl_cfg_resp *)(piomb + 4); u32 status =3D le32_to_cpu(pPayload->status); u32 err_qlfr_pgcd =3D le32_to_cpu(pPayload->err_qlfr_pgcd); + u32 tag =3D le32_to_cpu(pPayload->tag); =20 pm8001_dbg(pm8001_ha, MSG, "SET CONTROLLER RESP: status 0x%x qlfr_pgcd 0x%x\n", status, err_qlfr_pgcd); + pm8001_tag_free(pm8001_ha, tag); =20 return 0; } --=20 2.34.1