Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <d06e124e-ea95-469b-a606-1e55806f3df0@mev.co.uk>
Date:   Wed, 13 Sep 2023 16:04:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 05/13] comedi: 8255_pci: Conditionally remove devices that
 use port I/O
Content-Language: en-GB
To:     Arnd Bergmann <arnd@kernel.org>, linux-kernel@vger.kernel.org
Cc:     Niklas Schnelle <schnelle@linux.ibm.com>
References: <20230913112032.90618-1-abbotti@mev.co.uk>
 <20230913112032.90618-6-abbotti@mev.co.uk>
 <51a9af18-a5e4-4cb1-9f95-491bf73d35f1@app.fastmail.com>
From:   Ian Abbott <abbotti@mev.co.uk>
Organization: MEV Ltd.
In-Reply-To: <51a9af18-a5e4-4cb1-9f95-491bf73d35f1@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/09/2023 13:03, Arnd Bergmann wrote:
> On Wed, Sep 13, 2023, at 13:20, Ian Abbott wrote:
>> In a future patch, the port I/O functions (`inb()`, `outb()`, and
>> friends will only be declared in the `HAS_IOPORT` configuration option
>> is enabled.
>>
>> The 8255_pci module supports PCI digital I/O devices from various
>> manufacturers that consist of one or more 8255 Programmable Peripheral
>> Interface chips (or equivalent hardware) to provide their digital I/O
>> ports.  Some of the devices use port I/O and some only use memory-mapped
>> I/O.
>>
>> Conditionally compile in support for the devices that need port I/O if
>> and only if the `CONFIG_HAS_PORTIO` macro is defined.  Change
>> `pci_8255_auto_attach()` to return an error if the device actually
>> requires port I/O (based on the PCI BAR resource flags) but the
>> `HAS_IOPORT` configuration is not enabled.
>>
>> Cc: Arnd Bergmann <arnd@kernel.org>
>> Cc: Niklas Schnelle <schnelle@linux.ibm.com>
>> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
>> ---
>>   drivers/comedi/drivers/8255_pci.c | 11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/comedi/drivers/8255_pci.c
>> b/drivers/comedi/drivers/8255_pci.c
>> index 0fec048e3a53..4c4c0ef1db05 100644
>> --- a/drivers/comedi/drivers/8255_pci.c
>> +++ b/drivers/comedi/drivers/8255_pci.c
>> @@ -57,6 +57,7 @@
>>   #include <linux/comedi/comedi_8255.h>
>>
>>   enum pci_8255_boardid {
>> +#ifdef CONFIG_HAS_PORTIO
> 
> I think this is a typo: HAS_IOPORT vs HAS_PORTIO?
> 
>       Arnd

Oops!  Well-spotted.  Actually, this affects several of the patches!

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-