Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Wed, 13 Sep 2023 12:03:39 -0500
From:   Steve Wahl <steve.wahl@hpe.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Steve Wahl <steve.wahl@hpe.com>,
        Justin Ernst <justin.ernst@hpe.com>,
        Kyle Meyer <kyle.meyer@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH] x86/platform/uv: Use sysfs_match_string() for string
 parsing in param_set_action()
Message-ID: <ZQHray72BRX+mSrL@swahl-linux>
References: <20230913151656.52792-1-hdegoede@redhat.com>
 <ZQHpC/oKLwfJuvRu@swahl-linux>
 <4f41e78e-5e47-0726-c64a-82559d1f799b@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4f41e78e-5e47-0726-c64a-82559d1f799b@redhat.com>
Precedence: bulk

On Wed, Sep 13, 2023 at 07:01:31PM +0200, Hans de Goede wrote:
> Hi Steve,
> 
> On 9/13/23 18:56, Steve Wahl wrote:
> > On Wed, Sep 13, 2023 at 05:16:56PM +0200, Hans de Goede wrote:
> >> Remove the custom, hard to read code to:
> >>
> >> 1. Make a copy of "val" with any potential '\n' at the end stripped
> >> 2. Compare the copy against an array of allowed string values
> >>
> >> Linux has the sysfs_match_string() helper exactly for cases like this,
> >> switch to this.
> > 
> > Hans,
> > 
> > I like this patch, compiling and testing now.
> > 
> > I was wondering, as long as we're in the neighborhood, how you feel
> > about changing the stored variable uv_nmi_action to an int or enum
> > rather than a string, since it can only be one of 6 values, and the
> > string compare while processing an NMI strikes me as inefficent.
> > 
> > It could extend this patch, or be done as a follow on.  And I'm
> > willing to supply the effort if you want me to.
> 
> I must admit I did not look at the code consuming uv_nmi_action
> and I did wonder why this was not an enum from day 1.
> 
> I'll prepare a v2 of this patch which changes uv_nmi_action
> to an enum.
> 
> Note I can compile test this only, so I gope you will be able to
> test the v2 a bit more thoroughly :)

I will!

--> Steve Wahl

-- 
Steve Wahl, Hewlett Packard Enterprise