Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <29e27f2a-3347-b6f4-2dd9-4c93afea87b7@roeck-us.net>
Date:   Wed, 13 Sep 2023 06:37:21 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH] hwmon: max31790: support to config PWM as TACH
Content-Language: en-US
To:     Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>,
        "patrick@stwcx.xyz" <patrick@stwcx.xyz>,
        Jean Delvare <jdelvare@suse.com>
Cc:     "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230906084837.3043030-1-Delphine_CC_Chiu@wiwynn.com>
 <20230906084837.3043030-3-Delphine_CC_Chiu@wiwynn.com>
 <8a3b41a2-0ab2-6213-04a1-54ab7263c647@roeck-us.net>
 <TYZPR04MB58533E15AA65FCDA0F603FA3D6F0A@TYZPR04MB5853.apcprd04.prod.outlook.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <TYZPR04MB58533E15AA65FCDA0F603FA3D6F0A@TYZPR04MB5853.apcprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/13/23 01:51, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:

[ ... ]

>>
>> This assumes that the channel is configured as pwm.
>> What if the BIOS / ROMMON configured another channel which you want as
>> pwm channel as fan input channel ?
>>
> This will config the channel as TACH.
> Could you provide more information about the scenario you mentioned?
> In our system, there is only BMC that will set the config of fan device.

Please keep in mind that upstream code is not intended to only support
your specific use case, but the use case of others as well. Your system
(the one you have today) may only use the chip for fan speed
measurement. Others may use it use it to control fans, or your hardware
might tomorrow build another system where the chip us used to control
the fans as well. Those use cases should be covered by your patch as well.

Guenter