Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <fa5ec285-4d0f-4635-a35d-d290fd73ddfa@amd.com>
Date:   Wed, 13 Sep 2023 12:21:23 -0400
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com,
        "smita.koralahallichannabasappa@amd.com" 
        <smita.koralahallichannabasappa@amd.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "rric@kernel.org" <rric@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>
Subject: Re: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on
 guests"
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
        Elliott Mitchell <ehem+xen@m5p.com>
References: <20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com>
 <ZPqQEHXgmak1LMNh@mattapan.m5p.com>
 <20230908035911.GAZPqcD/EjfKZ0ISrZ@fat_crate.local>
 <40d3399a-b260-4ffa-a503-40c61468a189@amd.com>
 <SJ1PR11MB6083BDC4D10D139EF28E0058FCF0A@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <SJ1PR11MB6083BDC4D10D139EF28E0058FCF0A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEhKQVBraGNLcVlybHBZbE0yeFVnNTVKT1ArMVo0d1RGRDNHM3FHVVNBd0pm?=
 =?utf-8?B?aWJmSFIvQWFzb0RwN3JBQ1dvRmJsQlA4SHArL1JZSS9YNXdpb3BCRHRGZk9B?=
 =?utf-8?B?MmM4QVNvZXB0UzdWMnFJSVVuQUNQU2EvQVVUbUdDSTdicURmVlVkOVVxTmtP?=
 =?utf-8?B?bVJQellVUHZqWUV2V2lML2UzRE5DWlhMOFVRQ0cxSGF6L2JOR2FtZnNNWnpT?=
 =?utf-8?B?amdLSUtlTUhKdUJ2YWVJYTlBVkJENlhTN3ROM1dHQjVvYy81TUJ3MUhGSkVs?=
 =?utf-8?B?azJlMTlmRDhuYkNjUGM3OVZJWE5NTXFiaFNiTTBwZkVFNDB4VGZFZDZ1UXN5?=
 =?utf-8?B?bll0SlBtcnYvcFF3QktscC9iMkJrSkRJMk1TeklKcitDeE1QNEF2S1ljWnNn?=
 =?utf-8?B?YmwrT0RFMXR3UW4yM0ZhTHlYMmM1dlVlS3VmSXNNQnFpaEFMRHlmMkI5L3Z6?=
 =?utf-8?B?Qys0OWNrUHF2MDV4ZTU1ZGdOR1RTRmpFYWFMTVVIY1RSZmZiWkt0Qi9Tb2RL?=
 =?utf-8?B?eS92UlZzcW5mY2gzMW9hOTJwUnpEMWRCK2ZnUFZvUlFSL1RwS0RIV2RvTnRL?=
 =?utf-8?B?Uzc0bDdZaURlS3IwamFoOTRGTUdOL2lBYnZLYUlaQUV0dlZsbkNoeEw2UFdz?=
 =?utf-8?B?OFVjZENBK2k4VDRUWWpuWFdNRE5jNzZrTW1hcmltRlhkZHBwTGcvUEwrbmFJ?=
 =?utf-8?B?eXhXdHNBSjk3aWtBL2VtQXFlQUZadW1xNjlnTm9WeUlvc2V2MkJMdDUxS001?=
 =?utf-8?B?Zmx5TEkvaWllNW93Q0k4UFJUOUhMOEtBT2lHK1FYZ0YzVlNBL0ZucFVVU2FB?=
 =?utf-8?B?TEZtenIyaEpaUnFtaGEybEtXYUhFbFFqc1RYRjdVb25rekdYYkM2blg2VERY?=
 =?utf-8?B?NWVZaG56OFBhRnZPOVZYbFZ1VTU5cGdLL0JiSEF5RFd4azI3VVRZZUVMK0t2?=
 =?utf-8?B?VmRCaDYrSmRIbnhSRWQxTk5aUUR5eFV0ZDYzcVdhalVFZzhTZjBMbmp3VU0z?=
 =?utf-8?B?ZHlMS0luUld6U3ArZDREaERTWnJaV0E4V2Z2YmtRNnpTN2lETFJTTkhydXBl?=
 =?utf-8?B?Y0t1cTN1MHJVa28xbHc0K1pXOUFmUkd2dHcrY2FJR0FrbnNLOWFvT0tpSkdP?=
 =?utf-8?B?Q3dmSGRYMmdZVXNYVG5xVkFNSEsyOFhHbHJ0L0RpbUVWcFRPYklZMldpM1A2?=
 =?utf-8?B?Mjlwc01sUUlwem1IWjBFeGpiSnkrWjhzWjBxQ2V6Ui9CNlJUZjZYeVFyeWdE?=
 =?utf-8?B?ckVrT2JNNHduZTVkMmlTTnNpNDFKWGxLSDlObmhxQjRjb1A2NUhmSzZFbmZP?=
 =?utf-8?B?TldoNHlSbXRQaTF5VUVJVlZ5ZHJlSVZadEZQSVpHN2g3eUtiVkVjdjgwUHlU?=
 =?utf-8?B?OGhVempkYnNubzg3TjUreTlQVnBsbU1CbkpVVFFGZzZLRXRjYjYwSjkzM1E3?=
 =?utf-8?B?Wmh4N1ZldmVxZnM5M3ZhTy9FZUFRT2MxcnhiZ2I5elFneEt2QlNGWWJ6VERI?=
 =?utf-8?B?dVNtUDhRZ20rMUIxZUE4VXlsczRHajlySFo1YnZHZVA1Um00dmE5Z05TUTNi?=
 =?utf-8?B?Z1laWlg5WjlyQkhmd1ZRRXNBVTJvSVRiMTNvSDRvNzBVZ2dyaWxmVHNxWnYy?=
 =?utf-8?B?VXdXYkt6MXB0N2wxVzBmQkVBc29WczZWRFJ1TTVZd0pHVkpnRU10SlZ0c251?=
 =?utf-8?B?Q2tKMi8xeVlCSUdzaTlKdVhlZnhSbnQ3R05rNVBOT3U4aGpyZlhLY0ZEcWEv?=
 =?utf-8?B?QllaLzJQc05kcHF3Tm5tYkJzaTRiY0xNVGVVd21OekYwSGlHR0RJTVUwbFVo?=
 =?utf-8?B?dVVlKzBEMnBzUzNDc1N3bFM2YVVVSFN4RDdLRENRdXZISFFJb2FHdWZyMXRs?=
 =?utf-8?B?UEFEZVM4R0p4bnoxd3JOR2hJWFZPbnc1ME5vMUFldGNXQjRaVmNlcXY3eFdH?=
 =?utf-8?B?UDdMMGcybk5KMXFVRXlMSTFSYmY0MXE3VmR5Q1ZqRjYrQVhBSWlYQWQ2THB4?=
 =?utf-8?B?VENMWk1FQVlDTklOd3kvNFQyWnZ0Yzh6Rk0vN0g3VUc3YnI4ekdwZ2FhZ0hB?=
 =?utf-8?B?QmozOGpFRkdhOXR0K3RzTkdJSVVxdS9MZ1doL3FwaThVU3laZngyU1hxV1Qz?=
 =?utf-8?Q?qKhM19IYfkcNZkYsWm+AH6BXR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29c6245f-3876-4d3b-4fae-08dbb4757a5d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 16:21:26.3277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QEOwIid6TlGyo5wKepY4BxOWbaMgOVudwVSb0V7ZEpidXhOjiLivf1Dhy0Copp8InrAojhJ22KyV5bDSBAbPBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9215
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 09:21:35 -0700 (PDT)

On 9/13/23 11:50 AM, Luck, Tony wrote:
>> Also, please note that the EDAC modules don't handle MCE events
>> directly. They act on information passed from the MCE subsystem.
>>
>> Furthermore, there are other EDAC modules that have the same !hypervisor
>> check, so why change only this one?
> 
> The older Intel EDAC drivers translated system physical addresses to DIMM
> addresses by digging around in the CONFIG and MMIO space of the memory
> controller devices. It would seem unwise for a VMM to give access to those
> addresses to a guest (in general ... perhaps OK for a Xen style "DOM0" guest that is
> handling many tasks for the VMM?).
> 
> What system resources do AMD EDAC drivers need access to? Could they
> work inside a guest?
>

The MCE decoder may access some newer MCA registers, or request info
from the MCE subsystem. But this is for informational error decoding. It
won't support any actions that a guest could take.

The AMD64 EDAC module reads system-specific memory controller registers
through non-architectural interfaces. So also unwise or not useful for a
guest to access.

Thanks,
Yazen