Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 13 Sep 2023 22:31:11 +0300
Message-Id: <CVI1FHKRSG47.2CV547I19B9ZT@suppilovahvero>
Cc:     "Yue Haibing" <yuehaibing@huawei.com>, <jmorris@namei.org>,
        <serge@hallyn.com>, <keyrings@vger.kernel.org>,
        <linux-security-module@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 -next] keys: Remove unused extern declarations
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Paul Moore" <paul@paul-moore.com>, <dhowells@redhat.com>
References: <20230729024026.32228-1-yuehaibing@huawei.com>
 <CAHC9VhRW0Jt0pitVx1cw-zJGWfTmvTU4RSmOFKANYJA7CeEF7g@mail.gmail.com>
 <CAHC9VhSisEfQd0KCu7f8yKBwnrduFOPhP2SzWDfXiuvGh2g13A@mail.gmail.com>
In-Reply-To: <CAHC9VhSisEfQd0KCu7f8yKBwnrduFOPhP2SzWDfXiuvGh2g13A@mail.gmail.com>
Precedence: bulk

On Wed Sep 13, 2023 at 9:00 PM EEST, Paul Moore wrote:
> On Mon, Aug 7, 2023 at 5:46=E2=80=AFPM Paul Moore <paul@paul-moore.com> w=
rote:
> > On Fri, Jul 28, 2023 at 10:40=E2=80=AFPM Yue Haibing <yuehaibing@huawei=
.com> wrote:
> > >
> > > From: YueHaibing <yuehaibing@huawei.com>
> > >
> > > Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > > iterate_over_keyring() is never used, so can be removed.
> > >
> > > And commit b5f545c880a2 ("[PATCH] keys: Permit running process to ins=
tantiate keys")
> > > left behind keyring_search_instkey().
> > >
> > > Fixes: b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > > Fixes: b5f545c880a2 ("[PATCH] keys: Permit running process to instant=
iate keys")
> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > > ---
> > > v3: Add Fixes tag
> > > v2: Also remove keyring_search_instkey()
> > > ---
> > >  security/keys/internal.h | 7 -------
> > >  1 file changed, 7 deletions(-)
> >
> > Reviewed-by: Paul Moore <paul@paul-moore.com>
>
> Jarkko or David, please merge this or explain what is wrong with this pat=
ch.

Sorry, I was aiming to pick this, and thanks for reminding.

Applied.

BR, Jarkko