Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 13 Sep 2023 22:54:35 +0300
Message-Id: <CVI1XE98FLQN.1S24GU1DJ89WY@suppilovahvero>
Cc:     "Peter Huewe" <peterhuewe@gmx.de>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        "David Howells" <dhowells@redhat.com>,
        "Mimi Zohar" <zohar@linux.ibm.com>,
        "Justin M . Forbes" <jforbes@fedoraproject.org>,
        <linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <keyrings@vger.kernel.org>
Subject: Re: [GIT PULL] tpmdd changes for v6.6-rc2
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Linus Torvalds" <torvalds@linux-foundation.org>
References: <20230912201102.1012306-1-jarkko@kernel.org>
 <CAHk-=wgLB9_z5TcvRKVsSk3BWPfkDeWN0pDMdEv=-hnrnTgX1Q@mail.gmail.com>
 <CVI1GKA044I2.2A5GRO80ABMNN@suppilovahvero>
 <CAHk-=wiS2rHdPe9qQ4Ahzy6t6hbG18ihsOjBYxn3Nr88yen52A@mail.gmail.com>
In-Reply-To: <CAHk-=wiS2rHdPe9qQ4Ahzy6t6hbG18ihsOjBYxn3Nr88yen52A@mail.gmail.com>
Precedence: bulk

On Wed Sep 13, 2023 at 10:45 PM EEST, Linus Torvalds wrote:
> On Wed, 13 Sept 2023 at 12:32, Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > Ok, I'll make something more reasonable.
>
> Well, I took the pull already, just saying "tpm fix".
>
> I assume the only thing the typo actually causes is printk's with a
> typo in it. Maybe some sysfs name will be wrong?
>
> That's the kind of information I would have _liked_ to see in the
> merge message, but I didn't then delve into just where the class names
> might actually be used.
>
>                Linus

Thanks for pointing this out because I also overlooked the whole fix,
and based my conclusions just "git describe --contains", which pointed
to my previous signed tag.

I actually do QA (both x86 and aarch64 and slowly setting up also riscv)
to my tree, and I did not understand how this could have leaked into a
PR since TPM2 kselftest would have catched that.

The original commit must have gone through some other maintainer tree
since I do not see in any of my PR's. Anyway, I'll document next time
better my PR because apparently not doing that can lead to toally false
conclusions :-)

Thanks for picking it up anyway.

BR, Jarkko