Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20230911170340.699533-1-mge@meta.com> <20230911170340.699533-2-mge@meta.com>
In-Reply-To: <20230911170340.699533-2-mge@meta.com>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Wed, 13 Sep 2023 15:42:32 +0200
Message-ID: <CAMGffE=kWc1rsNfn6n8d1qkYw2U8sz+n5E-GEkWB7=835j=66g@mail.gmail.com>
Subject: Re: [PATCH 2/2] pm80xx: Avoid leaking tags when processing
 OPC_INB_SET_CONTROLLER_CONFIG command
To:     Michal Grzedzicki <mge@meta.com>
Cc:     jinpu.wang@cloud.ionos.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 11, 2023 at 7:03=E2=80=AFPM Michal Grzedzicki <mge@meta.com> wr=
ote:
>
> Tags allocated for OPC_INB_SET_CONTROLLER_CONFIG command need to be freed
> when we receive the response.
>
> Signed-off-by: Michal Grzedzicki <mge@meta.com>
can you please add the fixes tag, so stable can pick it accordingly?
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80x=
x_hwi.c
> index 1b2c40b1381c..3afd9443c425 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -3671,10 +3671,12 @@ static int mpi_set_controller_config_resp(struct =
pm8001_hba_info *pm8001_ha,
>                         (struct set_ctrl_cfg_resp *)(piomb + 4);
>         u32 status =3D le32_to_cpu(pPayload->status);
>         u32 err_qlfr_pgcd =3D le32_to_cpu(pPayload->err_qlfr_pgcd);
> +       u32 tag =3D le32_to_cpu(pPayload->tag);
>
>         pm8001_dbg(pm8001_ha, MSG,
>                    "SET CONTROLLER RESP: status 0x%x qlfr_pgcd 0x%x\n",
>                    status, err_qlfr_pgcd);
> +       pm8001_tag_free(pm8001_ha, tag);
>
>         return 0;
>  }
> --
> 2.34.1
>