Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3479598rdb; Wed, 13 Sep 2023 13:22:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/OIJTFUIRamM+uEl5DM2BcKU/4ULYZULcjLNCQEV9oRjkAIm/DoO2Z1Bb7xpmKoL5+0Gm X-Received: by 2002:a17:902:ed11:b0:1b8:a88c:4dc6 with SMTP id b17-20020a170902ed1100b001b8a88c4dc6mr3533421pld.45.1694636532283; Wed, 13 Sep 2023 13:22:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694636532; cv=none; d=google.com; s=arc-20160816; b=tR15xNk/EwwWd7uegZO1bHJgciGuj9+jyFdR3SHnnnUgCyfyfC/jIO4BlmYb1pIXDo xREFIku6WpbCGX+9hNtpRKwzMTDEDlEP+C7s3x1Q+H4MfKZqyz8e+zW+aYF5+LgjRipy MrCidJrVHsAUhhDSes6oVUA0Te3ilCJ+LKuQr4bhVJh8RlHo3pyTW+a9ZPhFamD1VriZ LTXl+4Aa43EZZ0UA/13jtdEHoktWPBWwKJv/gAxvbe50VSDaRopbyZnVvGX1py5tpocP 4UEEFgshTr6vox8TguuWC4dXdDWhRhCgXjrnD7tYoWxdDC196mPbAsTJNcvELU2Uqxto n0RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pAjwj3vFJAui/OGA0IHuJXUUcCG/qk5wDLNVjB5au/s=; fh=Pd5V9naZov6l7lhNjTVdlaR5LT69w7REm4ENR5gtR7I=; b=K2TtC6T9PfzVRB/wcwKM0GDqwOA2Je05D0YfqANrreec2K1tjT/yLkc/GiEmHzAKwS Z5vTGR7EBECcprC8fni3IbEmYcvz5dmsDxhSlqlKozUrVQTQl44/duiLZ6QoY212pd+i A5N+0cdwd6ZQyDCF+ZeEpaRCW9X//IV8qtLCnwbFRL1PNbAUi5frsE+VnJHqD8Xkm5My VdEhlMTmKgKMCTGOBG6rrfX/3o0ZnOLuWn1abg3nlLJbLh6E5xjDfFzoLK1JtohYENeU f8wFWh7NkaIsaGT2oz6abEyVQtcIDRdthgRBYpX1ZrwaSwYccXJkNWCE7qU1JDRVtD5t A+Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=18+d0PIp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id m18-20020a170902c45200b001b4fc117bf0si70738plm.116.2023.09.13.13.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 13:22:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=18+d0PIp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9DFB5804C645; Wed, 13 Sep 2023 02:18:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233737AbjIMJR5 (ORCPT + 99 others); Wed, 13 Sep 2023 05:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbjIMJR4 (ORCPT ); Wed, 13 Sep 2023 05:17:56 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE4E31999 for ; Wed, 13 Sep 2023 02:17:51 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-401bbfc05fcso72352715e9.3 for ; Wed, 13 Sep 2023 02:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1694596670; x=1695201470; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pAjwj3vFJAui/OGA0IHuJXUUcCG/qk5wDLNVjB5au/s=; b=18+d0PIpCYfc4xrPlb6/2mgS+3+jK2Ue8dFX6/LDI5x17PaCpmMvi9N2UJ0s+g7kAC XuhCMqKbzFqelftL9VT8dSYNxaH8Ec/nL02krxzI1Y2g8vw3oVvOhUOf4Bn/25ttbNka CUgn6eQP71Ib9NiYSE6Bfhj87SP0PuTBfZgPrKOXf1h3GhWSdJBj42CSCFmTFAcvN94F naQKNFECoQbWglKsjDBveMr2cDmL2rV6AQcwwKKf6SvgHchr7Io85wAtD3YhkJSGVXLu n/g7TfX4SsRv9TWUjV2EfvHdVpRTEOtV1STIA4c8d2oPA+dMGIal6fJQVSSglqZZSVnn c5HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694596670; x=1695201470; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pAjwj3vFJAui/OGA0IHuJXUUcCG/qk5wDLNVjB5au/s=; b=afz+S9yBgWL9+teh3INy480KVmnlBhjT4jSPKWKDoWHylNlrEyhB+ilox5k5JhfjXT IHIGx12/eqiXcB+k7NlqusnRFq74v+ygyhjRXbda60uAQ5Id/8v2QL88H8EIE2RQgOen dTx2auMK+IVgV7/v8EJx0Ibap41O/0SLVHDIK+M//hGmduI5OMj3tOlFXUblY51IrLHx +h0xxDyibi5fzE7WK7vGeLD7jZEdaMD0zIGVCPV+6VkfOeDNPPSR3gonHlk81yYLD3dJ d2ZJD+mSj7nQsspYEQC2VW/bBAk4kX8QwexoOwrPv6nOvujlaUXcDWXngQDZVcg2xcsd QTnQ== X-Gm-Message-State: AOJu0YxYb6qLZxOAdmSg8pfehS5r5l+k8rTcDDQAVUJeEevtq1MLrR7E JeWPAVMT6Z7xNosiuwQqBI4PuQ== X-Received: by 2002:a05:600c:2212:b0:401:b2c7:349b with SMTP id z18-20020a05600c221200b00401b2c7349bmr1553594wml.7.1694596670178; Wed, 13 Sep 2023 02:17:50 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id m13-20020a7bca4d000000b003fe4548188bsm1450437wml.48.2023.09.13.02.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 02:17:49 -0700 (PDT) Date: Wed, 13 Sep 2023 11:17:48 +0200 From: Jiri Pirko To: Jinjian Song Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net, loic.poulain@linaro.org, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, nmarupaka@google.com, vsankar@lenovo.com, danielwinkler@google.com Subject: Re: [net-next v4 0/5] net: wwan: t7xx: fw flashing & coredump support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Sep 2023 02:18:00 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Tue, Sep 12, 2023 at 11:48:40AM CEST, songjinjian@hotmail.com wrote: >Adds support for t7xx wwan device firmware flashing & coredump collection >using devlink. I don't believe that use of devlink is correct here. It seems like a misfit. IIUC, what you need is to communicate with the modem. Basically a communication channel to modem. The other wwan drivers implement these channels in _ctrl.c files, using multiple protocols. Why can't you do something similar and let devlink out of this please? Until you put in arguments why you really need devlink and why is it a good fit, I'm against this. Please don't send any other versions of this patchset that use devlink. NACK.