Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3492474rdb; Wed, 13 Sep 2023 13:51:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGww0zK7fw7vFhUNZW99356eMVbYsTiuhwjAqhLvbL4UUISVzCJwVUcVtUjzItwJsTwNnL0 X-Received: by 2002:a05:6a20:1607:b0:133:38cb:2b93 with SMTP id l7-20020a056a20160700b0013338cb2b93mr5438178pzj.9.1694638264202; Wed, 13 Sep 2023 13:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694638264; cv=none; d=google.com; s=arc-20160816; b=Fp6zUyns/zPFGtSn3KgNAqBL/mp3P9+EJSYeU9R5yzGW7vBSnm1BrNIULX39v/DcKu 0PiN5C8tRhXlvtNls6ni7dzDeTmTiYllBkxRGgyUwYBgl9srIEIus74vhzin9XAK8cak ZvpdtEiCww1DouNxmwKJqxhWM5WkNWZ9y6ZMgwRtNFyF0tEvplaKzonFEMLvmUObd+K/ CnlmTEPrnoOMxUxurOJeUgbdnGLzilk0TPOqGn2g079KIoDfsvRyD8HsCVKhLX1dX3Cj dkYOWR75KaRkGDs61YBwMWoda7Ea7VGtcVyY7q0mvge1ZIW42xJTRXO7fjScUwtA/qpx QeHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=22ok7B2PvqkfYpwpJ7o1ydqnVK288ID8TPWPyMwUpkc=; fh=30+N3zdL5NoLMEOkS7YR7cRsHcwXGQLvdIWisPtAQjo=; b=DiH3c4o3E2AijLzsjQeeNvJaqYWIbkFwNLyQdfFs7boYvDpdkV9zCB9YLSTASNIQVh F6NSJIA2M3cdKocb/5cC+Abl2O2of2ARc3DuPzPR68PdQDiDTMSdMalfAJwqXZRsL1we d9v8nO/Cn8LbqIfo1hl3crwoBpXIjVX8XtjAymaCP6Am6arolC4CqxufnMHCuPMUhqJi NNcr2JYFyi44/Pb80ng+2esO8wOf0s5R/83wz7fKKEt2kqpUpewupx8STGuSuR09Pyip MOU2WI6+4g2/LJqt3hJpYRd5oPETgx42rlxBgCQHe1OJhEjvfUUFzopW+/5dx2Ms+cUe URnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=WQtwkF0o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id x5-20020a63fe45000000b0056fa1bc208esi10831535pgj.722.2023.09.13.13.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 13:51:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=WQtwkF0o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 404478086525; Wed, 13 Sep 2023 08:56:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbjIMP4j (ORCPT + 99 others); Wed, 13 Sep 2023 11:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbjIMP4f (ORCPT ); Wed, 13 Sep 2023 11:56:35 -0400 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18FD119BB for ; Wed, 13 Sep 2023 08:56:31 -0700 (PDT) Received: from pps.filterd (m0109332.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38DEk1Z4030010 for ; Wed, 13 Sep 2023 08:56:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=s2048-2021-q4; bh=22ok7B2PvqkfYpwpJ7o1ydqnVK288ID8TPWPyMwUpkc=; b=WQtwkF0oDXlT2fcSv0kWupviemeqjGr5Y331rfPJy0R6pXn0fq0WGzeA2ixvDemcRsbI M5zKkDXvCsU7QpBiz2EI3S9F4H6aUfsFN0EZfzw4tEKV9BTg1JNeN5uuiSzG/A3+RlGC juAMWbnogCYOidIsFujVpUuoMVFWDL42ac7a0suW5ED/JqzZya2cbT/hXfoTLoaQSC2U a0omo5uy9tdbp/NS44CVrWTwG710J02HgxgBxvochxqg8q8s+4INHb/o18wTdCM9oLTa tSrBqavmB4X0T5ThBQktj3cuM+ixjUXNka47sVP+j+9Fp+3T5jCGbc6kwgOpJyBWPRY3 uQ== Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3t2y8thcpm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 13 Sep 2023 08:56:30 -0700 Received: from twshared24695.38.frc1.facebook.com (2620:10d:c0a8:1b::2d) by mail.thefacebook.com (2620:10d:c0a8:83::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 13 Sep 2023 08:56:29 -0700 Received: by devvm715.rva0.facebook.com (Postfix, from userid 240176) id 7EDD52954BBFD; Wed, 13 Sep 2023 08:56:27 -0700 (PDT) From: Michal Grzedzicki To: Michal Grzedzicki CC: , , , , , Jack Wang Subject: [PATCH v2 1/2] pm80xx: Use phy specific sas address when sending PHY_START command Date: Wed, 13 Sep 2023 08:56:10 -0700 Message-ID: <20230913155611.3183612-1-mge@meta.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: k8CN-VpHXw8kupVN6c3fDidXT3m3rIuQ X-Proofpoint-ORIG-GUID: k8CN-VpHXw8kupVN6c3fDidXT3m3rIuQ Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-13_10,2023-09-13_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Sep 2023 08:56:42 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Some cards have more than one sas addresses. Using incorrect address causes communication issues with some devices like expanders. Closes: https://lore.kernel.org/linux-kernel/A57AEA84-5CA0-403E-8053-106033= C73C70@fb.com/ Signed-off-by: Michal Grzedzicki Acked-by: Jack Wang --- Changes in v2: add Closes tag drivers/scsi/pm8001/pm8001_hwi.c | 2 +- drivers/scsi/pm8001/pm80xx_hwi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_= hwi.c index 33053db5a713..90069c7b1642 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -4180,7 +4180,7 @@ pm8001_chip_phy_start_req(struct pm8001_hba_info *pm8= 001_ha, u8 phy_id) payload.sas_identify.dev_type =3D SAS_END_DEVICE; payload.sas_identify.initiator_bits =3D SAS_PROTOCOL_ALL; memcpy(payload.sas_identify.sas_addr, - pm8001_ha->sas_addr, SAS_ADDR_SIZE); + &pm8001_ha->phy[phy_id].dev_sas_addr, SAS_ADDR_SIZE); payload.sas_identify.phy_id =3D phy_id; =20 return pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload, diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_= hwi.c index f6857632dc7c..1b2c40b1381c 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -4671,7 +4671,7 @@ pm80xx_chip_phy_start_req(struct pm8001_hba_info *pm8= 001_ha, u8 phy_id) payload.sas_identify.dev_type =3D SAS_END_DEVICE; payload.sas_identify.initiator_bits =3D SAS_PROTOCOL_ALL; memcpy(payload.sas_identify.sas_addr, - &pm8001_ha->sas_addr, SAS_ADDR_SIZE); + &pm8001_ha->phy[phy_id].dev_sas_addr, SAS_ADDR_SIZE); payload.sas_identify.phy_id =3D phy_id; =20 return pm8001_mpi_build_cmd(pm8001_ha, 0, opcode, &payload, --=20 2.34.1