Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   wangweidong.a@awinic.com
To:     krzysztof.kozlowski@linaro.org
Cc:     13916275206@139.com, alsa-devel@alsa-project.org, arnd@arndb.de,
        broonie@kernel.org, ckeepax@opensource.cirrus.com,
        colin.i.king@gmail.com, conor+dt@kernel.org,
        devicetree@vger.kernel.org, fido_max@inbox.ru,
        harshit.m.mogalapalli@oracle.com, herve.codina@bootlin.com,
        krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
        linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
        liweilei@awinic.com, perex@perex.cz, povik+lin@cutebit.org,
        rf@opensource.cirrus.com, robh+dt@kernel.org, ryans.lee@analog.com,
        sebastian.reichel@collabora.com, shumingf@realtek.com,
        tiwai@suse.com, trix@redhat.com, wangweidong.a@awinic.com,
        yijiangtao@awinic.com
Subject: Re: [PATCH V2 1/5] ASoC: dt-bindings: Adds properties to "awinic,aw88395"
Date:   Wed, 13 Sep 2023 16:03:10 +0800
Message-ID: <20230913080310.364486-1-wangweidong.a@awinic.com>
In-Reply-To: <cc6ad994-a3c3-03d6-6095-14e43f105314@linaro.org>
References: <cc6ad994-a3c3-03d6-6095-14e43f105314@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thank you very much for your review, but I have a question that I would lik=
e to consult=0D
=0D
On 13/09/2023 09:03, krzysztof.kozlowski@linaro.org wrote:=0D
> On 12/09/2023 08:58, wangweidong.a@awinic.com wrote:=0D
>> From: Weidong Wang <wangweidong.a@awinic.com>=0D
>> =0D
>> Adds properties to "awinic,aw88395" to make files more complete=0D
>> =0D
>> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>=0D
>> ---=0D
>>  .../bindings/sound/awinic,aw88395.yaml        | 19 +++++++++++++++++++=
=0D
>>  1 file changed, 19 insertions(+)=0D
>> =0D
>> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml=
 b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml=0D
>> index 4051c2538caf..4965aa4a5370 100644=0D
>> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml=0D
>> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml=0D
>> @@ -32,11 +32,28 @@ properties:=0D
>>    reset-gpios:=0D
>>     maxItems: 1=0D
>>  =0D
>> +  awinic,audio-channel:=0D
>> +    description:=0D
>> +      It is used to distinguish multiple PA devices, so that different=
=0D
>> +      configurations can be loaded to different PA devices=0D
>> +    $ref: /schemas/types.yaml#/definitions/uint32=0D
>> +    minimum: 0=0D
>> +    maximum: 7=0D
>> +=0D
>> +  awinic,sync-flag:=0D
>> +    description:=0D
>> +      Flag bit used to keep the phase synchronized in the case of multi=
ple PA=0D
>> +    $ref: /schemas/types.yaml#/definitions/uint32=0D
=0D
> Looks like bool, not uint32. If you made it uint32 for some future=0D
> purpose, then the name "flag" is misleading and anyway what would be the=
=0D
> third option here for sync?=0D
=0D
Thank you very much. Can I Change it to "$ref: /schemas/types.yaml#/definit=
ions/bool"?=0D
=0D
Best regards,=0D
Weidong Wang=