Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <b9260a50-7b60-4a2a-4e8c-61ec4401576b@intel.com>
Date:   Wed, 13 Sep 2023 08:35:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH] dax: refactor deprecated strncpy
To:     Justin Stitt <justinstitt@google.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>
CC:     <nvdimm@lists.linux.dev>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
References: <20230913-strncpy-drivers-dax-bus-c-v1-1-bee91f20825b@google.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230913-strncpy-drivers-dax-bus-c-v1-1-bee91f20825b@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGwzdVR1SlJLMm91WFVjQVk1NkZ3eDM0REdsRGZZRUsxR3BmUWpRSDU4dGF5?=
 =?utf-8?B?ZS9pTUlXb2ZNcm5IZGFMYnZobHVWWnRNNUVJeTFQY0RIaVRyV25DSmJQQlkw?=
 =?utf-8?B?VHRZSWE1ZlpVRmFsYmNzUW5RV1I5TjBxdldFZGhPN1hxMW1YTXltaml5N1Js?=
 =?utf-8?B?dERZOWRhQS9HUGhhaWd2ZE5uMWQ4U0gxT3dGcGFuZmRuVldWU05nYjgrVm9V?=
 =?utf-8?B?d1dFVDBtOENtb3NucG4waWo3ZWtuM2JabDJsRG80YlMwSk1Qb3lRbHpwdkgr?=
 =?utf-8?B?M1RWM1drZE8rR0c5VFhaQWNmMUJNbTdsN21xYU5ib3hNNEJHSitGQmF1S2hs?=
 =?utf-8?B?WHRRQS9CT08zdWhtSTFheThFWW42VXhSZlpiZjVLaUhnclJSYzF3aEFJeHk5?=
 =?utf-8?B?K0dRMFJlVG9keG8wTXNlSWVDdnFiWm5vcFg3VGFPS3dZaXVsWGFpS0JMMFI1?=
 =?utf-8?B?dDdCVkFEV1hjSGNiNVM2b0l4NS9kZ3I1Yk01WXBVN3R3dGZJOTZ1OHBlY1py?=
 =?utf-8?B?ZS94Nk1lOU5nbDB1MlEvNnZEU1JmWWx5STh0TGJ1aUdMM29VTGgzQloxcndK?=
 =?utf-8?B?dXZ5WkdQb2V2MU5EZVdBNXFKYlBLTkgxQ0c2QXdDWHJjeFY4UzIrYzJJRlRw?=
 =?utf-8?B?ZU1ZV055a0dWMDRsc0tuWFNGRmhHbkQxVXZzZG5xMy9pbm45ajNGM2NDT3BE?=
 =?utf-8?B?RU5NNjU5aWpYdFhENU1iVTR3S2xzcGNPN0h5eTFtSFdkWWhjaW1SMUV2Znlw?=
 =?utf-8?B?Q2hPZm9WZDU1OU9EMXdXdjV5V1h4dm0yQXY3am1TWkRSUklBai9ycXpnT2NR?=
 =?utf-8?B?UmVVUVFQNWYrdnlpZTNNb0w3anpTSEs2cHJYeUpTa1E3S1BMK3hnZGtGYVVY?=
 =?utf-8?B?MEFYdi9CbVZFK203NHlWSjVWSHQ0WVJiTGJybDlES25LTVJFTDNMUFRWbTY0?=
 =?utf-8?B?eDRKWFhhWmRvdmVJdDhYbFd3a2ZVWW1IVGFWMkdpRkh6b2lHV2I4azliTVlk?=
 =?utf-8?B?bW85MVFkQU9tNkhGTktPbGhzeWR1NTEyWHdHdWpEcG1iWlJSM2hBM0NmMFp5?=
 =?utf-8?B?aEp3ZlBDSWZudHNLRlA3TTNtcGJwZUlyN2xLbS8zWTFuY0QyU2JXQ1VTWFBa?=
 =?utf-8?B?UHp2TW1IbnA1OFF5UUZHT24vVm1mZmdMSi9ybEc5SHRwZXJwSnJTN2U4MW9P?=
 =?utf-8?B?SUxJVmFyU1Z5QTJQKzBKNlVJaGpWVG81clQyVWcwdXpZQjZaSWxDODJrRGtW?=
 =?utf-8?B?dmpKZWUrOVhLdlpCWFhFV2RHTXV3TlUvaXZRVG8zT3N5aVpTRFppM2xpTFFZ?=
 =?utf-8?B?NHJRMEVzNXIwdHE2dXVsSXhqL0s2QWF6cWJ2WFpYWFZ2T2tRSzRKcjZYUWh1?=
 =?utf-8?B?STNUSW9nUmZLM1AzOWxtOURRRmswWmtCVGZ2a2ZCeUhnZWZpNStXc0w4YldE?=
 =?utf-8?B?T3ArVEtFTkVoa1ZHemM5WkhUcTJacEk4bzdwMVI2QzRNdHZoY0I4UmQrSFhD?=
 =?utf-8?B?NzQ3M3BDeUxyUUJ4a0dSb2JPTDVvUVRtYXV4Vnl4endFNEhOS2RubVdZSGVH?=
 =?utf-8?B?UDJzaFpyOE5aUGxteXE5N1JhZTJkYmJYUzZCa0g5Tkd1WWQ3cEFrUXpEc3d2?=
 =?utf-8?B?eXN0SFkrajRzRHBnd0Fzc3cxcjQwVWRsRXpzYWZDd3JScExsUzFmSWtjYVlP?=
 =?utf-8?B?SGFFMkZpaytNMk9EOEZyRnArbnBpblZneDFZVDlrZGdmbXVaUHVMZGw5UUVT?=
 =?utf-8?B?UlBlQklyNTRuOXlnQTB0L0ZhWVJWUG5UMFZRS2tXMisyVUE3SjdsclZ4U3dJ?=
 =?utf-8?B?WUhPR0laVzRHd3hvcFlQSndBdSt1Y01MSDZsSzVVcmdVblltRlhGdTNyS2o4?=
 =?utf-8?B?ZVV3R0tka3ZSMVJVRzAvNFc0bzBPb2NlV0RDZnFjaWlnQm94L1BTaTJCNkpC?=
 =?utf-8?B?WklHOFRyV0toYm0rZHhGUmhSUERuYkJGcnI1ZGZ6V1llNnFvMjAzK1U3UHdM?=
 =?utf-8?B?RjhsSFNzRkdqMDd4bEsweGFXcFlJUEhZZ0ZPOFdHSWhYaVNTejZodW9YcDNR?=
 =?utf-8?B?TEl4SUxLdEl6RkdHcVA2cG9HMHVlR0VEOFhqN2lOTWIxb0JMNWkvcGc4bDBX?=
 =?utf-8?B?TGNxcTF2Rkwrc0VmU053YUU2UGE0Q2ZCTnpJZWd3SVI5RTg4SE5jNXpXcGJm?=
 =?utf-8?B?Z2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d1477c4-bc63-4447-39a2-08dbb46f04f3
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 15:35:12.3428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0OCdO9KwEP06GxU8kjVo9+N7r/3hI75omxVCFHJRkO8TSfBpzM+uswZGLx/Xfmoy9wHJbspuM///AxzgJ3D6kQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6033
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Sep 2023 08:36:10 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email


On 9/12/23 18:10, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
> 
> We should prefer more robust and less ambiguous string interfaces.
> 
> `dax_id->dev_name` is expected to be NUL-terminated and has been zero-allocated.
> 
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on the destination buffer. Moreover, due to
> `dax_id` being zero-allocated the padding behavior of `strncpy` is not
> needed and a simple 1:1 replacement of strncpy -> strscpy should
> suffice.
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> Note: build-tested only.
> ---
>  drivers/dax/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 0ee96e6fc426..1659b787b65f 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -103,7 +103,7 @@ static ssize_t do_id_store(struct device_driver *drv, const char *buf,
>  		if (action == ID_ADD) {
>  			dax_id = kzalloc(sizeof(*dax_id), GFP_KERNEL);
>  			if (dax_id) {
> -				strncpy(dax_id->dev_name, buf, DAX_NAME_LEN);
> +				strscpy(dax_id->dev_name, buf, DAX_NAME_LEN);
>  				list_add(&dax_id->list, &dax_drv->ids);
>  			} else
>  				rc = -ENOMEM;
> 
> ---
> base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
> change-id: 20230913-strncpy-drivers-dax-bus-c-f12e3153e44b
> 
> Best regards,
> --
> Justin Stitt <justinstitt@google.com>
>