Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 13 Sep 2023 22:23:38 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Harvey Hunt <harveyhuntnexus@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Daniel Scally <djrscally@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/5] mtd: rawnand: ingenic: use gpiod_set_active_high()
Message-ID: <20230913222338.07d1625b@xps-13>
In-Reply-To: <CACRpkdYtYDJa6fo6RnizHNzUsyazBQxEaNMznaij8rBF4ie+ew@mail.gmail.com>
References: <20230913115001.23183-1-brgl@bgdev.pl>
        <20230913115001.23183-3-brgl@bgdev.pl>
        <CAHp75Ve8aK4Pfid1JYWH86mKy-Zb-G2QDPrJYmRzPCYOsn1TqQ@mail.gmail.com>
        <CACRpkdYtYDJa6fo6RnizHNzUsyazBQxEaNMznaij8rBF4ie+ew@mail.gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andy,

linus.walleij@linaro.org wrote on Wed, 13 Sep 2023 22:12:40 +0200:

> On Wed, Sep 13, 2023 at 10:05=E2=80=AFPM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Sep 13, 2023 at 2:50=E2=80=AFPM Bartosz Golaszewski <brgl@bgdev=
.pl> wrote: =20
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Use the new, less cumbersome interface for setting the GPIO as
> > > active-high that doesn't require first checking the current state. =20
> >
> > ...
> > =20
> > >          * here for older DTs so we can re-use the generic nand_gpio_=
waitrdy()
> > >          * helper, and be consistent with what other drivers do.
> > >          */
> > > -       if (of_machine_is_compatible("qi,lb60") &&
> > > -           gpiod_is_active_low(nand->busy_gpio))
> > > -               gpiod_toggle_active_low(nand->busy_gpio);
> > > +       if (of_machine_is_compatible("qi,lb60"))
> > > +               gpiod_set_active_high(nand->busy_gpio); =20
> >
> > Why not moving this quirk to gpiolib-of.c? =20
>=20
> That's a better idea here I think, it's clearly a quirk for a
> buggy device tree.

Agreed, it's just for backward compatibility purposes in a single
driver. I believe it should stay here.

Thanks,
Miqu=C3=A8l