Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <140e7f79-4e03-47ec-99de-90871ca8d445@infradead.org>
Date:   Wed, 13 Sep 2023 10:12:44 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pinctrl: nuvoton: Fix up Kconfig deps
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Tomer Maimon <tmaimon77@gmail.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230913-novoton-kconfig-v1-1-1c2dff14c0d2@linaro.org>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230913-novoton-kconfig-v1-1-1c2dff14c0d2@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/13/23 01:50, Linus Walleij wrote:
> We have build errors due to missing dependency on OF.
> Add the dependency and do it the same way for all three
> Nuvotons while we are at it.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Works for me. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  drivers/pinctrl/nuvoton/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 612e7ba02238..2abbfcec1fae 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -2,8 +2,7 @@
>  
>  config PINCTRL_WPCM450
>  	tristate "Pinctrl and GPIO driver for Nuvoton WPCM450"
> -	depends on ARCH_WPCM450 || COMPILE_TEST
> -	depends on OF
> +	depends on (ARCH_WPCM450 || COMPILE_TEST) && OF
>  	select PINMUX
>  	select PINCONF
>  	select GENERIC_PINCONF
> @@ -35,7 +34,7 @@ config PINCTRL_NPCM7XX
>  
>  config PINCTRL_NPCM8XX
>  	tristate "Pinctrl and GPIO driver for Nuvoton NPCM8XX"
> -	depends on ARCH_NPCM || COMPILE_TEST
> +	depends on (ARCH_NPCM || COMPILE_TEST) && OF
>  	select PINMUX
>  	select PINCONF
>  	select GENERIC_PINCONF
> 
> ---
> base-commit: c9336ebe87e77f92ed04a86c0131a0310d0e200d
> change-id: 20230913-novoton-kconfig-895c60755500
> 
> Best regards,

-- 
~Randy