Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 13 Sep 2023 12:32:22 +0200
From:   Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To:     Yu Kuai <yukuai1@huaweicloud.com>
Cc:     song@kernel.org, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
        yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH -next] md: simplify md_seq_ops
Message-ID: <20230913123222.00006a8e@linux.intel.com>
In-Reply-To: <b2754d8e-dfe7-ffff-66ac-052f366530e4@huaweicloud.com>
References: <20230911065010.3530461-1-yukuai1@huaweicloud.com>
        <20230911160540.0000060e@linux.intel.com>
        <b2754d8e-dfe7-ffff-66ac-052f366530e4@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 12 Sep 2023 09:02:19 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:

> >> +static void *md_seq_next(struct seq_file *seq, void *v, loff_t *pos)
> >> +{
> >> +	return seq_list_next(v, &all_mddevs, pos);
> >> +}  
> > Can it be so simple? Why previous versions takes care of holding "(void)*1"
> > and "(void)*2" then? Could you elaborate?  
> 
> "1" means printing "Personalities", which is now moved to md_seq_start,
> and "2" means printing "unsed devices" which is now moved to
> md_seq_stop. And now md_seq_next is only used to iterate the mddev list.
> 

Ok, LGTM.

Mariusz