Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <6d6dba28-a7f0-1f49-3f59-4e0026d0c2b8@intel.com>
Date:   Wed, 13 Sep 2023 11:49:19 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH RESEND v3 1/2] selftests/resctrl: Fix schemata write error
 check
Content-Language: en-US
To:     =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
References: <cover.1693575451.git.maciej.wieczor-retman@intel.com>
 <960b5302cee8e5bb0e83dcf20cd2ef4d353b7b0b.1693575451.git.maciej.wieczor-retman@intel.com>
 <99eabc5c-f5e3-27dd-0a29-ad0cdb7b4239@intel.com>
 <sr6ana6d7ebtuxbhjuo6kcnhnn2zzvg3ivve6mndqeb3nxrzo7@mrfmtzlxlwdh>
 <a7f0dfb9-c841-b240-fca9-b908517a44d0@intel.com>
 <jyxp5mspjn7xbmclj5sumbsuwd424fqmdvntiiuq24tiz5yqb4@qunho7whbamf>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <jyxp5mspjn7xbmclj5sumbsuwd424fqmdvntiiuq24tiz5yqb4@qunho7whbamf>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFpxNTVoMERPbFQybEoyUlEyMjZQWWVZOWxWZEJNcDV1Q005dUpmZFpwTG1v?=
 =?utf-8?B?NHVjSjZDUnhrZ0FVM2lVUjlNbitkLzhPeDFLU1ovOWtKdWszbGhDbENDN0Zh?=
 =?utf-8?B?azlCUzgxYkcyVkZOb2Y1U0ZrZUw3ME5ndGFpbFdZNm8rWmpLQWd5ci9WTVg1?=
 =?utf-8?B?endYRTJ0TEZBcW9vbkZoM0lpZlZnV3hzRlpNYTdOZzBMQ1JyZUdKeHBBai90?=
 =?utf-8?B?TkdxbGJmRGNDS1lHWk9pY2lUS2ZPMWIvTlh3TnlBYWw1TnJvbktrdVVGSGdO?=
 =?utf-8?B?dnNmRG0vY3lqNFJxYTlOdzJFU3dBeW8xNkNFMUlyNnFjSWFVRzVmaG0yQ0gx?=
 =?utf-8?B?SUZKNExjWkhDSHRxM1BUUHM5ZjJPbWRjeXJSV000MjZRMER6REJjcng2ZG1V?=
 =?utf-8?B?UFNDb2pMREU5NitzNndVTXNVdEFWc0N0ZHlsRjQwNW9uT0xIcTRRd1VBc0Vn?=
 =?utf-8?B?eDR4aTZJOVI3bkpFdUFzN09RRndncUlHZjQ3OHhVZ3U3K3lpS2J2SmNyZEVU?=
 =?utf-8?B?b1hSam8rY2phUGh6MHNQU2Q1NzhFa004bDExcExKR21JOFJud1o1Snk3ZzZP?=
 =?utf-8?B?QjZuMEtWYjR4RFRsSU5RMlVJbm90Z2FJODhwMDdBZU5pTEU4NFoxZVR0cnYw?=
 =?utf-8?B?aitOVHduMk4xRXhyK2VnbUMySEs3T1htZ1BwcVlPV0hxRnkzOWxmQnZvRzhQ?=
 =?utf-8?B?SkZra2Rwb1NIblBHNEg5bkwzeG1XMTNaRjlhaG9YQ21SL1BPc3E1clhRQ0hv?=
 =?utf-8?B?UHFrRjJSRU4xTVlDeGkyQjF3R1Z2YXg0eXl4QjZjcTZjVmFjYVl0Ly92Z0xx?=
 =?utf-8?B?TlRIbWtETzdYN284NEgwaG43MXpzNTR2VTJhbHA1YUxHMzIydFVVL1hCd2U4?=
 =?utf-8?B?T2pMZyt3U2xCRkZlN094M3JKbFMxVjZvZmdmQmhMSUJDblh5VWRpY0RlbWUy?=
 =?utf-8?B?bmYrMGw3M3h5QUh5b2U1Y1VtT1BDTXBPajUyOVlDb0Y3d1E0VXJBMGdVck96?=
 =?utf-8?B?VkRpd0tDUEpFelNLQTJkZlpoUUJnaitlWjJ2aTlLb1ZsMDFkZEZwQldOdHBl?=
 =?utf-8?B?L3NkT2xTRThyZlZDcEw2cGQwOFVWcW95YVdQbVNGRHFldzQ1OXJaZVU0cmhh?=
 =?utf-8?B?QldlWEoxZVBjdVlmNlBnNjBJZEIzUVNaYmFOMUxrYzIxVlkzMzl0MDZacWh1?=
 =?utf-8?B?Rk5wZHU5MlJBcldOMzZoekxHL1J6NVJQZTJKVEt0NWxRTERmRlA0Rk1KSDZC?=
 =?utf-8?B?WDh4VXZGaGUxSHZJVEM5M3M0T3ZyamtCZ3kwbm1qUGFWYXdWUk1vd1hwVnYr?=
 =?utf-8?B?TExjWVgrY1RCT003aXhrYmpzY0E3NHcxWGZSc1hLa2grTHhNZmY5WGcxaElR?=
 =?utf-8?B?cjNCeENOR3BKeU5qbXV3K0F6Vk9vb0oyNWlPV0tnbWw2dHYrVThKMExuQVdx?=
 =?utf-8?B?MmtyY0VkOGdxNkhSeFFUMmR3T08vLzBydUo2ZXR2dUhOVWhXN3VvNjFScVNz?=
 =?utf-8?B?bXFiVkFQVUFCZjI0aGpiRjZqZFIva2c1Z1VQRHFIRXZOdDdSeUFPR0ZDck5Y?=
 =?utf-8?B?UVlEd0Z4N1RJcCtFaDZZNEx4MjY3cWtWMDJ6MUUzWE5taXFwUklnUkpSK0Nw?=
 =?utf-8?B?eW5UZXdLdjVleERoQ0t2azM3ZmF6WnFkMDJDRnZ6NW9qeENVcnJ6NUFsNzZL?=
 =?utf-8?B?eDlZekMxOEdsTEZLOVA5cEp1dThwUE56Y2NTRktsNFlnUDVZbUJtUUowV2ZW?=
 =?utf-8?B?OXpwYUxremJ1eWxFY3grRTh4ZmxvSCtYQU05VDdzMmZkbDFUdDVuOWF1TmVU?=
 =?utf-8?B?UG5zM0ZHR1I2ZE1nU1FtN3lqKzJsY0NLRUtMMG1WZEJFTnZKMXJsN0dPK3Fq?=
 =?utf-8?B?TkR5OXJndXViRUFEVFV6aVdUSjcvRE9pVmtic2xITHNHV01pT2RtRUNDTG5h?=
 =?utf-8?B?YUg3S3BJQXV3NDJyZkdTcXRDRXpwQjI1eTNaaE9jK01JeGpCZ0NPUFpvNjdG?=
 =?utf-8?B?b3l4TEovQXJ4Z1ZjQ1FWVHhzOStPYWk2NVdpb0RScHR2aHFZYXIvUmhFK2pR?=
 =?utf-8?B?ZGJuWnprYTFPQmN2RE5MZ0o2Y0ptcmdvbElQWnVpdHhQSisxS1VCdjFtdmVZ?=
 =?utf-8?B?RkRPU0l1Rmpqa09FZFFibmtZek1HMEh4aVNCV053S2JxOHI2c2RJUmNiZjhD?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca38a311-56b8-4e00-8476-08dbb48a24d1
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 18:49:22.2798
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q4nwLJg8Z3BrVQUvgwT0HhGy1zMG0ePoqo03EdNjcMLxQVLshwyImJ4tXwLA6RqviFAox6wdEDMKuscB+t1Rxp1XQmVBX68GxqEprz/U/Io=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8259
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Sep 2023 11:49:43 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email

Hi Maciej,

On 9/12/2023 10:59 PM, Maciej Wieczór-Retman wrote:
> On 2023-09-12 at 09:00:28 -0700, Reinette Chatre wrote:
>> Hi Maciej,
>>
>> On 9/11/2023 11:32 PM, Maciej Wieczór-Retman wrote:
>>> On 2023-09-11 at 09:59:06 -0700, Reinette Chatre wrote:
>>>> Hi Maciej,
>>>> When I build the tests with this applied I encounter the following:
>>>>
>>>> resctrlfs.c: In function ‘write_schemata’:
>>>> resctrlfs.c:475:14: warning: implicit declaration of function ‘open’; did you mean ‘popen’? [-Wimplicit-function-declaration]
>>>>  475 |         fd = open(controlgroup, O_WRONLY);
>>>>      |              ^~~~
>>>>      |              popen
>>>> resctrlfs.c:475:33: error: ‘O_WRONLY’ undeclared (first use in this function)
>>>>  475 |         fd = open(controlgroup, O_WRONLY);
>>>>      |                                 ^~~~~~~~
>>>> resctrlfs.c:475:33: note: each undeclared identifier is reported only once for each function it appears in
>>>
>>> Hmm, that's odd. How do you build the tests?
>>
>> I applied this series on top of kselftest repo's "next" branch.
>>
>> I use a separate build directory and first ran "make headers". After that,
>> $ make O=<build dir> -C tools/testing/selftests/resctrl
> 
> I do the same, just without the build directory, but that shouldn't
> matter here I guess.
> 
>>> I use "make -C tools/testing/selftests/resctrl" while in the root kernel
>>> source directory. I tried to get the same error you experienced by
>>> compiling some dummy test program with "open" and "O_WRONLY". From the
>>> experiment I found that the "resctrl.h" header provides the declarations
>>> that are causing your errors.
>>
>>From what I can tell resctrl.h does not include fcntl.h that provides
>> what is needed.
> 
> I found out you can run "gcc -M <file>" and it will recursively tell you
> what headers are including other headers.
> 
> Using this I found that "resctrl.h" includes <sys/mount.h> which in turn
> includes <fcntl.h> out of /usr/include/sys directory. Is that also the
> case on your system?
> 

No. The test system I used is running glibc 2.35 and it seems that including
fcntl.h was added to sys/mount.h in 2.36. See glibc commit
78a408ee7ba0 ("linux: Add open_tree")

Generally we should avoid indirect inclusions and here I think certainly so
since it cannot be guaranteed that fcntl.h would be available via 
sys/mount.h.

Reinette