Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Wed, 13 Sep 2023 12:58:15 -0600
From:   Alex Williamson <alex.williamson@redhat.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        oushixiong <oushixiong@kylinos.cn>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Brett Creeley <brett.creeley@amd.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vfio/pds: Using pci_physfn() to fix a compilation issue
Message-ID: <20230913125815.3ef654e6.alex.williamson@redhat.com>
In-Reply-To: <ZP8H0puYJeYF33fn@ziepe.ca>
References: <20230911080828.635184-1-oushixiong@kylinos.cn>
        <BN9PR11MB527657CA940184579FD31CAC8CF2A@BN9PR11MB5276.namprd11.prod.outlook.com>
        <ZP8H0puYJeYF33fn@ziepe.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 11 Sep 2023 09:28:02 -0300
Jason Gunthorpe <jgg@ziepe.ca> wrote:

> On Mon, Sep 11, 2023 at 08:25:18AM +0000, Tian, Kevin wrote:
> > > From: oushixiong <oushixiong@kylinos.cn>
> > > Sent: Monday, September 11, 2023 4:08 PM
> > >=20
> > > From: Shixiong Ou <oushixiong@kylinos.cn>
> > >=20
> > > If PCI_ATS isn't set, then pdev->physfn is not defined.
> > > it causes a compilation issue:
> > >=20
> > > ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: =E2=80=98struct pci=
_dev=E2=80=99 has no
> > > member named =E2=80=98physfn=E2=80=99; did you mean =E2=80=98is_physf=
n=E2=80=99?
> > >   165 |   __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
> > >       |                              ^~~~~~
> > >=20
> > > So using pci_physfn() rather than using pdev->physfn directly.
> > >=20
> > > Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn> =20
> >=20
> > Reviewed-by: Kevin Tian <kevin.tian@intel.com> =20
>=20
> Yes, we should do both patches

Sure, but it's sloppy to put both in with the same commit log.  Should
we change this one to something like:

    vfio/pds: Use proper PF device access helper

    The pci_physfn() helper exists to support cases where the physfn
    field may not be compiled into the pci_dev structure.  We've
    declared this driver dependent on PCI_IOV to avoid this problem,
    but regardless we should follow the precedent not to access this
    field directly.

Thanks,
Alex=20