Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3564739rdb; Wed, 13 Sep 2023 16:35:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6islT0uLMIhThiO4WhQdE9pWRfgm4buwjy7fhlS5ZwXZeMBu1qJPHvRh/1tUWWb95B3Xp X-Received: by 2002:a05:6870:6391:b0:1b4:7411:df6e with SMTP id t17-20020a056870639100b001b47411df6emr4903419oap.15.1694648140681; Wed, 13 Sep 2023 16:35:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694648140; cv=none; d=google.com; s=arc-20160816; b=GHKw9cpKGqHKNANblv6ZAQGXmWDBKuKJqiUUyRb+SswKBvAU0+eHEV5yKIB19UTaTm biNDV1MWF/wpbX0b/cSDrfqCcrR+bZM7pLHBFr32AXZSUkRyj1S30RwHubjGztUoCzGn JLlxHu/pm2cV4vH7b0e7L7M/gC5Dlz3DPdt4Khu5j9i68Tymveh8koXjKW6jHmxespfW qK+tUsB/g8Ar6CQeueNK1t6xdKUJPuKfNUyFljlHEdj/KwSmeaO2KdSPYdaRSDHQt3ZC wBsU6NBwbFNSmAUagV3bN9s6+TA4My5kJ+vurDi37kUDbE/cAQZRyG85w6Kasbh8NaTA rAdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=R9pWS5RKacUJB+Dks28jDzi/RTSOwkJtyGFeCb9s9pw=; fh=/igNXafEZBHF+t+7NCxFPr9CM/PPs8/tuWHaUmNQS+c=; b=SI/NGf4ZU3HmGTW3XwQbwWT42mUFbdB4rZ7a5CHdQBgUf4+jGkOwTdnYakAyMtxR9X C3ksiiH1ofImFyaKlLwcjVcLZVbfVtFOHhBaHGcgXUWzLYpsF4FfxY5xInTRAPXIwMjO LBfViNYv34SixWlUPJXiKXdFUcokTo/mURehE/UGUAA4A4+8iCNeI2gYjILZQXS3c1dg mAi3/VGND1OGFc7RrxcAwOhQd0gBGAJvu/ninq3F8lsANmDCmOmZg2Fgfk2Esh1rqqFE u1Bd56//RBqPHFQO6aisjfjJur1vuA5ZtnEGY6y0LrQRiDdELAe55/QrJB3Zpc5KihDk mjDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="fFLDJHG/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id a14-20020a65640e000000b0056c403cd155si175103pgv.596.2023.09.13.16.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 16:35:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="fFLDJHG/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B20C3815D7F1; Wed, 13 Sep 2023 02:44:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239425AbjIMJol (ORCPT + 99 others); Wed, 13 Sep 2023 05:44:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239380AbjIMJoj (ORCPT ); Wed, 13 Sep 2023 05:44:39 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A7F2198C for ; Wed, 13 Sep 2023 02:44:35 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-64a5bc53646so40860396d6.2 for ; Wed, 13 Sep 2023 02:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694598273; x=1695203073; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R9pWS5RKacUJB+Dks28jDzi/RTSOwkJtyGFeCb9s9pw=; b=fFLDJHG/ehIv5uE6W/xrd+cyq4pSuwHnR+Xt81evRx0L6ZqVnSviiCzI1TfVCT+don DCf28hoqRRUvK5iX6e2e41ppB1nZ0CnzmpYR9PUzSFmZXDxzn1fBmowhGRIFujNFfxjX xrlF7Q+jkFOoXbP0nt9sG81QOT24MUyUi3bCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694598273; x=1695203073; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R9pWS5RKacUJB+Dks28jDzi/RTSOwkJtyGFeCb9s9pw=; b=V6Rmtir0Gz6VL8ul5w/Yrql0GbDj7axPj+SuVeQ61ymyjJYo1af8KKseOzr8U+QuYj xX2D96vdgoZsve+2iw2oFCRfPqgWYNfMODqTLhOzxsa9VjZgfqZFF6xJxL0m+KNs4eim vPU/pLHBPdwRlSl6L8p1l8dfSq/MEw8QlkBRIDxNsjUQWIp4zg6EfvUAn4PvN9aAlZvr 96SWWJmI0SpRzMvnMb6NEO9rOkC4TmgVsETlOiL1ifABiT7uYl4rfB2AR4fbFiSBPEhr h55emvJGgKdUIDXEX6TVlhO2qr3GA44Mq73lvPDUwRWlp7tErmQ621rBdC7kVf2GmDUn CHlg== X-Gm-Message-State: AOJu0YyGS27gs0+X9vc6uWjJW1aYcrZAwNOtF72nH7enXx8xVst3sdLq umpe205woaeT/A91hg23FVcBYrEpplFuqTkEj6s= X-Received: by 2002:ad4:44af:0:b0:63f:9aa3:867b with SMTP id n15-20020ad444af000000b0063f9aa3867bmr2095170qvt.40.1694598273559; Wed, 13 Sep 2023 02:44:33 -0700 (PDT) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com. [209.85.219.47]) by smtp.gmail.com with ESMTPSA id x15-20020ad4458f000000b00655e5724eebsm2538373qvu.66.2023.09.13.02.44.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Sep 2023 02:44:33 -0700 (PDT) Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-64c2e2572f7so40842156d6.1 for ; Wed, 13 Sep 2023 02:44:32 -0700 (PDT) X-Received: by 2002:a05:6214:8ce:b0:64f:518d:ac91 with SMTP id da14-20020a05621408ce00b0064f518dac91mr2055205qvb.8.1694598271822; Wed, 13 Sep 2023 02:44:31 -0700 (PDT) MIME-Version: 1.0 References: <20230828075420.2009568-1-anle.pan@nxp.com> In-Reply-To: From: Tomasz Figa Date: Wed, 13 Sep 2023 18:44:15 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [EXT] Re: [PATCH] media: videobuf2-dma-sg: limit the sg segment size To: Hui Fang Cc: Anle Pan , "m.szyprowski@samsung.com" , "mchehab@kernel.org" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jindong Yue , Xuegang Liu , Xu Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 02:44:46 -0700 (PDT) On Wed, Sep 13, 2023 at 6:14=E2=80=AFPM Hui Fang wrote: > > On Tue, Sep 12, 2023 at 16:52=E2=80=AFPM Tomasz Figa = wrote: > > Right. You may want to try modifying vb2_dma_sg_alloc_compacted() to us= e > > dma_alloc_pages() instead of alloc_pages(). > > Thanks for your suggestion, it works. And it's a better resolution since = no need > an extra copy from high buffer to low buffer. Great to hear! Could you submit a patch? Would appreciate adding Suggested-by: Tomasz Figa above the Signed-off-by line if you don't mind. Thanks. Best regards, Tomasz