Return-Path: <linux-kernel-owner+w=401wt.eu-S1755471AbXKFWZi@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755471AbXKFWZi (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Nov 2007 17:25:38 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754107AbXKFWZa
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 6 Nov 2007 17:25:30 -0500
Received: from smtp2.linux-foundation.org ([207.189.120.14]:33707 "EHLO
	smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754140AbXKFWZ3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Nov 2007 17:25:29 -0500
Date: Tue, 6 Nov 2007 14:23:20 -0800
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Chris Stromsoe <cbs@cts.ucla.edu>
Cc: Adrian Bunk <bunk@kernel.org>, Bill Davidsen <davidsen@tmr.com>,
       James Corey <ploversegg@yahoo.com>, Rob Sims <lkml-z@robsims.com>,
       Kyle Rose <krose@akamai.com>, linux-kernel@vger.kernel.org
Subject: Re: sk98lin for 2.6.23-rc1
Message-ID: <20071106142320.710ddc29@freepuppy.rosehill>
In-Reply-To: <Pine.LNX.4.64.0709090542350.2617@potato.cts.ucla.edu>
References: <20070905102230.10b0bdcf@oldman>
	<782111.42803.qm@web90413.mail.mud.yahoo.com>
	<46E2DF74.7040307@tmr.com>
	<20070908191132.GD3563@stusta.de>
	<Pine.LNX.4.64.0709090542350.2617@potato.cts.ucla.edu>
Organization: Linux Foundation
X-Mailer: Claws Mail 3.0.2 (GTK+ 2.10.14; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3106
Lines: 69

On Sun, 9 Sep 2007 05:54:45 -0700 (PDT)
Chris Stromsoe <cbs@cts.ucla.edu> wrote:

> On Sat, 8 Sep 2007, Adrian Bunk wrote:
> > On Sat, Sep 08, 2007 at 01:44:20PM -0400, Bill Davidsen wrote:
> >
> >> Haven't tried later kernels, don't intend to, while no network is 
> >> really secure, it not really useful.
> >
> > You are a regular reader of linux-kernel, and therefore the sk98lin 
> > removal can hardly be a surprise for you. If you prefer whining over 
> > helping to improve the kernel that's your choice...
> 
> I've been trying to migrate off sk98lin to skge since earlier this year, 
> without success, starting with 2.6.18 or .19.
> 
> I have several of these cards in production using the sk98lin driver:
> 
> fresno:~# lspci -vv -s 02:01
> 02:01.0 Ethernet controller: SysKonnect SK-9872 Gigabit Ethernet Server Adapter (SK-NET GE-ZX dual link) (rev 11)
>          Subsystem: SysKonnect SK-9844 Gigabit Ethernet Server Adapter (SK-NET GE-SX dual link)
>          Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
>          Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
>          Latency: 64 (5750ns min, 7750ns max), Cache Line Size: 32 bytes
>          Interrupt: pin A routed to IRQ 22
>          Region 0: Memory at febfc000 (32-bit, non-prefetchable) [size=16K]
>          Region 1: I/O ports at e800 [size=256]
>          Expansion ROM at febc0000 [disabled] [size=128K]
>          Capabilities: [48] Power Management version 1
>                  Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
>                  Status: D0 PME-Enable- DSel=0 DScale=1 PME-
>          Capabilities: [50] Vital Product Data
> 
> They are dual port SX fiber.  Both ports are connected.  If I do this:
> 
> fresno:~# modprobe skge
> fresno:~# ip li set eth2 up
> fresno:~# ip li set eth2 down
> fresno:~# ip li set eth3 up
> 
> the system locks up and I have to power cycle it.  The order doesn't 
> matter (if I do eth3 up/down, then eth2 up kills it).
> 
> I don't have any problems with sk98lin.  This works fine:
> 
> fresno:~# modprobe sk98lin RlmtMode=DualNet
> fresno:~# ip li set eth2 up
> fresno:~# ip li set eth2 down
> fresno:~# ip li set eth3 up
> fresno:~# ip li set eth3 down
> 
> 
> I am more than happy to test various driver changes, and have tried a few 
> suggested patches but nothing has worked so far.  I would like to be using 
> skge instead of sk98lin, but so far haven't had any success.

Please test 2.6.24-rc1 (or -rc2) because there were several fixes for skge
that made it work correctly for dual port fiber board. The worst bug in skge
was that it configured the ram buffer incorrectly.

I just submitted these for next 2.6.23.X stable release as well

-- 
Stephen Hemminger <shemminger@linux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/