Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3594917rdb; Wed, 13 Sep 2023 17:51:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFF1xMa9nhjK9Sjdtk4tz67Rq49VWUnmI63dyEIy0cZNdiY5gVy7z0MTPu3UD7BeKipwmfL X-Received: by 2002:a05:6a20:748e:b0:149:7fea:d89d with SMTP id p14-20020a056a20748e00b001497fead89dmr3796046pzd.54.1694652677243; Wed, 13 Sep 2023 17:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694652677; cv=none; d=google.com; s=arc-20160816; b=Nn10lwOdfajamuITA8O/yAOpKA2O56XRrgM2FWT52OsQqGueTE879oD1lpDTQQ76Zx bMSPZI7M0z7BSFHZ0X/eGVRjZ29TOSeFkj9C+e5gQEBoyOQ0mWTINy1d5aJ4Risnzg6r 5JOl4MetQpXu7mihTlMpG6HQXQu3bgbIH4tJAPYsbB6PEAGg9yy8lseJzTLDQAnOdPP0 G7SyAbkwEu0bgUWYU8thfEwEeMbXneefIDugYtA8KVx4dP7elXs8gvfcjtI0CswNKL6D GQXNHO5cjwKtmAjDycpbDLenB9jpADcHqGQVk+TUZoT/RVVinr4lS00gANy14dOaYz16 HdQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WgAB9SAfkpGIabHV4CqdvtxhlA1ScpVv8kzv92uGnyM=; fh=H/OByF36Q0rGaXyTPRfC6ikRuy1t2+bbhI9EggyJ9V4=; b=tti5hYgs/MZgHSsn1h+3kbZnCSEgb/GyTEs0mt4kMlgqZCcBdWqqDQbUlKbAJy5KVq 9oYpgQ3Jui68kpuT8ZB9dE5LAYBfvDwZw3pLE1hN3E76ij6/WfYvYQ+zD0JTn1R4W3jV FHWdCdQ5iw1J66jZFu9sOaFvroFIuLX/aXrwzdwpXzrMYG6teh2FEbwGmJr9KAnjPbZy AtY5z/qirjFvElFbqdDTeCDfwKq7Qu21kBEz9zAB2bnllDkT3nVypKkkAmJE8d00vZPd 7yxyg629Im42uYJ3WrINNoD4qWWPED82bGxH3FCw+3ZQBUwKV3IY1bshXy1siPxG/7BX WxcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="Hv/YvKQo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id iw9-20020a170903044900b001c33b5c1fdbsi476518plb.18.2023.09.13.17.51.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 17:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="Hv/YvKQo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D0031802F546; Wed, 13 Sep 2023 14:37:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbjIMVhf (ORCPT + 99 others); Wed, 13 Sep 2023 17:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbjIMVhe (ORCPT ); Wed, 13 Sep 2023 17:37:34 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 816AE1724; Wed, 13 Sep 2023 14:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=WgAB9SAfkpGIabHV4CqdvtxhlA1ScpVv8kzv92uGnyM=; b=Hv/YvKQov0SoJ8rTHsgChXNdgZ e0bGH6agSkcEtOoEXsZmt0aLiwPIlE4e39u95QoWkZvn9dSNFnaHt/YRPsoZ21wUXrNrazh7Zvois vjOSuUv/U/u4GA8evFI10ATj7pLLzu+H1Uc6qcN3E/RjvtyPWRcRL7uDa6wg/B+I2zNk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qgXY1-006LK5-8V; Wed, 13 Sep 2023 23:37:21 +0200 Date: Wed, 13 Sep 2023 23:37:21 +0200 From: Andrew Lunn To: Justin Lai Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v7 02/13] net:ethernet:realtek:rtase: Implement the .ndo_open function Message-ID: References: <20230912091830.338164-1-justinlai0215@realtek.com> <20230912091830.338164-3-justinlai0215@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230912091830.338164-3-justinlai0215@realtek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Sep 2023 14:37:44 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email On Tue, Sep 12, 2023 at 05:18:19PM +0800, Justin Lai wrote: > Implement the .ndo_open function to set default hardware settings > and initialize the descriptor ring and interrupts. Among them, > when requesting irq, because the first group of interrupts needs to > process more events, the overall structure will be different from > other groups of interrupts, so it needs to be processed separately. Please take a look at the page pool code. Andrew