Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <29da2af0-5c88-f937-a9b6-db2d5f481321@intel.com>
Date:   Wed, 13 Sep 2023 12:18:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 2/2] arch: Reserve map_shadow_stack() syscall number for
 all architectures
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
CC:     "svens@linux.ibm.com" <svens@linux.ibm.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "schwab@linux-m68k.org" <schwab@linux-m68k.org>,
        "brgerst@gmail.com" <brgerst@gmail.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "monstr@monstr.eu" <monstr@monstr.eu>,
        "borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
        "dalias@libc.org" <dalias@libc.org>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "hca@linux.ibm.com" <hca@linux.ibm.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
        "ebiederm@xmission.com" <ebiederm@xmission.com>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
        "geert@linux-m68k.org" <geert@linux-m68k.org>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "James.Bottomley@HansenPartnership.com" 
        <James.Bottomley@HansenPartnership.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
        "linux-m68k@lists.linux-m68k.org" <linux-m68k@lists.linux-m68k.org>,
        "tsbogend@alpha.franken.de" <tsbogend@alpha.franken.de>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
        "deller@gmx.de" <deller@gmx.de>,
        "debug@rivosinc.com" <debug@rivosinc.com>,
        "rmclure@linux.ibm.com" <rmclure@linux.ibm.com>,
        "gor@linux.ibm.com" <gor@linux.ibm.com>,
        "slyich@gmail.com" <slyich@gmail.com>,
        "npiggin@gmail.com" <npiggin@gmail.com>,
        "agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
        "chris@zankel.net" <chris@zankel.net>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        "linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
        "mattst88@gmail.com" <mattst88@gmail.com>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "richard.henderson@linaro.org" <richard.henderson@linaro.org>,
        "irogers@google.com" <irogers@google.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "will@kernel.org" <will@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>
References: <20230911180210.1060504-1-sohil.mehta@intel.com>
 <20230911180210.1060504-3-sohil.mehta@intel.com>
 <8b7106881fa227a64b4e951c6b9240a7126ac4a2.camel@intel.com>
Content-Language: en-US
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <8b7106881fa227a64b4e951c6b9240a7126ac4a2.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmxlSG9QWFlvRUlhamI0WTZxQ29LMGZpVnpaMFRXRG1wWElYL3o1ZXQrNE0v?=
 =?utf-8?B?cW10S1lEZm9VTFU4SzJldnJNYmJJdnRNZ1UyOFR4MlF1MFUwZWgxbi9GaThX?=
 =?utf-8?B?eFJoV3EzclNDdEVnZjlwYnRQOEtTUkZqenBtbXE0WUNURktnczM2RzJueVlB?=
 =?utf-8?B?S2I3QzN0T1I0bnJvWkFoeTVpeXFTbHF0b2JQR1QyOXRhd1pybXp0M0FDd3Ey?=
 =?utf-8?B?WUx3TTdzMTYyK05HSzY0MTBBNlBkYVJRMnQ4YmN5WmFadW9tM0VCYkpwQnVC?=
 =?utf-8?B?SmpXN0VPbWJ6TTI5Ujh5QjVheGhEWVdmdld1SHl2MVNlUld4blk5UGh5SnRj?=
 =?utf-8?B?MExibFZSb3BmK0RTdmhYVWwwb3VPTFNHUDkxWnliblZyYjVFaktCQjJ4UUNr?=
 =?utf-8?B?SVcyMFNSQjVHRFNxcnIzQ0x4RzdMYVFYbjJwaWE0WTRiSDZ1bUV3VzVpckRW?=
 =?utf-8?B?ZG1seTlRb0pOQmd0NjVJYStQbzNPRWgwcm5Mb0RLUDlzWlZ1MkpMYk82NXFa?=
 =?utf-8?B?alZ4aHFCQzVZZDJlVEpaQUN1cTR0dFYyOUlEMjV1dFRVelhjZWFmdDZyeFMw?=
 =?utf-8?B?WjlGRU04RmdkS21nNmkwcWN3TTN2VFU5YjdEMzhRT0ZlYm9qWU1aVVRRaTlw?=
 =?utf-8?B?MXlyUUFlaWZ1Y20wK2RhV0tUTjRFdVBvZWliQ3cwUUs3TXJZS200eHF3ZVhF?=
 =?utf-8?B?NUdlMzlTM0FuRm13elVqeWtNOWhScDl4enQxK3VmTFNuTXU5SjVPbkVXdXo2?=
 =?utf-8?B?V1pscGFhcFA2OU5EWTNNSlgwOTlvb2VJM2R2WnFKVmpwVzhhMGhyRit5citT?=
 =?utf-8?B?VWlvZEFnQVRpc0JZekNXNzFScE1aMHpsMHdBa2sxcStNQWszdzJCbEFCNjM5?=
 =?utf-8?B?MEk5cTUrYUhVQ1d3M2R0ZTVaV3RXYnZuV3ZaTm5KclRQODdCREp5bGY5THVY?=
 =?utf-8?B?eVJFMU9ud21zbDFONWxJSUt5WVpBNVFuemxEbjNxcmI4SmJQTzVGRzZhNHI4?=
 =?utf-8?B?V1dOQ2kvU0F2SkdEaisrVnJnT0hqUnRlL3hveVptbHVSQ2hHTTRlOGFHY0Z0?=
 =?utf-8?B?VVhxWjRqMmN3S0swNzdaYjZJQnFuRlFlV093cFB2QW40T2dka3B2Uk1UcDNy?=
 =?utf-8?B?cFBua0pmVEZwNmhrMm9yWlcweExiVGk2TzhGNGJVRWxiWjJOanJIWXJncWg1?=
 =?utf-8?B?YzF5SnpFSEkrS1p4TFFwWVB1MVdjQyt4WFdOd0xZOUkzbGJiTUFpcGptZEtS?=
 =?utf-8?B?ZFZnanBBRGx1RG1xREtNcldJNGVUdU1MZDg5TW1tZHJVSnFuSkNJdWVSVUxo?=
 =?utf-8?B?NE5tbTV6ZjU5T0lla1d3QkkzZzN0WEhRbmtHWlNGVmNlQ2wrZVByWVdBaWgr?=
 =?utf-8?B?Q1J1b2dKMmVSWXZGV1IrSitEN2Q2L0M3Rm0vYk9CNHRXbDR0TExKWVdjLzdZ?=
 =?utf-8?B?WUQ0MkIxMG8rcVltdldiV3hPUUplTGxLcGwwY1hxT253M2JoYWhpMHZxdjNm?=
 =?utf-8?B?SGIwT0dEblpabjZwNE56T0xoYTJ0ZFZsZEVsR281NjNZYUtvR1NveS9GWTgw?=
 =?utf-8?B?QUs0OXFWbi9EVnBDbUNXcy9GNVZENGFWSmE4cVd5OWhycnVYRTVET0NKSytN?=
 =?utf-8?B?SHllT0FmQk5zaWxPcC9mS29PL1dVbktsejdJRU9ERVA3b0VHelA5eFU3amZ2?=
 =?utf-8?B?TDlrckhnUlM0cG1FdDdpcU42MW5zSkR5djlzVTZMWE01bW9iZEp1ZnJ1azlH?=
 =?utf-8?B?ekxIbnZPd3c4SXJtWjFQTkNFSm5CbHZlNXRRV21uaFRndnBZTnd5dUFMRWlv?=
 =?utf-8?B?V0xOa0ljWGtWT0liNVRtSTdEc0JPNnNNdC9BQXJIZXI4QnNNYzk4TktVWlo5?=
 =?utf-8?B?c0xEajlpU1ZmaHE4N2k5ZkZhZitjempYUzJDZ1hoYUZaaVVzSS9VcEVKQVdv?=
 =?utf-8?B?Sk9Gcmp6VjFKTThpN3VLVTR5d2FXdkt6enpOTVNQVDhOayt2eXV2eFJ5Mnlk?=
 =?utf-8?B?Vzh3YjJ5SWcrZzNydXZ1VElWVFdoYi9CbFgwVytwYlZHSWxoSENBZzRwZUtz?=
 =?utf-8?B?andaT1FGUHpFMUFjRy9LbEcreC9Ec3RhQUlBYXlZWUJabVNLUlhONnYzT0Zp?=
 =?utf-8?Q?vemlFFh/fWEgCepxVOg5aWysK?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c37b63a-ed84-4964-0c54-08dbb48e3c4b
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 19:18:39.4465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vm5GlSfx1z6OXYbq9cNmOOQrRB03AerxJhXyvc8PAV8yN8s+Z+DE/xotsDKUmZHZjVD3tG0aOOmqjvQgveCz9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4635
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Sep 2023 12:19:08 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

On 9/11/2023 2:10 PM, Edgecombe, Rick P wrote:
> On Mon, 2023-09-11 at 18:02 +0000, Sohil Mehta wrote:
>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl
>> b/arch/powerpc/kernel/syscalls/syscall.tbl
>> index 20e50586e8a2..2767b8a42636 100644
>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl
>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl
>> @@ -539,3 +539,4 @@
>>  450    nospu   set_mempolicy_home_node         sys_set_mempolicy_hom
>> e_node
>>  451    common  cachestat                       sys_cachestat
>>  452    common  fchmodat2                       sys_fchmodat2
>> +453    common  map_shadow_stack                sys_map_shadow_stack
> 
> I noticed in powerpc, the not implemented syscalls are manually mapped
> to sys_ni_syscall. It also has some special extra sys_ni_syscall()
> implementation bits to handle both ARCH_HAS_SYSCALL_WRAPPER and
> !ARCH_HAS_SYSCALL_WRAPPER. So wondering if it might need special
> treatment. Did you see those parts?
> 

Thanks for pointing this out. Powerpc seems to be unique in their
handling of not implemented syscalls. Maybe it's because of their
special casing of the ARCH_HAS_SYSCALL_WRAPPER.

The code below in arch/powerpc/include/asm/syscalls.h suggests to me
that it should be safe to map map_shadow_stack() to sys_ni_syscall() and
the special handling will be taken care of.

#ifndef CONFIG_ARCH_HAS_SYSCALL_WRAPPER
long sys_ni_syscall(void);
#else
long sys_ni_syscall(const struct pt_regs *regs);
#endif

I don't quite understand the underlying reasoning for it though. Do you
have any additional insight into how we should handle this?

I am thinking of doing the following in the next iteration unless
someone chimes in and says otherwise.

--- a/arch/powerpc/kernel/syscalls/syscall.tbl
+++ b/arch/powerpc/kernel/syscalls/syscall.tbl
@@ -539,4 +539,4 @@
 450    nospu   set_mempolicy_home_node         sys_set_mempolicy_home_node
 451    common  cachestat                       sys_cachestat
 452    common  fchmodat2                       sys_fchmodat2
-453    common  map_shadow_stack                sys_map_shadow_stack
+453    common  map_shadow_stack                sys_ni_syscall