Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <56c0328c-9744-4c69-b0a3-c36cc497fe31@quicinc.com>
Date:   Wed, 13 Sep 2023 20:50:45 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [REBASE PATCH v5 01/17] docs: qcom: Add qualcomm minidump guide
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>, <corbet@lwn.net>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <keescook@chromium.org>, <tony.luck@intel.com>,
        <gpiccoli@igalia.com>, <mathieu.poirier@linaro.org>,
        <catalin.marinas@arm.com>, <will@kernel.org>,
        <linus.walleij@linaro.org>, <andy.shevchenko@gmail.com>,
        <vigneshr@ti.com>, <nm@ti.com>, <matthias.bgg@gmail.com>,
        <kgene@kernel.org>, <alim.akhtar@samsung.com>,
        <bmasney@redhat.com>, <quic_tsoni@quicinc.com>
CC:     <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-gpio@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <kernel@quicinc.com>
References: <1694429639-21484-1-git-send-email-quic_mojha@quicinc.com>
 <1694429639-21484-2-git-send-email-quic_mojha@quicinc.com>
 <ZQF_9-nX47QUCycO@debian.me>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <ZQF_9-nX47QUCycO@debian.me>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/13/2023 2:55 PM, Bagas Sanjaya wrote:
> On Mon, Sep 11, 2023 at 04:23:43PM +0530, Mukesh Ojha wrote:
>> +Qualcomm APSS Minidump kernel driver concept
>> +--------------------------------------------
>> +::
>> +
>> <snipped>...
>> +Dump collection
>> +---------------
>> +
>> +	+-----------+
>> +	|           |
>> +	|           |         +------+
>> +	|           |         |      |
>> +	|           |         +--+---+ Product(Qualcomm SoC)
>> +	+-----------+             |
>> +	|+++++++++++|<------------+
>> +	|+++++++++++|    usb cable
>> +	+-----------+
>> +            x86_64 PC
>> +
> 
> Sphinx reports htmldocs warnings:
> 
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:100: WARNING: Literal block expected; none found.
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:243: WARNING: Unexpected indentation.
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:234: WARNING: Malformed table.
> 
> +-----------+
> |           |
> |           |         +------+
> |           |         |      |
> |           |         +--+---+ Product(Qualcomm SoC)
> +-----------+             |
> |+++++++++++|<------------+
> |+++++++++++|    usb cable
> +-----------+
> /home/bagas/repo/linux-kernel/Documentation/admin-guide/qcom_minidump.rst:243: WARNING: Blank line required after table.
> 
> I have to apply the fixup:
> 
> ---- >8 ----
> diff --git a/Documentation/admin-guide/qcom_minidump.rst b/Documentation/admin-guide/qcom_minidump.rst
> index 20202da8ca40b9..5709a3853ae7ea 100644
> --- a/Documentation/admin-guide/qcom_minidump.rst
> +++ b/Documentation/admin-guide/qcom_minidump.rst
> @@ -95,7 +95,6 @@ could be anywhere scattered in the DDR.
>   
>   Qualcomm APSS Minidump kernel driver concept
>   --------------------------------------------
> -::
>   
>   Qualcomm APSS minidump kernel driver adds the capability to add Linux
>   region to be dumped as part of RAM dump collection. At the moment,
> @@ -231,6 +230,8 @@ respective dump as per set download mode.
>   Dump collection
>   ---------------
>   
> +::
> +
>   	+-----------+
>   	|           |
>   	|           |         +------+
> 

Thanks, will take care.


> Thanks.
>