Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com, bvanassche@acm.org,
        avri.altman@wdc.com, alim.akhtar@samsung.com, andersson@kernel.org,
        konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_cang@quicinc.com, quic_nitirawa@quicinc.com,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: ufs: ufs-qcom: Update PHY settings only when
 scaling to higher gears
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1fs3heeiu.fsf@ca-mkp.ca.oracle.com>
References: <20230908145329.154024-1-manivannan.sadhasivam@linaro.org>
Date:   Wed, 13 Sep 2023 21:21:09 -0400
In-Reply-To: <20230908145329.154024-1-manivannan.sadhasivam@linaro.org>
        (Manivannan Sadhasivam's message of "Fri, 8 Sep 2023 20:23:28 +0530")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+ACIZ2pt37DNEy1LalzBedika+h4O2O1Fpm3iiHX51qDv9hFeFnNens0xNn/?=
 =?us-ascii?Q?QZeAfel7bL39mhqn8gQpQN5+0ShiG/sgoqPcqoqeUfHdRxxKvH7YhrUKziO6?=
 =?us-ascii?Q?SC01qkCBSXnc1KKXdD1FM2RbaiOc9FeA4ho95dQac68v1nEJkKzlPIHv0wBy?=
 =?us-ascii?Q?aUqTMctXdc9MEsoqT9T9UnDmNpObyITQJxpTnAGxTF7+ZYKd9+yvDuA2s2sr?=
 =?us-ascii?Q?aiyOtQAMsbazWALIvz5TFe2EcqI4fiqgvT6fPqkOZJld0yuaX6c53iOOEw0I?=
 =?us-ascii?Q?0nTU15HiBbT7YOjc0BqyUXVuRFiKXylFu3XbCIgT0PmrtHraGH2MnmnpCI0n?=
 =?us-ascii?Q?FICUKe8UdB9pSEv/UD3AwQME40iuA/D6m8/yThXl9SA68wo4lM8E1OGvk5pi?=
 =?us-ascii?Q?SWRR6fo98pl0f1Pl3ghlEr7hzX3uXjgYH9eZRMBGGAh/hSP/I3tfv3V5jf4u?=
 =?us-ascii?Q?9B9v3imha+qiHs/RrzfFxXDvdhUBw9H8MwYvdBvn5H/0Xjms8NAiG0Djjawj?=
 =?us-ascii?Q?OkNLSZXjZ4MbhQ8zY8eZXyaQm5p5fpqrOIvZCp/y0PFmu+Z9QUvA3JHnERZw?=
 =?us-ascii?Q?m4PXwKDZBNnPn7fxfuquOx/IIy8r3Z0CskX4r7trATPbcvEcpQDQ+f5KoGz0?=
 =?us-ascii?Q?9oEirGt3UVANypCgaP8HIMcX3WhijiVeGkhFl2GKpQxKkCa8qVti7ZGeb83Y?=
 =?us-ascii?Q?+DxUsif0vKQH17z+4xik1MnNbpYEBLrylesQPtC0/4yLh3kXf7XleMrZ2AUF?=
 =?us-ascii?Q?BuCBMNJsMTc/j4G0dAlTCRjji+6ZOe52ml+oysd/vIqgdlwYN1i1IRxnAJZY?=
 =?us-ascii?Q?5QqXEaqd6OLQzfIqItJkfampS9BfuZjMnNDDWHRN/ge0Yu+OZqG31Vc0ijPv?=
 =?us-ascii?Q?s1wyUhVqxu9Lv5akthV31LS0J+fkB1Mjr+J1Y/1Nf4c4rt6ptDKN9II7iSbH?=
 =?us-ascii?Q?jV5x+P/GErMSsBmjNWHSCTggsqwkUm1HM9edcWMPD3UBrymwvuBSUc0px4gF?=
 =?us-ascii?Q?2P8i46qJ/VFxH1SwkGXSYbfrStBr1+UU9PZRuqJu+aR+AcFPHHYzPrA90Io3?=
 =?us-ascii?Q?/Spy5mrxpGvYXLt1sdzp3iOO+X0vumKJ2qc+eNqBfCdqljQor1Kd339+1JWD?=
 =?us-ascii?Q?O1N/32wm0pCprwmIKdZuMBmptM2mcezdAeuKeudb4v+sQjSYRcUcfE5KMrLI?=
 =?us-ascii?Q?2IgrJEqEzcazR4l8FGunUtxd9skZVJzn3YZzEGQj36BO6ptu78xiOPalG+rP?=
 =?us-ascii?Q?m3TVNDQzSMymxCG32r0vBgHmia/ihdenRuNquIynYDUld+EeFCBoz4Sy/LWH?=
 =?us-ascii?Q?7URmWeCBF2c7+IV2q35tMT/OZI5fs80hAjGq/zWHGDQTvbewkk/nCWnpxf/E?=
 =?us-ascii?Q?y+dvGncryPU6E1XOroWKOLcAs2YW84SwoCFELBNmt3LUbNfO8S6lXka3rtZd?=
 =?us-ascii?Q?GcJyWskFyki9H6ustFmVYLa8fqpKcpriAOStd1++ZZndE/kOT4Cf8OcsFTJ4?=
 =?us-ascii?Q?5SWpG9T7/uXR7sLVVcYZrG+94Y/lkVDL/Q+5WuU3QR4lHs2qjrqNmbgaRynd?=
 =?us-ascii?Q?NRxud7TZjdiMClQnd3TDsNb2RsjRvezI6bEezy3LTQvTz3vyT8Ux5ssI2rlj?=
 =?us-ascii?Q?PA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?7ymBRzIB3L9Qvn5LwrddfUXUR1Ef3rlzEdciWgY0osmMC5qYjBZMQQl1ZdIP?=
 =?us-ascii?Q?QDOYxqBiF0/WN/4TGoIpmkC8zLh4MasbiiaGkZkbLoA77prruI2/CsKmLW7l?=
 =?us-ascii?Q?9x9JA0rzBztlOe+Kzw41N2BOtZm/i7Q836ISn4kQNnlJvzXAdHiQXjD/tZAC?=
 =?us-ascii?Q?TR9yd7PgC3vz3In3Ux0fg0mSORC8yNk5H94xPU2nAwS2w7avm5LXZJqj7K6i?=
 =?us-ascii?Q?am0Ysae6MRIV6zYO0ZDu1EsOlrJK8SBiRCgs+fgtC7U5Nnzt03uAdZb6KfHs?=
 =?us-ascii?Q?XKtFIp4r1wPmylxgw09Xc1XyFA2OW7t20OXBhdB+H2YQ1/8QUtF8CCeCbJIo?=
 =?us-ascii?Q?mDxA67pXDOgYJNQieiAAA0XQbdzSttDI9HjYrfeOgZWmw5svaAMMz0AFwq50?=
 =?us-ascii?Q?Fgg2g+Yy8YDePQ3loxgXCeFH4J6zaXa4vcFuQX2iDrRE7nydnReKmc+drNcQ?=
 =?us-ascii?Q?3Vu70t1ZJ3XclHSKf2sPh41WHyKVFc/Rbf8DYZOVPFilOV3iMlc5pNUvG1kc?=
 =?us-ascii?Q?rhELXrzq62S8VAGdcD8hRLQxPK5q5qFjQtOLmBYPIznPjJQnNBbfzS7KEGQI?=
 =?us-ascii?Q?b58ti0fUKGdcyuhSRdmqKyz1Yu/tw9fwCvwZrXtFYjMTzU3fxOROqOn26O8x?=
 =?us-ascii?Q?hj0cBnGMhJT87WbgRxPvnUOdg7Uiov+7ci93CKnOH2hymjb/iH7tiLnbXnlY?=
 =?us-ascii?Q?RlQrLMjwqbjDWPR7KSurEmBSzUSXzxCHITSFXxKPk/4UjYYUnvElvhY1buww?=
 =?us-ascii?Q?Xn9MXrXjr76eqhqbY+5jV2PX+hSu38o6Q5NreWwYTlsGSMhnNcjL86RmJ0/R?=
 =?us-ascii?Q?DxOhQoEEr8qs7b4PrKaAQuUAd1vcpayuX7rJyhOLRpQmYWbOUtSlNT6GEAXF?=
 =?us-ascii?Q?VbU7tE5w8sqUkWK8/lwNENtpTQBbmICOJWklBooD7ZGRHC7gPb6Xtl6MNSpG?=
 =?us-ascii?Q?bIW1JwKu+THT9/ZcnXyzJw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc7abc67-45fc-489d-4d72-08dbb4c0e1d1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 01:21:11.9434
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8Rzx+9zpXhlw2/oyzDsxcxVH4RRIFx6LbGborMYzh76lhQzDEgUrBvi+Eyd7J+Q0L9eQ8qediuadNDDj7bFU/7BExvhlPoCxp5E/dsceIpo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4589
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-13_19,2023-09-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0
 spamscore=0 mlxlogscore=878 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000
 definitions=main-2309140010
X-Proofpoint-ORIG-GUID: 0hRu-h21bYYf5ZPvPfXGGch4oksE8Ul0
X-Proofpoint-GUID: 0hRu-h21bYYf5ZPvPfXGGch4oksE8Ul0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Sep 2023 18:21:38 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email


Manivannan,

> The "hs_gear" variable is used to program the PHY settings (submode)
> during ufs_qcom_power_up_sequence(). Currently, it is being updated
> every time the agreed gear changes. Due to this, if the gear got
> downscaled before suspend (runtime/system), then while resuming, the
> PHY settings for the lower gear will be applied first and later when
> scaling to max gear with REINIT, the PHY settings for the max gear
> will be applied.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering