Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3648244rdb; Wed, 13 Sep 2023 20:21:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxFmYnFHIBH3XCrueOmpt+Hrkmt73tU3MOUaQp2LfyDNMUtVI/JevhMitqD5k96o7egYi/ X-Received: by 2002:a05:6a20:8f2a:b0:13c:988c:e885 with SMTP id b42-20020a056a208f2a00b0013c988ce885mr4962814pzk.56.1694661710853; Wed, 13 Sep 2023 20:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694661710; cv=none; d=google.com; s=arc-20160816; b=XKxn2mLpkSyL4A+PJ92Vp2fUR8tBdzkSSQFLI+ZrMDnn/PGroYDLygZ4n+2z0qqIEc Lw4EedrFEm0yJaIvio9inJ8Sd9HbPn/o23ojIP/eIAt5i+3vtSJXTaqxUiCR2VHzsnyt lKGnLiC6Dzmk7dOBIBr136dCLKLYoIkkgqjdVTGLVNGOzBEjR6szdYeTAXBBtND9Odrj Ag5LMkv1iLEnTvYsNowm2P2UtsgbaklK2Zd63OIaFZ0RzpQ5LSp+HzRg5GW19mLdKssC r9qQjf1iskmOtjzcPbxtVe3zvX5Tb7ehnvK3/Ov0PuabhXTv4JExA2yj7hLLPQkMcElQ f2rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OHOOeIA+Zr2Pp4/FMS1+OkxKA3px+f+yyczR42TF17k=; fh=4hAY3FcnLQn5QA5f0WaA/+HGSArGeBv9qLaTh/ce0mo=; b=oJ7ZtCjXV1Hh+YOHDUYSoQFRFmP8UIiaH6ngOkeMF8xkW5EYITs5GceCVotkNNdYNS lcdbyCPZcxkZ6vSGpBpEAhYpaW22PmC+HnB1bJU6Ly8M4j69J77kZH2tb2ulAhOppBlO 2YBVUWo3FVbXUsevjuJ+Fv84jOu3T4nRYmFVR/ulZzXZJ4GzfxCFIYKwDwsjVsPEKXNS oHx5cr0t94IrVx9CnyDS1OLkPXgbR5bYalNXgRu6+i6exUjReTgNVc37iWQG4Xxo9Wzs GZue8Nme4NTsuZ+7K3Bm8Kyi+7kozrw716WD6x69g5tJPMNILmHf7BFSUqOaWsaIeedW ECfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id d10-20020a170902654a00b001b7f4696a2csi655825pln.347.2023.09.13.20.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 20:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 5C69E82E2970; Wed, 13 Sep 2023 20:17:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234318AbjINDQ4 convert rfc822-to-8bit (ORCPT + 99 others); Wed, 13 Sep 2023 23:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234198AbjINDQa (ORCPT ); Wed, 13 Sep 2023 23:16:30 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3179E1BDA; Wed, 13 Sep 2023 20:16:25 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id D432724E28E; Thu, 14 Sep 2023 11:16:09 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 14 Sep 2023 11:16:09 +0800 Received: from xiaofei.localdomain (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 14 Sep 2023 11:16:09 +0800 From: Jack Zhu To: Mauro Carvalho Chehab , Robert Foss , Todor Tomov , , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Greg Kroah-Hartman , Philipp Zabel , Laurent Pinchart , Hans Verkuil CC: , , , , , Subject: [PATCH v9 0/8] Add StarFive Camera Subsystem driver Date: Thu, 14 Sep 2023 11:15:59 +0800 Message-ID: <20230914031607.34877-1-jack.zhu@starfivetech.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Sep 2023 20:17:33 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Hi, This series is the v9 series that attempts to support the Camera Subsystem found on StarFive JH7110 SoC. This series is based on top of the master branch of media_stage repository. The following are the media graph for the device and the v4l2-compliance output. =========================================================================== [the media graph]: digraph board { rankdir=TB n00000001 [label="{{ 0} | stf_isp\n/dev/v4l-subdev0 | { 1}}", shape=Mrecord, style=filled, fillcolor=green] n00000001:port1 -> n00000008 [style=dashed] n00000004 [label="capture_raw\n/dev/video0", shape=box, style=filled, fillcolor=yellow] n00000008 [label="capture_yuv\n/dev/video1", shape=box, style=filled, fillcolor=yellow] n0000000e [label="{{ 0} | cdns_csi2rx.19800000.csi-bridge\n | { 1 | 2 | 3 | 4}}", shape=Mrecord, style=filled, fillcolor=green] n0000000e:port1 -> n00000001:port0 [style=dashed] n0000000e:port1 -> n00000004 [style=dashed] n00000018 [label="{{} | imx219 6-0010\n/dev/v4l-subdev1 | { 0}}", shape=Mrecord, style=filled, fillcolor=green] n00000018:port0 -> n0000000e:port0 [style=bold] } [the device topology]: Media controller API version 6.5.0 Media device information ------------------------ driver starfive-camss model Starfive Camera Subsystem serial bus info platform:19840000.camss hw revision 0x0 driver version 6.5.0 Device topology - entity 1: stf_isp (2 pads, 2 links) type V4L2 subdev subtype Unknown flags 0 device node name /dev/v4l-subdev0 pad0: Sink [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:srgb crop.bounds:(0,0)/1920x1080 crop:(0,0)/1920x1080] <- "cdns_csi2rx.19800000.csi-bridge":1 [] pad1: Source [fmt:YUYV8_1_5X8/1920x1080 field:none colorspace:srgb crop.bounds:(0,0)/1920x1080 crop:(0,0)/1920x1080] -> "capture_yuv":0 [] - entity 4: capture_raw (1 pad, 1 link) type Node subtype V4L flags 0 device node name /dev/video0 pad0: Sink <- "cdns_csi2rx.19800000.csi-bridge":1 [] - entity 8: capture_yuv (1 pad, 1 link) type Node subtype V4L flags 0 device node name /dev/video1 pad0: Sink <- "stf_isp":1 [] - entity 14: cdns_csi2rx.19800000.csi-bridge (5 pads, 3 links) type V4L2 subdev subtype Unknown flags 0 pad0: Sink <- "imx219 6-0010":0 [ENABLED,IMMUTABLE] pad1: Source -> "stf_isp":0 [] -> "capture_raw":0 [] pad2: Source pad3: Source pad4: Source - entity 24: imx219 6-0010 (1 pad, 1 link) type V4L2 subdev subtype Sensor flags 0 device node name /dev/v4l-subdev1 pad0: Source [fmt:SRGGB10_1X10/3280x2464 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range crop.bounds:(8,8)/3280x2464 crop:(8,8)/3280x2464] -> "cdns_csi2rx.19800000.csi-bridge":0 [ENABLED,IMMUTABLE] =========================================================================== [the v4l2-compliance output]: v4l2-compliance 1.24.1, 64 bits, 64-bit time_t Compliance test for stf camss device /dev/video1: Driver Info: Driver name : stf camss Card type : Starfive Camera Subsystem Bus info : platform:19840000.camss Driver version : 6.5.0 Capabilities : 0x84200001 Video Capture Streaming Extended Pix Format Device Capabilities Device Caps : 0x04200001 Video Capture Streaming Extended Pix Format Media Driver Info: Driver name : starfive-camss Model : Starfive Camera Subsystem Serial : Bus info : platform:19840000.camss Media version : 6.5.0 Hardware revision: 0x00000000 (0) Driver version : 6.5.0 Interface Info: ID : 0x0300000a Type : V4L Video Entity Info: ID : 0x00000008 (8) Name : capture_yuv Function : V4L2 I/O Pad 0x01000009 : 0: Sink Link 0x0200000c: from remote pad 0x1000003 of entity 'stf_isp' (Unknown Function (00004009)): Data, Enabled Required ioctls: test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK test invalid ioctls: OK Allow for multiple opens: test second /dev/video1 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 0 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls: test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported) test VIDIOC_G/S_CTRL: OK (Not Supported) test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported) test Composing: OK (Not Supported) test Scaling: OK Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Test input 0: Streaming ioctls: test read/write: OK (Not Supported) test blocking wait: OK test MMAP (no poll): OK test MMAP (select): OK test MMAP (epoll): OK test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total for stf camss device /dev/video1: 53, Succeeded: 53, Failed: 0, Warnings: 0 =========================================================================== Changes in v9: - Rebased on top of the master branch of media_stage repository. - Renamed file name. - Added of_node_put(node) in the error handling path of stfcamss_of_parse_ports(). v8 link: https://lore.kernel.org/all/20230824080109.89613-1-jack.zhu@starfivetech.com/ Changes in v8: - Rebased on v6.5-rc7. - Dropped VIN subdev. - Created two new video devices: capture_raw and capture_yuv, to replace the previous video devices. - Dropped VB2_READ io methods. - Recursively called .s_stream() on subdevs. v7 link: https://lore.kernel.org/all/20230619112838.19797-1-jack.zhu@starfivetech.com/ Changes in v7: - HAS_DMA is used instead of DMA_CMA in Kconfig. - Dropped some non-essential member variables. - Used v4l2_async_nf_add_fwnode_remote() to simplify the relevant code. - Modified some Local variable types in the function. - Used v4l2_create_fwnode_links_to_pad() to simplify the relevant code. - Added error handling for clk_prepare_enable(). - Simplified stfcamss_format_info struct and modified the relevant code. - Dropped enum_input, g_input and s_input. - Unified v4l2_ioctl_ops struct. - Used v4l2_fh_open()/vb2_fop_release to replace deprecated APIs. - Added a camss directory under the starfive directory and modified the patch title. v6 link: https://lore.kernel.org/all/20230525083202.67933-1-jack.zhu@starfivetech.com/ Changes in v6: - Added 'bus-type' in bindings example. - Corrected spelling errors. - As reviewed by Bryan, used 'nclks' and 'nrsts' variables. - Added lccf config for ISP. v5 link: https://lore.kernel.org/all/20230512102844.51084-1-jack.zhu@starfivetech.com/ Changes in v5: - Rebased on v6.4-rc1. - Added new patch. - Modified ISP driver. v4 link: https://lore.kernel.org/all/20230413035541.62129-1-jack.zhu@starfivetech.com/ Previous cover letter from v4: This patch series adds support for the StarFive Camera Subsystem found on StarFive JH7110 SoC. The driver implements V4L2, Media controller and V4L2 subdev interfaces. Camera sensor using V4L2 subdev interface in the kernel is supported. The driver is tested on VisionFive V2 board with IMX219 camera sensor. GStreamer 1.18.5 with v4l2src plugin is supported. Previous version link, missing v1 version: v3: https://lore.kernel.org/all/20230331121826.96973-1-jack.zhu@starfivetech.com/ v2: https://lore.kernel.org/all/20230310120553.60586-1-jack.zhu@starfivetech.com/ Jack Zhu (8): media: dt-bindings: Add JH7110 Camera Subsystem media: admin-guide: Add starfive_camss.rst for Starfive Camera Subsystem media: staging: media: starfive: camss: Add core driver media: staging: media: starfive: camss: Add video driver media: staging: media: starfive: camss: Add ISP driver media: staging: media: starfive: camss: Add capture driver media: staging: media: starfive: camss: Add interrupt handling media: staging: media: starfive: camss: Register devices .../admin-guide/media/starfive_camss.rst | 72 +++ .../media/starfive_camss_graph.dot | 12 + .../admin-guide/media/v4l-drivers.rst | 1 + .../bindings/media/starfive,jh7110-camss.yaml | 180 ++++++ MAINTAINERS | 9 + drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile | 1 + drivers/staging/media/starfive/Kconfig | 5 + drivers/staging/media/starfive/Makefile | 2 + drivers/staging/media/starfive/camss/Kconfig | 17 + drivers/staging/media/starfive/camss/Makefile | 13 + .../staging/media/starfive/camss/stf-camss.c | 436 +++++++++++++ .../staging/media/starfive/camss/stf-camss.h | 134 ++++ .../media/starfive/camss/stf-capture.c | 603 ++++++++++++++++++ .../media/starfive/camss/stf-capture.h | 87 +++ .../media/starfive/camss/stf-isp-hw-ops.c | 445 +++++++++++++ .../staging/media/starfive/camss/stf-isp.c | 407 ++++++++++++ .../staging/media/starfive/camss/stf-isp.h | 428 +++++++++++++ .../staging/media/starfive/camss/stf-video.c | 571 +++++++++++++++++ .../staging/media/starfive/camss/stf-video.h | 100 +++ 20 files changed, 3525 insertions(+) create mode 100644 Documentation/admin-guide/media/starfive_camss.rst create mode 100644 Documentation/admin-guide/media/starfive_camss_graph.dot create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml create mode 100644 drivers/staging/media/starfive/Kconfig create mode 100644 drivers/staging/media/starfive/Makefile create mode 100644 drivers/staging/media/starfive/camss/Kconfig create mode 100644 drivers/staging/media/starfive/camss/Makefile create mode 100644 drivers/staging/media/starfive/camss/stf-camss.c create mode 100644 drivers/staging/media/starfive/camss/stf-camss.h create mode 100644 drivers/staging/media/starfive/camss/stf-capture.c create mode 100644 drivers/staging/media/starfive/camss/stf-capture.h create mode 100644 drivers/staging/media/starfive/camss/stf-isp-hw-ops.c create mode 100644 drivers/staging/media/starfive/camss/stf-isp.c create mode 100644 drivers/staging/media/starfive/camss/stf-isp.h create mode 100644 drivers/staging/media/starfive/camss/stf-video.c create mode 100644 drivers/staging/media/starfive/camss/stf-video.h -- 2.34.1