Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Zi Yan <ziy@nvidia.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org
Cc:     Zi Yan <ziy@nvidia.com>, Andrew Morton <akpm@linux-foundation.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        "\"Mike Rapoport (IBM)\"" <rppt@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH v3 5/5] mips: use nth_page() in place of direct struct
 page manipulation.
Date:   Wed, 13 Sep 2023 22:46:50 -0400
Message-ID: <F0E56181-587E-4F72-92AA-22031921EC46@nvidia.com>
In-Reply-To: <20230913201248.452081-6-zi.yan@sent.com>
References: <20230913201248.452081-1-zi.yan@sent.com>
 <20230913201248.452081-6-zi.yan@sent.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_F8976C30-D161-45AE-AC3B-7E25CF53FD9F_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XOW8u2aAwhfNjyKf38zMFiBTr5cRVs0bZJ0zSzEC66UtPDndvB3K+sqyEUZa?=
 =?us-ascii?Q?nOC9tsqyTncdQ9ofXNv/xd25Zcy4cDgFgc8bIw3SC7QGS5K41pzgYmoop4XM?=
 =?us-ascii?Q?IZ5RbVbOQARn4atPowmfXhQ14D+/TTdNGOjmtkYe41HHCQbZjX+nrcYTDHkD?=
 =?us-ascii?Q?BQKJr6rLFLKefb6uRbrAyJU6KdRv/DdMk3fdT64X4YCcj51LPMmV8TOE5bjU?=
 =?us-ascii?Q?jidFPav/rDvJVjZ+0JTkKccDUPwR6SoZkucLMi4uQ8QCznjDQYo5/uqtV9Ll?=
 =?us-ascii?Q?fz5wGWWC3D7DoO59Ojtt1kxyw89m00JFvz7e8YN5i/ypoFcSWN+NQCS4a155?=
 =?us-ascii?Q?RswMRxNaKrldPRlOgyKVcGheFl9wP0+OLjIEWadT5i8kfCExIVhVp4vYmbkN?=
 =?us-ascii?Q?l4yGi5GfRPEzymn/IB/bqbGcEOIQpardGuV3W3PCIzzTozD/clcFHmluemE2?=
 =?us-ascii?Q?SVR2EMPyep8ekH1d0H4UAuY+zfX6bRBMvMIcdijn8d56NGutxOT8urlxTIKK?=
 =?us-ascii?Q?pQgn1m2yWtASFeaT9MEuW6v8P3j8rQCyckPkDQBlciPkAnQga5kCs12ZIuRv?=
 =?us-ascii?Q?W3pwBR1qt8252ZcXZQ03QV1nlWYEDwJbAz7oiP6+t7ka21VVSf/bs3YqAcx/?=
 =?us-ascii?Q?wJGqmNdTYf1hrQUPzz6fxUOpuWkYuw5b3F2DMGCeppBEoBiLgk7XMVG8HNZI?=
 =?us-ascii?Q?ocx1i7Mjge3CWWVPQiF0M/yEJOmhcau3KROXWyDcHjhKmk876OTY36GAOkKz?=
 =?us-ascii?Q?jxfmnsZVTVSvpg4RnfnzAEq8AKUEQbtbOJMWsbJQnU9ZmKmO1yVRhEMRGfOe?=
 =?us-ascii?Q?04W7T/Bkj9BkwLPWZ2IT617kZNpSgYqt4Ht5k9/734Vr5aET9xhi0pFgVBAL?=
 =?us-ascii?Q?mQjYZOcYb0BtE4tr+JPmlhrQ/XlfFoTvIB3H+YyuRL4nIENW5a/GLOblYX9s?=
 =?us-ascii?Q?uazJ/XBuoG7ldCGKAsXks5EnWvbPJ/rw0NqFs4zVMMWlM4vsTHj0xj7qRQkb?=
 =?us-ascii?Q?RcgQ6XenCa1F1ML3I3C8z6xcOy32F3+MinGEhWRkTq3VjLewX1PzcM9amF/O?=
 =?us-ascii?Q?Udr+DiuZeJBz3onFP9i2f/SU3zy8kC2u3m7vC0Yy79t/+d/Jjc5MJ/0Vukkx?=
 =?us-ascii?Q?BwjBJiDtvFemWthizUnXL174dq81P+tu68MqVKVKCYnqx1Ph+5l99UAFaFv0?=
 =?us-ascii?Q?rNsoMzKCprIt5OYAPd5fEuY6/2OS++H8LJ4Do8QsJUv6hMzt/dTkg7c2E44e?=
 =?us-ascii?Q?It8vyaOesyRskB4vtoofLC84Za3UvWt970mQyt8LnZVktuqt4GtBl+VGWD8y?=
 =?us-ascii?Q?cbl3/BYZ8eRLjIuV15GzOiK3KIyYHDIs0iqADhH80RAcUO27XXtMI0qG3V1i?=
 =?us-ascii?Q?lXvVhVbIm+pVaZSzhxwji/oU06a5GbCduYcv0vqvDrBvq2OFPk7H+L44Ovxl?=
 =?us-ascii?Q?gz2CV7BAM3wcUxY8sBOyz17rfK3fSop9tmIR1rjMGhbpacI/RzcQRJodt8tb?=
 =?us-ascii?Q?JZ5fDKRH5NH/R/vpH1YboNPgld6LYkvkzIufQ2u0VptILmrSUL0av2fCzz0I?=
 =?us-ascii?Q?rOZBphV1dmrvYy0i5ydElzDzj1ITcODLKWGOEuhz?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31c48ad0-1ff7-4c2e-a684-08dbb4ccdb2d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 02:46:54.7543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G2TvaYBEPwr6Lm+x2ycO9MIE0bUSo4BmLBls+9+zHHHjTDRQxv3HgdkQ0XOUL0gh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8718
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 19:47:08 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email

--=_MailMate_F8976C30-D161-45AE-AC3B-7E25CF53FD9F_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 13 Sep 2023, at 16:12, Zi Yan wrote:

> From: Zi Yan <ziy@nvidia.com>
>
> __flush_dcache_pages() is called during hugetlb migration via
> migrate_pages() -> migrate_hugetlbs() -> unmap_and_move_huge_page()
> -> move_to_new_folio() -> flush_dcache_folio(). And with hugetlb and
> without sparsemem vmemmap, struct page is not guaranteed to be contiguo=
us
> beyond a section. Use nth_page() instead.
>
> Fixes: 15fa3e8e3269 ("mips: implement the new page table range API")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> ---
>  arch/mips/mm/cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c
> index 02042100e267..7f830634dbe7 100644
> --- a/arch/mips/mm/cache.c
> +++ b/arch/mips/mm/cache.c
> @@ -117,7 +117,7 @@ void __flush_dcache_pages(struct page *page, unsign=
ed int nr)
>  	 * get faulted into the tlb (and thus flushed) anyways.
>  	 */
>  	for (i =3D 0; i < nr; i++) {
> -		addr =3D (unsigned long)kmap_local_page(page + i);
> +		addr =3D (unsigned long)kmap_local_page(nth_page(page, i));
>  		flush_data_cache_page(addr);
>  		kunmap_local((void *)addr);
>  	}
> -- =

> 2.40.1

Without the fix, a wrong address might be used for data cache page flush.=

No bug is reported. The fix comes from code inspection.


--
Best Regards,
Yan, Zi

--=_MailMate_F8976C30-D161-45AE-AC3B-7E25CF53FD9F_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmUCdBsPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUzGMQAJd1Q3KNwBMqvmm3vGIN/FxECqe3HXjJkv+q
RAQ9DAphpGKBvzx320t1NHRK87iiLw4gXliSAOiBXyo1oK2rBp/EQaWexd3uJkRs
tNHZyk9qJetZ/Wo+NjRhVuZKPst6AwjZkD0JsMKbr6IsPTSnJs/7gyG+QFNEb+Aj
87zsVgNPDvAPQ5UtP0Dngm/QmiACMQqbySh3Simo/px9AuC8nMVae0aAoaf5HnK1
mN6TJ1ADjmt1m6WxCIck/x7b+OWAihIJKnuYd30mdKdpCX1l5QvTfQIx0S6eUCLp
gXEWsSJmBhPruiP9vTxE75yOFaOyESbhcAoUJlPj9/V/bAYDgMkz6VG3Vh3ZASuW
hR4ynLcP/CgYR7+hz5gxvoURHeuFoa0d3s9Ztvq7ky2n0MO0xTfTMgFf9azSFjdM
r6PskMlS7ZHJfEgr+mDeZcrRUWGwD0ZMIloujYuSZWsfHjRrsrOMpTBdu5bbcBD6
MdAWUaCh1GFDzYooGDzIErhtg+M69aCjgYPo7v1eNJtEqvPBQ8DjEi+Ws1LeRR9t
WRh6waktdMQ079oCShpI9BrWX25O5RNqCMgMr4RbNg3cJfDAKvBa+qxufccZl5Wd
YlIZpNiXz0pF9f42qntVAvK/aWy9YzqTCE+e+07NDImO6AKTkqARrjE2XoN42q09
4gKRw9x/
=rg58
-----END PGP SIGNATURE-----

--=_MailMate_F8976C30-D161-45AE-AC3B-7E25CF53FD9F_=--