Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
To:     Ilpo =?utf-8?Q?J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
        Bradley Grove <linuxdrivers@attotech.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/10] scsi: esas2r: Use FIELD_GET() to extract PCIe
 capability fields
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1edj1ftyk.fsf@ca-mkp.ca.oracle.com>
References: <20230913122748.29530-1-ilpo.jarvinen@linux.intel.com>
        <20230913122748.29530-8-ilpo.jarvinen@linux.intel.com>
Date:   Wed, 13 Sep 2023 21:02:18 -0400
In-Reply-To: <20230913122748.29530-8-ilpo.jarvinen@linux.intel.com> ("Ilpo
        =?utf-8?Q?J=C3=A4rvinen=22's?= message of "Wed, 13 Sep 2023 15:27:45
 +0300")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Hpvj8JQodP/LehZ2dCmR8PGLSZTFH8Y+dBtwGPxPe1WSJ3u+jAZy44MmOR3L?=
 =?us-ascii?Q?+ix0qvsoYddhgD8DMrcFta/SFTSvhVjeZm2VWd0Hifg7JreGi6udmLBdF6pM?=
 =?us-ascii?Q?plfLmon4PH9kiJTvV7itI+QbAYzld52eTf0asX2QdrIxM5E3M/t8s8QLGJrA?=
 =?us-ascii?Q?jjnE1Ieaw7JBUz4gX5Jo+hnE4BDYrpGcsyyvPW0nzchrsxBvIioiPyRrGA2N?=
 =?us-ascii?Q?gSmAC9i6qm1qibv1QdEwTA81D/kXbmuiCyGZopIJsx0Fm3WCMRxvK3/18cFp?=
 =?us-ascii?Q?BJj8hOgPgFO2hLLw+iO7L3k0vx1RHyWIaeK2zG/5aeK+oxL92MP6O1U7a8ob?=
 =?us-ascii?Q?1t2nPQ5im83JzfEXayA3Wt5ufNnoKcnuNZYy3ovdlF2RAZtFtWcaCylgvpCP?=
 =?us-ascii?Q?BfBB8wNY8YExIO1+Y3ChMbM2r/RT5A3Bz4DA8LrtEMqCinLdys3THuV9hjR5?=
 =?us-ascii?Q?5V2JOPOmU5N43JZm7mwDYc1UwRHF7Uz5uK/SEOrLzLKKAcWvf+u2gYXhsu34?=
 =?us-ascii?Q?NWpWMpzEl6vfovmkjB6WJNxYpIJfVRGF66jR1ZupCgk8pKFubqWoXCXVgPeA?=
 =?us-ascii?Q?0k4PZM1FMNA8rCDdUsHOUa5cw26djQ6Qv+5SQpOdKgO0KMzPkhfydRS1ejpC?=
 =?us-ascii?Q?rHh2Kj0EmCXJnmxrPKROm/ocZl0DZuKqrX/No3uXsBkZ3lT6kLBnbLojXXL8?=
 =?us-ascii?Q?+GFXC0q7q7ctPkcG+4vXV4Fw2NGd0H/sCYNjvOdul/EiGe6jhm1SKlfEBC70?=
 =?us-ascii?Q?FETqRPXUSpqXiQC1oGopsdCRuAVhqihf1oNM8sborr8U7JAhBfl8w8fDqYhV?=
 =?us-ascii?Q?wwJEk+5VoVa1HxiDYIXBGxgCfNwEZoiu79G0afPAkHeER1xInQRsL5KPnmRR?=
 =?us-ascii?Q?wi9woaJZ+Stk7DE6TxXdCPhjHmrpoe8BcfEHzl8VQ5ZqUdeVqRRtqpMDHJzA?=
 =?us-ascii?Q?mXSG68BZQnEglOLFuqGHoFLRx5cqMLXpOsUt7buFTZdP93Lk6Fw9hqPOcNUG?=
 =?us-ascii?Q?6cmTl5mFZh/nHpduXIFErYff47X+EQAjD+cVJog2/j6BM+kk0vFRWJq5BRVQ?=
 =?us-ascii?Q?+oT/hV4BjGZCohitWsAYQYYHNQEo3RZPzZUDHYSOq0FDeON+wn3aRFP3QPLM?=
 =?us-ascii?Q?yYGr63vSFR8HAQvezq0yvkZfk7ZzKujY6mXSmyBxiSEQPa0o+ONX25YPI3Gj?=
 =?us-ascii?Q?1VVimKmJE0DJHbYhvksHbfHAq1sfttSc3bTRbBAhxQxuTZ5nKXOeIet6Dv6i?=
 =?us-ascii?Q?2eiklXeSiIFK0kpsJHaD3qykk3vD047yJHjH07OgqM+INApfU2ohq0uZ6H4a?=
 =?us-ascii?Q?1WnB9FQl2nZtBIpyj90JdIHD4ltumCaGkyOaOcWmkM1b4VKBm2I5GRk8sTAV?=
 =?us-ascii?Q?d3KwQ3T7Ze7fG6mixSydrDG1h6O1Rejf/YxbwohPXN2U/Rtdpqe+Hkz7jYe1?=
 =?us-ascii?Q?tP9y1WRiiBDoOoR3F1kFNF6tDskDmhdnwgCuGfxmsYSysCNhmf3bBtBjnktu?=
 =?us-ascii?Q?8Mn1sKCVDgX3RBsofeVEE11DNgumHiEL/5zjJVrmBwlPTonrvIoqXs1U1vmH?=
 =?us-ascii?Q?rGLZXG61pKWzs1lfNh5Rn/eFgVVcOf4351xN7yPmtVUeyoo2SneE+i0kS300?=
 =?us-ascii?Q?XA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?n/vnF5xTXCgpmLRwx682LBdP1qZRcwOH19k5e+U0l5MmLeX4G+vSiJs9P9aX?=
 =?us-ascii?Q?iM+21HSJkyiQjXd54NLfWECGH6HyHj90oSFLoU7Q0htDwSbV+puoL9vsThPT?=
 =?us-ascii?Q?bGws5PAleqfCMk2bvNdsISfJTrPk3pldggZfS+dhH0mlCdyO6S0xM0qk/gr7?=
 =?us-ascii?Q?tLo5BQ91VBlAdRASVW+31YSTP7GMQxWQWRNho9AJpogTPmAe1C2B4Q9igoiL?=
 =?us-ascii?Q?yER3t5xdz3fiXhQuyOxTklSRWyZzjC6ozCz2A7AQeScPCx4kiFow6eLwwa9C?=
 =?us-ascii?Q?3KKuDHx850nLzLt7M0JS+fDlrINVO9geadTE30EB5jOOdNJswKWgY3HOU6Oe?=
 =?us-ascii?Q?aAuv36wAFfD0DoeBI+KOJfwC3WTW72Z0BDnzb3vnWJS4JWvRZoZE3nQOqT6U?=
 =?us-ascii?Q?uOB6xSONFKiYR/dtUdRLlW73Zii6uBGv87EVjeaEPWKrLo+daHyvk0J9Jlo9?=
 =?us-ascii?Q?jBmnUFs6vTMa6KXYgZ0eqp+Vj1eCcYzjJVKkgeNwnZW13IH6/OYTRXunu5xn?=
 =?us-ascii?Q?anTx6Sua0dOazMhKtPKYQsOZeLLlMHvCx095+kjM47gYXHxEz5aZyPy8SywE?=
 =?us-ascii?Q?NL2+XDkIqYxiAG0vD6uXrWUdI0AJpicG0Ohr04Ej9GSI21V+PGQqimoHYhw1?=
 =?us-ascii?Q?Qb+jDI7fTgS0ZDdKX72OabgnxlVQYmcHikN5nrO/y/JrqiIGzZWeTbfeVj1X?=
 =?us-ascii?Q?ikUqvSs0VnYUq5oELEYZ94wX5BpHzWkPdnX8gmWWwEO6YPccem8m7mv2r9mA?=
 =?us-ascii?Q?Du39tD7tBRIKgdeHntqlkoLVoPYXMerGsXYF7QXNvybV47SpRnqDqbGxrmKw?=
 =?us-ascii?Q?fUfun6D8X/kpSwsVa5JKF4Ny1/md+yNehejVB7KmKHUeDuApP2YSTileYsu6?=
 =?us-ascii?Q?o9kQin6Vf972UCp1OKrnZTDpCjQvClr6E7QZZMsu2y/jc4pmSjifVVdywBlh?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9e8d9ae-9220-4dc0-fb8c-08dbb4be3f7b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 01:02:20.5941
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 51xeNqgzo5v3sRwFe0POVni4lqszuQvdzKEPoUEtFXB0G1SMYR+cnBUeHYhXLd+Ap4FufPi6CkbXAPFXdghr6fbHl2Bls0itv/SOyBbq2tg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4244
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-13_19,2023-09-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 mlxlogscore=891 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2308100000 definitions=main-2309140007
X-Proofpoint-ORIG-GUID: zbJAV9oumKP3jFoQyq8pulF6rMtiCUG9
X-Proofpoint-GUID: zbJAV9oumKP3jFoQyq8pulF6rMtiCUG9
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 18:08:33 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email


Ilpo,

> Use FIELD_GET() to extract PCIe capability register fields instead of
> custom masking and shifting. Also remove the unnecessary cast to u8,
> the value in those fields always fits to u8.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering