Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <5976613f-8c7b-81a8-3200-9f0603f90743@oracle.com>
Date:   Thu, 14 Sep 2023 07:41:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH v3 3/3] perf pmu: Remove unused function
Content-Language: en-US
To:     James Clark <james.clark@arm.com>,
        linux-perf-users@vger.kernel.org, irogers@google.com,
        acme@kernel.org
Cc:     Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Haixin Yu <yuhaixin.yhx@linux.alibaba.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        Eduard Zingerman <eddyz87@gmail.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230913153355.138331-1-james.clark@arm.com>
 <20230913153355.138331-4-james.clark@arm.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230913153355.138331-4-james.clark@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dW50ZEF0Tms5SUNOK2M1RkxwQ3RrRkVVcVJsVGRIRUlRdWRLRGlYR0tjRHk4?=
 =?utf-8?B?ZzI1NDZIQjJCMkNZaDZqRU8yYnRwMUZsV3ZmZU01NHZOYzlqcENINk15NStn?=
 =?utf-8?B?WnNXZ2E4ZWN5dC9IT21YY2FKUnVnR25KeWtGekU0YmxCZ0F1QnVtNmRaZVV3?=
 =?utf-8?B?YXU5aFV0d3d6L0c5ZzhycENjN3lHYWMxb1kzeUhoblEyd1NkSmtVVE5TOGta?=
 =?utf-8?B?Q0JMd2xLWVU2bXR3MUttcDVMa1ZzZWxhd0FMRE9JSTZ3YjBqSTBmZ0d5ZlBL?=
 =?utf-8?B?VzhhZ0pVdWl2SHZVUmVORzBVU3BqbjhONXpaMWpnZlZNQ2JSOHBHdWowc2pG?=
 =?utf-8?B?OHhleDVjdDhMdnFmSlIxU2E3cjVUN1BQNlZ6RkZuSGlKVlI4SXovQ1ZRWHFO?=
 =?utf-8?B?MHdTVmdKSlFBcVBUUklvYVZ1NFdnZEZ4WjdaVHhDeE5rRTJGSndFU3ZoZUgz?=
 =?utf-8?B?SEgzWUVuME1JODlVVm55S3ZQc0I3Wk85aldUeDllVGd3RFhHbDRvZEdESjVG?=
 =?utf-8?B?ZnYrNitqMm1vWTJTejR5MmNRcVNQdUxiTkc4enlua0pFSFIweGRjWlR5aG1i?=
 =?utf-8?B?YS9NQzZMOFlteUNhcytHdlpqUnJGczZIOXVPL0hmWjJwUTJIdHh2Sys2N2du?=
 =?utf-8?B?UEJ3Z1BpWHE2SFlpRThPOXB2NDljQ0tNbkx6RnYwYzBJTjNWdTRNVWw5UTM1?=
 =?utf-8?B?bmhUYVZhMnFZditzRk05dFFpejVxakp1cGw3VWtQcElnM0RBalRaeU81NGdB?=
 =?utf-8?B?Mkw3aitTUVNDMytSUlB3UVBRY2d0RzJNWWo4cWl0cUtNK3RIZnlUc0wwTFNJ?=
 =?utf-8?B?M0hGOWdvVWtzMjdxRnRVbXd1TmhOS1VzMklmTWgzSWh5d3lVYW5teHZjYXdG?=
 =?utf-8?B?alluMGVKbWVpbWRvdjMxRFhsODJjOEphUENmR0hVYzNBWjhWdllHczZMU0FJ?=
 =?utf-8?B?RzVkWEFhOUFhZFZCQWpjS3JWVFB4VHFjbmpuTlRYWWM4NXhzMDNMV3Y0RFRW?=
 =?utf-8?B?dTAwTHpBWlBUUCswMXFsQkVHaTVSTm1yTVk2OFZ0RTl5Qi9ldHYyLzFwbVVI?=
 =?utf-8?B?UXdFSDhWM2RRYTNab29jK0dzSDFZM25wU3lEbWhtcmhPT1YxcVBpbGs5d2tp?=
 =?utf-8?B?L1I0TC9GWTNiVVN1SWtaeUcrV3NFeDFsQmc4Z0dVb1ZydTM3amdsc2crNWJD?=
 =?utf-8?B?ZW5wNlliQkVsUmxHcDgxdW5PcmNhVTRZYnBkMGovUks4YTI1OUZkSWdOTVBn?=
 =?utf-8?B?VmdiUU9SZmdaN3QzU2FhaG1WVEVQWWt6UEwyNG52bEVTdlN6OFpCQnc2a3U0?=
 =?utf-8?B?cFkxRnZLRVpEaXJYYW9UUCtlYkFlMVo3QWVBQ3VWMGVUdGpEYm5GS2lBOUNt?=
 =?utf-8?B?ZTgxREtVNDFuKzZkeHVZODgzOVU1QnpHR0FLOXNPQ1pTU2lUaXp0ZGdqZTgv?=
 =?utf-8?B?amFRNEcrSmpkaFVpSng3TlpsSVFHbVBCK01wSWlabEhDOFpzblFZT1lNZmww?=
 =?utf-8?B?aWg4c0VyQThiUnRqd3VSS2lXTGh0Y3JIUFlZT2ZQdXB2SVBhejZ5VlJqQUFi?=
 =?utf-8?B?OTFFMVdEQnIrTUpSdFRkSUM2ajFrWDZ3TFNYQnpSYTNVbnJCcUkyRmRQWmpS?=
 =?utf-8?B?RjhnQ0cxTks1Y3ZXc1pEcUFIZmNhSHBnM3o2NG04SWFyUUducXZ3akl6QjNU?=
 =?utf-8?B?T08vZ0ljMXV4eldiR1M1TTAycklOSndMSUVab1F0aEN1MjZpWmVpNTgyc3Bi?=
 =?utf-8?B?WkZCU3hLK1JCVXN0TkM4N2xPc3lKMXVwVDFvWkdPY0oyVjJlMkxwY2N4Mkpl?=
 =?utf-8?B?WWs4NGFrNnpXUHl5TWFoQzR3eUxCTC9jWHVBVzJ5dVBoenhMamgxclpGVXJR?=
 =?utf-8?B?UlpZSU4rL1VQYkVZRzZwQllrRVVFZnV4QmtiN0RlaU5aTVVrYXdRUWs1QUNK?=
 =?utf-8?B?czRVc2xNdFFJT0g5b3Bvb0x0WThOZGxURkU4d2tPRlhvTXViQlBqWUt5QUtK?=
 =?utf-8?B?WUY5YjVsY2pOU1l4aXdUQU90TUVKMlJDREdDNWdGTUErcnpPcXU1blI0R0Y2?=
 =?utf-8?B?cGJBQnhmT2ovUXNYZ3RYMExrTWhlUldzMnBrTzJXSUgvazBCUHV0N1hCQmVs?=
 =?utf-8?Q?37jk1lRrv8yEcukisBjPdsPph?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?dm53Vml4U1FtcUYxalN6bmhPbDZ4N2ZHQkxVMGZ3R0JYY2xqaHl3RVhPMldB?=
 =?utf-8?B?S0dNVUFTQlFmZ1Jpbk5pR0FERDZPUXdmbmNabDZSTUpHZUNuTjgxTkU5aHM3?=
 =?utf-8?B?b0RWanJEbDU5WXI1NDkvRjJ2Q2I2OVJQRUFpSmZFUE5IYkx6SVVaNU1FSWZr?=
 =?utf-8?B?SDk0eE5aZ3ZESVF2cjdPVUkvNVZEN2FSNE9QckRZMkx3RDZaWVVrYktuY2dX?=
 =?utf-8?B?eFdLSzZicUMyeWM5ZlEyV0ZDcHU0QVVoTXdxK0VaSXlVY2pFUk1RY3gxeXpy?=
 =?utf-8?B?MjJTZ1NVMkJFMW5pY1ZqQ3REY0N4VDhncGdjNENhOWsyM21BU0Q4MGNBdW8x?=
 =?utf-8?B?d21ieGNNR0hoYythRFpkdGJ0RFpPZk5rdVo4aXNhcWd1aVFBZjlER2tUZ3Vj?=
 =?utf-8?B?RnpIanFKNXBpWWZJeVA4WkRHL2RMMW14QmczUFQvZ1VjNUVuTk9TSU5WK2tV?=
 =?utf-8?B?ZXpBTWQ0K2lkOERwV1BFTldqRHNjVDc1Z2ZFMDcza1dmZDZiSjNFZUpGWjRj?=
 =?utf-8?B?MzU4bGcyNDVjaFkweXorWFFadVQxZ1BVZG5PdjhqTTBwN3BEQUZ4akplVkk2?=
 =?utf-8?B?b2M0Q2VGY1pBck9LOTdNVmlZdWFMcEZUaSsrT0hDRW80UlpvVTFYQ0ZSTldp?=
 =?utf-8?B?K0w3VjJ2aVN5WkVEb3hkYW15LzV2Unk5SEhvUzAwdGs3YldiNEtDQzhRTEts?=
 =?utf-8?B?MnE3OVRIanBwdjB5T29kN3BYYWpzZUVSZWZPc3VWRlFHTEFyS0dtMEFVYk10?=
 =?utf-8?B?bExXcTRPaDRrVjMvZTVIWVVrSVM3R1FkaVRUVmRZeE84eTNUR01OVTdLcmQ5?=
 =?utf-8?B?Q29SdGNINWpBR2FqbWpVblZMdk9sWGh6QTdqMi9pdEt0eWVqdS90MFFvK01W?=
 =?utf-8?B?WWNWYTI4ZWhic3BaMS9mdkxpY3Z6WU9mUzlMTG5uc0VJMEUvemluODNEQ0Fw?=
 =?utf-8?B?eHVrMjFxZ1BDenY2bW42YmRiV0ZmaHdGVm5RNmZKL213c3pEaXp2aW5NOHV5?=
 =?utf-8?B?MG4vRVNpaTlMaFh3dHYzeTI3MDN5ZGJnVVZFbEw0WGlBdEk1ZXZMbk5QMHls?=
 =?utf-8?B?aENQSUtsb0JaS3dWby84MGViYkxUYUtqcVpReTJwUmtZZkIybGkzWjVIeW8z?=
 =?utf-8?B?czdocnhSVFIvUnFaVUJTc1pYR2lVdnBSME1Ha2FPRjRkc28yalYxbDY1VTh5?=
 =?utf-8?B?UkxkY3grWGNlZTVaUkFxcXZhbkdBZ2NraXFoc3VJRnFISkY0dG8wSFh5MzNv?=
 =?utf-8?B?MTJ0bjdUS2dxSll6V0YrRUFyUHJJT0xEOWlMMHZ2dXhuT0FVOXNabWUwSWpV?=
 =?utf-8?B?MHgzQjV2S0xYWHBXQ1lCVWxGZDVuQjNwcStQMnNDdkU4KzJxS1Y2Sy9zODlt?=
 =?utf-8?B?VFFrSDdoL0VOY2ZCMFNIaUVEV3JMbDBkci9VSzlmS1Azcng5TUZESW1VZGFm?=
 =?utf-8?B?V3BWMU9HVTh5ZHc2ZjdBMWVtZk1GSlhaSFczL1I2K3htdzcxV3RHcGtyRTZS?=
 =?utf-8?B?YTVCc0h1RTZJbjhkclBPby9QZkUzTlh1QlZRM0g2alc2dFZHN09jdTY1V3cr?=
 =?utf-8?B?Sk0xZz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fec42840-1486-4706-7756-08dbb4edad3e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 06:41:51.1839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DjOXvmKfbk7PvtAybSQ58uRlptP9tKr4teFhuG/Ikpzc2Y+90oMuT/ASAsRhlh4+tHJgfz+F8TvV+SObfXsnvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4286
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-14_04,2023-09-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2308100000 definitions=main-2309140058
X-Proofpoint-GUID: 2JUBd5-FhOOCo4yGI6VHqmwPuO7VPtOi
X-Proofpoint-ORIG-GUID: 2JUBd5-FhOOCo4yGI6VHqmwPuO7VPtOi
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 23:42:34 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email

On 13/09/2023 16:33, James Clark wrote:
> pmu_events_table__find() is no longer used so remove it and its Arm
> specific version.
> 
> Reviewed-by: Ian Rogers <irogers@google.com>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---

You really should put the name of the function in the subject. Apart 
from that:

Reviewed-by: John Garry <john.g.garry@oracle.com>

>   tools/perf/arch/arm64/util/pmu.c | 10 ----------
>   tools/perf/util/pmu.c            |  5 -----
>   tools/perf/util/pmu.h            |  1 -
>   3 files changed, 16 deletions(-)
> 
> diff --git a/tools/perf/arch/arm64/util/pmu.c b/tools/perf/arch/arm64/util/pmu.c
> index 3099f5f448ba..2a4eab2d160e 100644
> --- a/tools/perf/arch/arm64/util/pmu.c
> +++ b/tools/perf/arch/arm64/util/pmu.c
> @@ -24,16 +24,6 @@ const struct pmu_metrics_table *pmu_metrics_table__find(void)
>   	return NULL;
>   }
>   
> -const struct pmu_events_table *pmu_events_table__find(void)
> -{
> -	struct perf_pmu *pmu = perf_pmus__find_core_pmu();
> -
> -	if (pmu)
> -		return perf_pmu__find_events_table(pmu);
> -
> -	return NULL;
> -}
> -
>   double perf_pmu__cpu_slots_per_cycle(void)
>   {
>   	char path[PATH_MAX];
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index f50a5636633f..0d81c059c91c 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -776,11 +776,6 @@ char *perf_pmu__getcpuid(struct perf_pmu *pmu)
>   	return cpuid;
>   }
>   
> -__weak const struct pmu_events_table *pmu_events_table__find(void)
> -{
> -	return perf_pmu__find_events_table(NULL);
> -}
> -
>   __weak const struct pmu_metrics_table *pmu_metrics_table__find(void)
>   {
>   	return perf_pmu__find_metrics_table(NULL);
> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
> index d7b46085642d..04b317b17d66 100644
> --- a/tools/perf/util/pmu.h
> +++ b/tools/perf/util/pmu.h
> @@ -238,7 +238,6 @@ void pmu_add_cpu_aliases_table(struct perf_pmu *pmu,
>   			       const struct pmu_events_table *table);
>   
>   char *perf_pmu__getcpuid(struct perf_pmu *pmu);
> -const struct pmu_events_table *pmu_events_table__find(void);
>   const struct pmu_metrics_table *pmu_metrics_table__find(void);
>   
>   int perf_pmu__convert_scale(const char *scale, char **end, double *sval);