Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Fang Hui <hui.fang@nxp.com>
To:     tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        anle.pan@nxp.com, xuegang.liu@nxp.com
Subject: [PATCH] MA-21654 Use dma_alloc_pages in vb2_dma_sg_alloc_compacted
Date:   Thu, 14 Sep 2023 22:58:12 +0800
Message-Id: <20230914145812.12851-1-hui.fang@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qEXL+YfaeMxAzhA2zr1loQvwZEzKTYKrjFBhwxbVPauKzZaHKoW9ORyC4USv?=
 =?us-ascii?Q?nmsKuD2vU1r7cleRie9RdWIeptP2Aw397sBPqa43mn+7mOOgxnWBsw9v9daN?=
 =?us-ascii?Q?Y40qZ5ob9Up2XGdzDWPFQeM8kXE779oRwUvLkAaP6Dp3/AgZwfjCe4wS/52V?=
 =?us-ascii?Q?ON6XYwkM+r6f6+K//w9mh5iQP1uegc+EJqrOOuQtXcBKECc4Sk4t7FycZ9xK?=
 =?us-ascii?Q?/VEVWHLtA7vgra2k9iEvoXH7B/1/NGbbfn6/3sXHGWqnTSRBKEtBlOqkE9v3?=
 =?us-ascii?Q?HFnq6KWeGz+4n0S+P1jrVob5lJ5PMc3DJIb+cEmDPu6r3tVY7hvcRWkTIS2L?=
 =?us-ascii?Q?KVR1qlr+0OIlQxFDEpZ73163lIioly17GEW5H9MKkh3XQjzU9CGyXXo6UzKY?=
 =?us-ascii?Q?Rz54wfv+N5dcK8SY+vXDU1FMUYGxPxnxilLHw+HJGuDZLzRUOIwhcfJUViYz?=
 =?us-ascii?Q?3vJbAH+hTpIOph98bCU5X84C3Z3AFb9yC7MXnrWazUKsWdn2sXbbujUPoAPq?=
 =?us-ascii?Q?t0Dg0mE95j70ztmiBVdvmAyCO9Em2JhOKveWlYmFiJ/5hhRyBbpPcrXSI8N0?=
 =?us-ascii?Q?b62zEpZIXFAHBMi7xyUiIjW6CHRwWsM4jAE6yOhOgpjCAwn+nxPE4Ck4Epoj?=
 =?us-ascii?Q?DQ8CsILZH3EpFTjAv6GLpzkjwXhJX0/EACx+g+4a+6NkjBgMZCGveY42kKG5?=
 =?us-ascii?Q?Pds8yzn4SSxDGATFBstfcVNaIQQf9dMj3rTn2hzpgoBbJ4Fw4VZatmWvGk+q?=
 =?us-ascii?Q?Jp76RMxnBOz/ejOppmjQyKARuZn0T0u157Cfm1dbWGVursHxzOV+rJl2CU4h?=
 =?us-ascii?Q?A1H2blHgGQVSAvAEGWnrMuKGpqkMTX1YffqYHW5SV/qIMv9wP+DN+ZlN97b8?=
 =?us-ascii?Q?IsJuUeg03tZcVqqZ+fLqGB7geNHc0gmWWxJQbzOroJPoaMGfugrf0NUxGcZG?=
 =?us-ascii?Q?+ZB0JP0+qTqrFMDr2xJzKUx+9T9j5cHahJeUgpgB0Ldmvw1LauC1Lg9ThZUa?=
 =?us-ascii?Q?mOSD0zaRhLzZvRmWQVDlB9vTeQ5GAztCFEXfSY1Ug+Rq/+tl/kLsK8lbCUrX?=
 =?us-ascii?Q?SjCbVAa/O+VilmvfK0/4JRX92rGoC0aiOK3M/TQ89UG3CVj3/ePxy3XaCmAx?=
 =?us-ascii?Q?BI7/lgaEVhuHgfipoOasXRcx2M2S4Nco8CgSRF9+vomnZQeUZTMxUxMa33jI?=
 =?us-ascii?Q?VxO+8UieJ+G6nqOFcqrNxaHmA/t3L8r0Ubes7j9ATJNmH3dIxHxIpx1xVj/U?=
 =?us-ascii?Q?muYPZGzKGXVgTSsefdQ86TyckMSt5Pmi9p5yr2UaAt/t78bM3E3qo5o+RiQP?=
 =?us-ascii?Q?eNkkv7hgM6gtmhNf2VuAujpNpU9U31FOSmM5ljsf/qkQZiXTJl5dYMXJ4aUT?=
 =?us-ascii?Q?+c865zfVBGQs7HPn3uP5P6kAeoNAsFb+/dy383cr0/as6IfD83Xvno8HVV1B?=
 =?us-ascii?Q?0ZW4r6YdVAzfJ6GS16uef5yOObzCnJCSYDNOVO32aBzLLIpykfJ2T3sKzB/3?=
 =?us-ascii?Q?yaSucY3OfMQejJ8r/70hoLPyb5j70crJbCdC9SaoUfNZgq/GDQXRr3XEYYfL?=
 =?us-ascii?Q?vtokvbd+hoWZ00XbrQLWvUPHfdHGUmY1trSHgxDm?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a12b7282-768c-4f15-5c45-08dbb4f609e8
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9284.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 07:41:42.6458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: okgPG/v45Kc+MRL7dDVPF5c+CVhCjiFvwt8tBi60UBejmmeaLoneeWlcVEWpcE2SqzoldlCoL1jcCEBCI4xERw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8454
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 14 Sep 2023 00:41:51 -0700 (PDT)
X-Spam-Status: No, score=-0.8 required=5.0 tests=DATE_IN_FUTURE_06_12,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email

On system with "CONFIG_ZONE_DMA32=y", if the allocated physical address is
greater than 4G, swiotlb will be used. It will lead below defects.
1) Impact performance due to an extra memcpy.
2) May meet below error due to swiotlb_max_mapping_size()
   is 256K (IO_TLB_SIZE * IO_TLB_SEGSIZE).
"swiotlb buffer is full (sz: 393216 bytes), total 65536 (slots),
used 2358 (slots)"

To avoid those defects, use dma_alloc_pages() instead of alloc_pages()
in vb2_dma_sg_alloc_compacted().

Suggested-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Fang Hui <hui.fang@nxp.com>
---
 drivers/media/common/videobuf2/videobuf2-dma-sg.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/media/common/videobuf2/videobuf2-dma-sg.c b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
index 28f3fdfe23a2..b938582c68f4 100644
--- a/drivers/media/common/videobuf2/videobuf2-dma-sg.c
+++ b/drivers/media/common/videobuf2/videobuf2-dma-sg.c
@@ -58,7 +58,7 @@ struct vb2_dma_sg_buf {
 static void vb2_dma_sg_put(void *buf_priv);
 
 static int vb2_dma_sg_alloc_compacted(struct vb2_dma_sg_buf *buf,
-		gfp_t gfp_flags)
+		gfp_t gfp_flags, struct device *dev)
 {
 	unsigned int last_page = 0;
 	unsigned long size = buf->size;
@@ -67,6 +67,7 @@ static int vb2_dma_sg_alloc_compacted(struct vb2_dma_sg_buf *buf,
 		struct page *pages;
 		int order;
 		int i;
+		dma_addr_t dma_handle;
 
 		order = get_order(size);
 		/* Don't over allocate*/
@@ -75,8 +76,9 @@ static int vb2_dma_sg_alloc_compacted(struct vb2_dma_sg_buf *buf,
 
 		pages = NULL;
 		while (!pages) {
-			pages = alloc_pages(GFP_KERNEL | __GFP_ZERO |
-					__GFP_NOWARN | gfp_flags, order);
+			pages = dma_alloc_pages(dev, PAGE_SIZE << order, &dma_handle,
+				DMA_BIDIRECTIONAL,
+				GFP_KERNEL | __GFP_ZERO | __GFP_NOWARN | gfp_flags);
 			if (pages)
 				break;
 
@@ -96,6 +98,7 @@ static int vb2_dma_sg_alloc_compacted(struct vb2_dma_sg_buf *buf,
 	}
 
 	return 0;
+
 }
 
 static void *vb2_dma_sg_alloc(struct vb2_buffer *vb, struct device *dev,
@@ -130,7 +133,7 @@ static void *vb2_dma_sg_alloc(struct vb2_buffer *vb, struct device *dev,
 	if (!buf->pages)
 		goto fail_pages_array_alloc;
 
-	ret = vb2_dma_sg_alloc_compacted(buf, vb->vb2_queue->gfp_flags);
+	ret = vb2_dma_sg_alloc_compacted(buf, vb->vb2_queue->gfp_flags, dev);
 	if (ret)
 		goto fail_pages_alloc;
 
-- 
2.17.1