Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <9d4e175b-b8ed-85df-31a2-6bfb4a3616d9@amd.com>
Date:   Thu, 14 Sep 2023 14:08:19 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH 0/5] Add new platform support for DBC
Content-Language: en-US
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        herbert@gondor.apana.org.au, davem@davemloft.net
Cc:     john.allen@amd.com, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230907184846.47598-1-mario.limonciello@amd.com>
 <5d9af84b-59e8-385e-5dff-0f12651fab52@amd.com>
From:   Rijo Thomas <Rijo-john.Thomas@amd.com>
In-Reply-To: <5d9af84b-59e8-385e-5dff-0f12651fab52@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW80Rnp0YTJvaG8rMHFYL1gxTm5nOGd4RXY4UUFJM2F6b3dHU2JINXBHNzI1?=
 =?utf-8?B?MDkvU3BUWHEzekpaOHFTbE9QUW1YZzVZd3Q3T0h4TDlKWENYTUQxMjROd2s0?=
 =?utf-8?B?WW02Ynhzd3NzUXVjZlBLZGkzY0pZSHZUckdacDhHeTF0Zkl0UnhiSjFaMFl4?=
 =?utf-8?B?VEkxMDlLZWV1OW5DOGNZVitGMTBBRGI4d3RmVEQ2cHo2QUhOWnJlZkJKMW0w?=
 =?utf-8?B?U1BxN1JoN3gvamxCZ1NTUEk3bHdPa2xOUXdSc00zRUpsSi9NUi8yMzQwOExK?=
 =?utf-8?B?TENKRGp4VWNmT3U0NHFJa25OVzNjSmRrT0x6M2ZkbHFJTTdDVnVhbzd4L2RQ?=
 =?utf-8?B?WmQ5REpRL1BJaUd4TDJ5WlFDNEptNXRZWWVsdWpDWklWMlo4dkJLZndaLzV6?=
 =?utf-8?B?S2Q4QVV2ejE1UC9NZ0dVb1diQ1pEWEF4cjNXRXVBeDJTSFFrc2NQWEwweEl5?=
 =?utf-8?B?dzNhS2MzRkFXT0xZejVFWStQbk81aUZEMnlaQUlHQ1F3ZFA3cjRXZ0oyWnVj?=
 =?utf-8?B?aEpmTjNDL0tPNVE5WXEvcjZ5V3M4QmtHbXJjMENueHVVN2FQNysrbnlxVUlJ?=
 =?utf-8?B?RGtnSlFUOEJSWHFiQUhQOTNWSFpQK1NjRWcvQmwralo2bkJNV1QrUldHMzJ3?=
 =?utf-8?B?K0hObnNUeFhjTE9WMmlrNVRsblhCY3hNMWozbDUxM0hoNzJDbDhnckhYMmN6?=
 =?utf-8?B?Rm1OeGxKT0RJbnVUWnk0SlFHMjNVd0ZIOG45ZWNNNXJPOGdlQ2VkNTIwTHZS?=
 =?utf-8?B?UkVsRXBrdlZpRE5GYVFLVEtUQWVmYVBFUzRPcmMyMDVSODFmVGxKS2hxYUN3?=
 =?utf-8?B?STFQSjRvd1c0M2cvMW1HK3RNdWdob2FwOGhDR3FGY3lPMzdHcHcyOTNCQXY0?=
 =?utf-8?B?OElJWW9ObW5JVlFjL0xSRUkvRDBiTGkzWE9ROG1ZNHJHV1ZxOFpiQlNUUTZr?=
 =?utf-8?B?bzQ1RndKdEl0RU9oTkp5KzRSMlJ1cVppWjdNM2hVOTVQRlZaMWtDRWdpT1hj?=
 =?utf-8?B?SGJuTCtRclNmQ2l5MFhxYmxTRlFrZ1hKeWhYR2plOFFzQmJKaGZvL1Rsd2ta?=
 =?utf-8?B?c1JkbTJxR0dEQ2NZSG1KOVRXeDhvcGhyK0NES3FGNXBYTGEyR3RHc21yVTEz?=
 =?utf-8?B?a0ZkcDV2YUtGT3F1aHgxd1B2NzljT1pQbnI5MjZFdkdPZXF0dElCNXhZeDdS?=
 =?utf-8?B?YXJDcGYrZFBDWGJreEt0NlcrQ1E2R0VEWnJlY3VEMXgxR0VsalhRUS9TZW5W?=
 =?utf-8?B?MFBURlVGZnlnT05lRll4VW10alJRU2ZkOXBEbHZraUFXUGZRSUxCVXl5dFBB?=
 =?utf-8?B?RW9Ec050dklqdWE2SFIvRG01amxlemRic09HVzdubVlCS3ZBdHR0THUwQUVI?=
 =?utf-8?B?MEZtakZMbis4RU1OUUVkRnA2ZmpKZm1CTVRhTmhtTmtwRm56aVVDdW5haU1O?=
 =?utf-8?B?SW45TWVxR0ZGTXBteGF1Z3FhY1hJT2lZcGRWT2cwVmpwNlJYa2wvWHdrSUxJ?=
 =?utf-8?B?enhFeGdWQ2wya3I1eWI3SjRqOTVBQnNCUFNyOE9TdWFsbkxGRjBhNVUyZUZK?=
 =?utf-8?B?U2hxSURkdXIvRXg1VUZtdEVmRTBoNFZjU0FPS1VtaWtmTXAyanVMamxIOHJv?=
 =?utf-8?B?MlR6R3hybko1WFc1eUFMVThuZVgvWHpld1dUd0c5WFgxVmwrSlJPRVBEcnQw?=
 =?utf-8?B?MEI5b2FEVjBsUVZvaXlyaTMxZi9vaXlrTGNKSzQ2eWNrNDJ4bVBYKzhXQ2d0?=
 =?utf-8?B?UlNjcitKWjFGVEcvcTF3VGNCQmV1V1lqTG54TjZ6c0pzaEhpaWJvb01jbkJY?=
 =?utf-8?B?UkFvd0V4RHpReVBRMzNjNFQ2S3h4M3dLTFlOaWxnckZHSmVnZFBRcnpUbTRv?=
 =?utf-8?B?ZytQR1BkODY1WHpqZ08yeU9oOU9Rc3dvM1NTQ01LWEFucmNqYThVNFA3NldW?=
 =?utf-8?B?MkhPQ3dXQ3pIY1I5Z002Y1YxbThQSldhcDNnUkNrRVp6TDlZbTdDVWE3YlJs?=
 =?utf-8?B?ZGRFMXdRZDEvZVFLcHR5d0ZJcXg1RVFaWW0zb0VRUElUUFNURWRRR0dyeG90?=
 =?utf-8?B?UDR4K2IveGhNbGxOdnFDNHQrZWt3RStzTFVtTTB4MUdMY2pCQVFDcmxMOXB4?=
 =?utf-8?Q?mQvkqeOaUd5OGnWGFIv/noxjg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 993a939c-7444-4b4c-6adc-08dbb4fdfacf
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5346.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 08:38:33.4612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iLAUI686uB35LCnnTuCAPuFkI2ydR4agnUET+xzp+bag9OUwtxo60HCGpeXUV0RNiOItmcxkTqvfWGOTjYg24Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5760
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Sep 2023 01:38:49 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email


On 9/8/2023 2:58 AM, Tom Lendacky wrote:
> On 9/7/23 13:48, Mario Limonciello wrote:
>> Some platforms that support dynamic boost control (DBC) support it via
>> a different mailbox than the platform access mailbox.
>>
>> This series adds support for those platforms.
>>
>> It is tested on top of the fixes series. The prerequisite patches refer
>> to that series.
>> Link: https://lore.kernel.org/linux-crypto/20230829150759.156126-1-mario.limonciello@amd.com/T/#m47782729377f6fe5d62130cc701dae7f15306726
>>
>> Mario Limonciello (4):
>>    crypto: ccp: Add support for extended PSP mailbox commands
>>    crypto: ccp: Add a communication path abstraction for DBC
>>    crypto: ccp: Add a macro to check capabilities register
>>    crypto: ccp: Add support for DBC over PSP mailbox
>>
>> Tom Lendacky (1):
>>    crypto: ccp: Move direct access to some PSP registers out of TEE
>>
>>   drivers/crypto/ccp/dbc.c     |  72 ++++++++++++++-------
>>   drivers/crypto/ccp/dbc.h     |  29 +++------
>>   drivers/crypto/ccp/psp-dev.c | 122 ++++++++++++++++++++++++++++-------
>>   drivers/crypto/ccp/psp-dev.h |  55 ++++++++++++++++
>>   drivers/crypto/ccp/sp-dev.h  |   4 ++
>>   drivers/crypto/ccp/sp-pci.c  |  22 ++++---
>>   drivers/crypto/ccp/tee-dev.c |  48 +++-----------
>>   drivers/crypto/ccp/tee-dev.h |  15 +----
>>   8 files changed, 241 insertions(+), 126 deletions(-)
>>
> 
> Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> 
> But I would like to see a Reviewed-by: or Tested-by: from Rijo-john for the TEE changes.
> 

Done.

Acked-by: Rijo Thomas <Rijo-john.Thomas@amd.com>

Thanks,
Rijo

> Thanks,
> Tom
> 
>>
>> base-commit: 7ba2090ca64ea1aa435744884124387db1fac70f
>> prerequisite-patch-id: 4bcf7f3ea21472e4e28c2457cc9827f6023ec6ca
>> prerequisite-patch-id: 903be53a20306f0188e52015dbfe5196738bb2eb
>> prerequisite-patch-id: af396bafb6acaa9c203c1a2c5f4665171cb45e4f
>> prerequisite-patch-id: abe450d4bf1de4a5664a41dbf84e72b1d4bfdae7
>> prerequisite-patch-id: b0b9cf55fcb73a11de6f3da73412fb090562857a