Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
Date:   Thu, 14 Sep 2023 10:02:47 +0200
From:   =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
To:     =?UTF-8?Q?Ar=C4=B1n=C3=A7_=C3=9CNAL?= <arinc.unal@arinc9.com>
Cc:     =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <zajec5@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-mtd@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Scott Branden <scott.branden@broadcom.com>
Subject: Re: [PATCH] nvmem: brcm_nvram: store a copy of NVRAM content
In-Reply-To: <3f175090-4c5f-4821-9155-06c4868d0489@arinc9.com>
References: <20230914064922.3986-1-zajec5@gmail.com>
 <3f175090-4c5f-4821-9155-06c4868d0489@arinc9.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <d0545951a0e787792c5cc20eca66a72a@milecki.pl>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023-09-14 09:56, Arınç ÜNAL wrote:
> On 14.09.2023 09:49, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>> 
>> This driver uses MMIO access for reading NVRAM from a flash device.
>> Underneath there is a flash controller that reads data and provides
>> mapping window.
>> 
>> Using MMIO interface affects controller configuration and may break 
>> real
>> controller driver. It was reported by multiple users of devices with
>> NVRAM stored on NAND.
>> 
>> Modify driver to read & cache all NVRAM content during init and use 
>> that
>> copy to provide NVMEM data when requested.
>> 
>> Link: 
>> https://lore.kernel.org/linux-mtd/CACna6rwf3_9QVjYcM+847biTX=K0EoWXuXcSMkJO1Vy_5vmVqA@mail.gmail.com/
>> Cc: Arınç ÜNAL <arinc.unal@arinc9.com>
>> Cc: Florian Fainelli <florian.fainelli@broadcom.com>
>> Cc: Scott Branden <scott.branden@broadcom.com>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> This is a bug fix, could you add a "Fixes" tag so it will be backported 
> to
> stable releases?

I suppose we could try:
Fixes: 3fef9ed0627a ("nvmem: brcm_nvram: new driver exposing Broadcom's 
NVRAM")

Srini: can you append it while applying if you find it OK?

-- 
Rafał Miłecki