Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20230901120836.1057900-1-yann.gautier@foss.st.com>
 <CACRpkdacRe5cPoSFJyEdo6nZrtmUHTNqMxf55CntvsdpFqhhrQ@mail.gmail.com>
 <CAPDyKFqJzoBiG4c2NbXA_6YDNsAh4W0TO-SP9+C2Qw40TKVH7g@mail.gmail.com> <ab2f88c3-2f80-a0ae-3a74-d90dd2a6ccf3@foss.st.com>
In-Reply-To: <ab2f88c3-2f80-a0ae-3a74-d90dd2a6ccf3@foss.st.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 14 Sep 2023 13:51:51 +0200
Message-ID: <CACRpkdY1cU4D_qbC3g6wV5hcKVCL6uMJu9mH=byw+2RgQTPicQ@mail.gmail.com>
Subject: Re: [PATCH] mmc: mmci: stm32: add SDIO in-band interrupt mode
To:     Yann Gautier <yann.gautier@foss.st.com>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Christophe Kerello <christophe.kerello@foss.st.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Rob Herring <robh@kernel.org>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Sep 14, 2023 at 11:08=E2=80=AFAM Yann Gautier <yann.gautier@foss.st=
.com> wrote:
> On 9/4/23 14:21, Ulf Hansson wrote:
> > On Fri, 1 Sept 2023 at 16:10, Linus Walleij <linus.walleij@linaro.org> =
wrote:
> >>
> >> Hi Yann/Christophe,
> >>
> >> thanks for your patch!
> >>
> >> On Fri, Sep 1, 2023 at 2:08=E2=80=AFPM Yann Gautier <yann.gautier@foss=
.st.com> wrote:
> >>
> >>> From: Christophe Kerello <christophe.kerello@foss.st.com>
> >>>
> >>> Add the support of SDIO in-band interrupt mode for STM32 variant.
> >>> It allows the SD I/O card to interrupt the host on SDMMC_D1 data line=
.
> >>>
> >>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
> >>> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
> >> (...)
> >>> +++ b/drivers/mmc/host/mmci.h
> >>> @@ -332,6 +332,7 @@ enum mmci_busy_state {
> >>>    * @opendrain: bitmask identifying the OPENDRAIN bit inside MMCIPOW=
ER register
> >>>    * @dma_lli: true if variant has dma link list feature.
> >>>    * @stm32_idmabsize_mask: stm32 sdmmc idma buffer size.
> >>> + * @use_sdio_irq: allow SD I/O card to interrupt the host
> >>
> >> The documentation tag should be one line up (compare to the members...=
)
> >>
> >>> @@ -376,6 +377,7 @@ struct variant_data {
> >>>          u32                     start_err;
> >>>          u32                     opendrain;
> >>>          u8                      dma_lli:1;
> >>> +       u8                      use_sdio_irq:1;
> >>
> >> 1. bool use_sdio_irq;
> >>
> Hi,
>
> Should it really be changed to a bool?
> Other boolean likes in the structure are u8:1.

Yes, two wrongs does not make one right.

Using u8:1 is a way of trying to outsmart the compiler
which is generally a bad idea.

> > That said, the out-of-band IRQs is what works best for the ux500 varian=
ts.
>
> What I understand here is that in-band interrupts are not properly
> working on ux500, and then the feature shouldn't be enabled for this
> platform.
> Am I correct?

I think we can flag the feature as available and implement the handling
but add a comment that this is unstable and that Ux500 users should
prefer to use out-of-band IRQs.

Yours,
Linus Walleij